| Message ID | CAFr9PXm1Y=HHy4znDBVdxpd2ndHKdu+_unfgSGHkJFotSZ9HKA@mail.gmail.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | meson for host package with executables doesn't work. | expand |
Hello Daniel, On Thu, 11 Oct 2018 18:25:39 +0900, Daniel Palmer wrote: > That was working fine a few months ago but now I get this: > > *** > *** ERROR: package host-json-glib installs executables without proper RPATH: > *** <snip>/buildroot-firmware/output/host/bin/json-glib-validate > *** <snip>/buildroot-firmware/output/host/bin/json-glib-format > > As far as I know meson strips RPATH on install and there is no way to > stop it doing that outside of adjusting the build file. > > Does anyone have any ideas about how this should be fixed? We really need the host tools to have an rpath pointing to $(HOST_DIR)/lib, otherwise they won't pick up the libraries that we have installed in $(HOST_DIR)/lib. Thomas
Hi Thomas, Looking through the history in git it looks like this was broken by commit a03f46ca6e9f43028003aedc92f1a1204ae7480f that bumped the version of meson and removed a patch that stops meson from stripping the RPATH on host executables. I guess because there are no packages in-tree that used it (I couldn't find host-meson-package in any packages) no one noticed. Cheers, Daniel On Thu, 11 Oct 2018 at 19:01, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote: > > Hello Daniel, > > On Thu, 11 Oct 2018 18:25:39 +0900, Daniel Palmer wrote: > > > That was working fine a few months ago but now I get this: > > > > *** > > *** ERROR: package host-json-glib installs executables without proper RPATH: > > *** <snip>/buildroot-firmware/output/host/bin/json-glib-validate > > *** <snip>/buildroot-firmware/output/host/bin/json-glib-format > > > > As far as I know meson strips RPATH on install and there is no way to > > stop it doing that outside of adjusting the build file. > > > > Does anyone have any ideas about how this should be fixed? > > We really need the host tools to have an rpath pointing to > $(HOST_DIR)/lib, otherwise they won't pick up the libraries that we > have installed in $(HOST_DIR)/lib. > > Thomas > -- > Thomas Petazzoni, CTO, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com
Hello, On Thu, 11 Oct 2018 20:42:30 +0900, Daniel Palmer wrote: > Looking through the history in git it looks like this was broken by > commit a03f46ca6e9f43028003aedc92f1a1204ae7480f that bumped the > version of meson and removed a patch that stops meson from stripping > the RPATH on host executables. I guess because there are no packages > in-tree that used it (I couldn't find host-meson-package in any > packages) no one noticed. Indeed, it could very well be due to this. Could you check if re-adding this patch makes things work again ? If it does, please submit a patch re-adding the patch :-) Thanks, Thomas
Hi, I forward ported the patch to the version of meson that is in buildroot now and the problem is resolved. I'll submit a patch when I have some time over the weekend. Thanks, Daniel On Thu, 11 Oct 2018 at 23:31, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote: > > Hello, > > On Thu, 11 Oct 2018 20:42:30 +0900, Daniel Palmer wrote: > > > Looking through the history in git it looks like this was broken by > > commit a03f46ca6e9f43028003aedc92f1a1204ae7480f that bumped the > > version of meson and removed a patch that stops meson from stripping > > the RPATH on host executables. I guess because there are no packages > > in-tree that used it (I couldn't find host-meson-package in any > > packages) no one noticed. > > Indeed, it could very well be due to this. Could you check if re-adding > this patch makes things work again ? If it does, please submit a patch > re-adding the patch :-) > > Thanks, > > Thomas > -- > Thomas Petazzoni, CTO, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com
On 11/10/18 17:18, Daniel Palmer wrote: > Hi, > > I forward ported the patch to the version of meson that is in buildroot now > and the problem is resolved. I'll submit a patch when I have some time > over the weekend. Upstream claims that the issue is fixed [1][2], so I would prefer to work with upstream to actually fix the issue upstream. I've commented on the issue (github doesn't allow reopening). Regards, Arnout [1] https://github.com/mesonbuild/meson/issues/314 [2] https://github.com/mesonbuild/meson/commit/e3757e3d3cf24327c89dd3fc40f6cc933510f676 > > Thanks, > > Daniel > On Thu, 11 Oct 2018 at 23:31, Thomas Petazzoni > <thomas.petazzoni@bootlin.com> wrote: >> >> Hello, >> >> On Thu, 11 Oct 2018 20:42:30 +0900, Daniel Palmer wrote: >> >>> Looking through the history in git it looks like this was broken by >>> commit a03f46ca6e9f43028003aedc92f1a1204ae7480f that bumped the >>> version of meson and removed a patch that stops meson from stripping >>> the RPATH on host executables. I guess because there are no packages >>> in-tree that used it (I couldn't find host-meson-package in any >>> packages) no one noticed. >> >> Indeed, it could very well be due to this. Could you check if re-adding >> this patch makes things work again ? If it does, please submit a patch >> re-adding the patch :-) >> >> Thanks, >> >> Thomas >> -- >> Thomas Petazzoni, CTO, Bootlin >> Embedded Linux and Kernel engineering >> https://bootlin.com > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot >
diff --git a/package/json-glib/json-glib.mk b/package/json-glib/json-glib.mk index 77c0c4532374..4cd754a3a6c5 100644 --- a/package/json-glib/json-glib.mk +++ b/package/json-glib/json-glib.mk @@ -17,4 +17,9 @@ JSON_GLIB_DEPENDENCIES = \ host-pkgconf \ libglib2 +HOST_JSON_GLIB_DEPENDENCIES = \ + host-pkgconf \ + host-libglib2 + $(eval $(meson-package)) +$(eval $(host-meson-package))