From patchwork Fri Mar 4 13:10:58 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gary Bisson X-Patchwork-Id: 592037 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ozlabs.org (Postfix) with ESMTP id 0B4F714029E for ; Sat, 5 Mar 2016 00:11:06 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=boundarydevices-com.20150623.gappssmtp.com header.i=@boundarydevices-com.20150623.gappssmtp.com header.b=WWBWjsd1; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 018828A8AE; Fri, 4 Mar 2016 13:11:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TQYukVqVHa4n; Fri, 4 Mar 2016 13:11:03 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id EE9598A816; Fri, 4 Mar 2016 13:11:02 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id CB8301C105C for ; Fri, 4 Mar 2016 13:11:00 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id C5E718A6B7 for ; Fri, 4 Mar 2016 13:11:00 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Gl78JhFe1GDD for ; Fri, 4 Mar 2016 13:11:00 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail-yw0-f172.google.com (mail-yw0-f172.google.com [209.85.161.172]) by whitealder.osuosl.org (Postfix) with ESMTPS id 085128A78E for ; Fri, 4 Mar 2016 13:10:59 +0000 (UTC) Received: by mail-yw0-f172.google.com with SMTP id b72so41057124ywe.0 for ; Fri, 04 Mar 2016 05:10:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=boundarydevices-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=KegX/aRhQZ6blul7JMYhw1cCHaeC08ibyqKN6TQLsyY=; b=WWBWjsd12n9WtFSalm1Fj5u1YGpcPczL6fvl2TBsYVcUBuoG0gC7KJ2eywx68WriU1 MRKJByHQ2PJmocb1cdecjYcK9YtZuoZKvR4eBaZMwWFkquLO310URPVmPPaSU4vR8mHI yGMlemqvjgO79RdaSnCcocphEBsLS9FA6CVhrfmY3okGWnKi2wTmXFIQBDuHki1dqrPz IFlFgNjcUeDBMmqqEybt4r4nseGKkonI/DEpEDro7xEd4+avZBPwhxT55vtp2NGEqFn1 HELY3RARFCJl2R0FPlXGCjSaHc/66qvnHxfcgSbm6fWqgRPHeEVfWhvOBafR4JhmdsaV ABrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=KegX/aRhQZ6blul7JMYhw1cCHaeC08ibyqKN6TQLsyY=; b=H3uQ3jfSfqo7fms3388t+WqeUxPEAlfI1LcF2q6LKLjjRfO7QMyPAQSgEUW+lLXUwE ISIBeBIp5nx1pbDeF1coBLYHMfO0fqHkXFR64XNp2DNKwwj5K2yE3guQu53ydaIUbGjp utLc0JM9PiQDHGLiv9DKWFl2UcVzMqzQTTBpdwCyiZhV+Gh9skUvjj/yFTy1oWVZmiXy ZBRzBwIOZCJ1Z1cCEc04CG308moL40MyKcUNzvaI9AGm+ad2slUG/2PRZQMzUWICy2xg 2IFAUrMDL8M1fHz+Bed4fIsnsFkbIg6eiNktnbzGukb8ObBfllC1Qy44CbUk1nW/gLb5 PVOA== X-Gm-Message-State: AD7BkJLx+C3p2OdDLIrCtDlQToCHHlUTRc/wBqWQ1spfCj03pfCDrR1+Xuo3MtwgnVAdGd/qlnGTWkJORP4Tqg== MIME-Version: 1.0 X-Received: by 10.129.86.131 with SMTP id k125mr4137802ywb.158.1457097059031; Fri, 04 Mar 2016 05:10:59 -0800 (PST) Received: by 10.37.115.78 with HTTP; Fri, 4 Mar 2016 05:10:58 -0800 (PST) In-Reply-To: <20160304121347.5f73916e@free-electrons.com> References: <20160304095534.GA16799@kwain> <20160304121347.5f73916e@free-electrons.com> Date: Fri, 4 Mar 2016 14:10:58 +0100 Message-ID: From: Gary Bisson To: Thomas Petazzoni Cc: buildroot@busybox.net, =?UTF-8?B?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: Re: [Buildroot] Build failure with Vivante and QT5 w/ eglfs X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Thomas, All, On Fri, Mar 4, 2016 at 12:13 PM, Thomas Petazzoni wrote: > Gary, > > On Fri, 4 Mar 2016 12:02:31 +0100, Gary Bisson wrote: > >> > I understand this configuration can't work, but as this leads to a >> > build issue we might need to think about a solution. We could disallow >> > such a configuration tuple, or fix the build. >> > >> > Any idea? >> >> I'm afraid forcing the imx-gpu-viv package output format depending on >> qt5 graphical back end would bring many "recursive dependency" issues. > > I don't see why it would create recursive dependency issues. Well my thought process was that it was kind of forbidden to modify the qtbase package for a i.MX-specific corner case. So I tried to force it in imx-gpu-viv to use fb depending on BR2_PACKAGE_QT5BASE_EGLFS but it only brought those recursive issues. > However, it would violate the principle of virtual packages, since Qt5 > is not supposed to have some dependencies that are specific to certain > OpenGL implementations. It should normally just use dependencies on the > OpenGL ES / EGL packages, and nothing else. > > However, we could probably add some exceptions to this rule. Or rework > the virtual package logic so that consumers of OpenGL can now whether > the FB or X11 support is available. Well if we are allowed to modify qtbase I guess it would be way easier. Would something like this be acceptable? index 64a7f65..aa54b3e 100644 Regards, Gary --- a/package/qt5/qt5base/Config.in +++ b/package/qt5/qt5base/Config.in @@ -201,10 +201,14 @@ config BR2_PACKAGE_QT5BASE_EGLFS select BR2_PACKAGE_QT5BASE_OPENGL depends on BR2_PACKAGE_HAS_LIBEGL depends on BR2_PACKAGE_QT5_GL_AVAILABLE + depends on !BR2_PACKAGE_IMX_GPU_VIV_OUTPUT_X11 comment "eglfs backend available if OpenGL and EGL are enabled" depends on !BR2_PACKAGE_HAS_LIBEGL || !BR2_PACKAGE_QT5_GL_AVAILABLE +comment "eglfs backend not available for X11 version of i.MX 3D libraries" + depends on BR2_PACKAGE_IMX_GPU_VIV_OUTPUT_X11 + config BR2_PACKAGE_QT5BASE_DEFAULT_QPA string "Default graphical platform" help