From patchwork Thu Jul 30 14:16:04 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Heading X-Patchwork-Id: 502171 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ozlabs.org (Postfix) with ESMTP id 67AF71402F0 for ; Fri, 31 Jul 2015 00:16:10 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=t2wYMEmp; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 053D7A47DB; Thu, 30 Jul 2015 14:16:10 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id l3nerFbTx7kl; Thu, 30 Jul 2015 14:16:08 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id E506DA47C6; Thu, 30 Jul 2015 14:16:07 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id B0A451C21D3 for ; Thu, 30 Jul 2015 14:16:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id ABEECA47C6 for ; Thu, 30 Jul 2015 14:16:07 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id a8DLHvJv84tA for ; Thu, 30 Jul 2015 14:16:06 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-vk0-f41.google.com (mail-vk0-f41.google.com [209.85.213.41]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 6D229A47D6 for ; Thu, 30 Jul 2015 14:16:05 +0000 (UTC) Received: by vkca124 with SMTP id a124so10560037vkc.1 for ; Thu, 30 Jul 2015 07:16:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=y4xsp3iiPhtN3t3D8du85E+sf91OriTAbJFD+1i1OhA=; b=t2wYMEmpLfIHIrMUk37MFSoEK3xpgj/OoPJlFloajJCKMZyNprp6qHGk6KNNLGIzVa KZ1Uq0MOakRmvieIBEmarTT7NwEXAZMEl0RKxgBKguG0NPEk+Rh746E1K7AUI5wJDspk ATEQ07OyV+8tF2s7Aob6tJL4XseBrqYfN4VMvndknnIAfgo8MjDq2okaR94XkVlVcYL3 f+qoY/n6WcLClPfeZGgMvIX5tcSmT/9AIOB7t3MbbrQBEahYVOJujR+pzQmZS2awbN7I 9wxQr+zDfTWAcEr0LGIXBjgCUJcnEvfBYKnTlgYs5AfGzplqQJpL8meAGYKsx/ZoFaBK JtzQ== MIME-Version: 1.0 X-Received: by 10.52.96.197 with SMTP id du5mr62491902vdb.10.1438265764502; Thu, 30 Jul 2015 07:16:04 -0700 (PDT) Received: by 10.31.174.68 with HTTP; Thu, 30 Jul 2015 07:16:04 -0700 (PDT) In-Reply-To: <20150729224726.71925205@free-electrons.com> References: <1438195815-29424-1-git-send-email-brendanheading@gmail.com> <20150729224726.71925205@free-electrons.com> Date: Thu, 30 Jul 2015 15:16:04 +0100 Message-ID: From: Brendan Heading To: Thomas Petazzoni Cc: buildroot@buildroot.org Subject: Re: [Buildroot] [PATCH 1/1] packages/btrfs-progs: fix build issues under musl X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" > While this is a quick hack that works, I think it's really nothing more > than a hack. I've implemented what I believe is a better solution, can > you look at: > > https://github.com/tpetazzoni/btrfs-progs/commits/configure-improvements [..] > Can you check if that continues to work fine with glibc and musl, and > if so, submit the patches upstream? Thomas, Unfortunately things moved a bit quickly - I'd submitted my patch to btrfs-progs yesterday and it was accepted earlier this morning before I had a chance to tell them about your more comprehensive approach. Your inline patch had one small typo: Also, the build still requires that limits.h is included, but that was not in the scope of what you were doing. Therefore I propose to add three patches to buildroot - your two (with the #ifndef fixed), plus one for limits.h. For the upstream, I will modify your patch slightly so that it reverts the relevant three-line part of my previous patch. OK ? regards Brendan ============================= --- a/kerncompat.h +++ b/kerncompat.h @@ -32,7 +32,7 @@ #include -#ifdef HAVE_ALWAYS_INLINE +#ifndef HAVE_ALWAYS_INLINE #define __always_inline __inline __attribute__ ((__always_inline__)) #endif =============================