diff mbox series

[2/3] system: classify init systems

Message ID 7fcc043e6719f18885f5a5d731520c76b170e73c.1725049576.git.yann.morin.1998@free.fr
State Accepted
Headers show
Series system: extend the list of init systems (branch yem/init-choice) | expand

Commit Message

Yann E. MORIN Aug. 30, 2024, 8:26 p.m. UTC
We're going to add more init systems, and some have a very special
purpose, so we do not want to mix them with the mundane platitude of
existing init systems.

Add comments to separate the two.

Note that the list would already contain comments, when a br2-external
tree provides an init system, so those new comments would not be totally
weird-looking.

Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Cc: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 system/Config.in | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Dario Binacchi Sept. 14, 2024, 9 a.m. UTC | #1
Hi Yann,

On Fri, Aug 30, 2024 at 10:26 PM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
>
> We're going to add more init systems, and some have a very special
> purpose, so we do not want to mix them with the mundane platitude of
> existing init systems.
>
> Add comments to separate the two.
>
> Note that the list would already contain comments, when a br2-external
> tree provides an init system, so those new comments would not be totally
> weird-looking.
>
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
>  system/Config.in | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/system/Config.in b/system/Config.in
> index c710b38e74..18cc39ad94 100644
> --- a/system/Config.in
> +++ b/system/Config.in
> @@ -87,6 +87,8 @@ choice
>         prompt "Init system"
>         default BR2_INIT_BUSYBOX
>
> +comment "General purpose"
> +
>  config BR2_INIT_BUSYBOX
>         bool "BusyBox"
>         select BR2_PACKAGE_BUSYBOX
> @@ -145,6 +147,8 @@ comment "systemd highly recommends Linux >= 4.15"
>         depends on BR2_INIT_SYSTEMD
>         depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_15
>
> +comment "Special purpose (read help)"
> +
>  config BR2_INIT_NONE
>         bool "Custom (none)"
>         select BR2_PACKAGE_SKELETON_INIT_NONE if BR2_ROOTFS_SKELETON_DEFAULT
> --
> 2.46.0
>

Reviewed-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>

Regards,
Dario
diff mbox series

Patch

diff --git a/system/Config.in b/system/Config.in
index c710b38e74..18cc39ad94 100644
--- a/system/Config.in
+++ b/system/Config.in
@@ -87,6 +87,8 @@  choice
 	prompt "Init system"
 	default BR2_INIT_BUSYBOX
 
+comment "General purpose"
+
 config BR2_INIT_BUSYBOX
 	bool "BusyBox"
 	select BR2_PACKAGE_BUSYBOX
@@ -145,6 +147,8 @@  comment "systemd highly recommends Linux >= 4.15"
 	depends on BR2_INIT_SYSTEMD
 	depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_15
 
+comment "Special purpose (read help)"
+
 config BR2_INIT_NONE
 	bool "Custom (none)"
 	select BR2_PACKAGE_SKELETON_INIT_NONE if BR2_ROOTFS_SKELETON_DEFAULT