diff mbox

freetype: add some dependencies

Message ID 548CD4D7.1090808@ou.edu
State Rejected
Headers show

Commit Message

Kenton, Stephen M. Dec. 14, 2014, 12:07 a.m. UTC
freetype needs fenv.h which is not available on uClibc except for x86, add dependencies

Signed-off-by Stephen M. Kenton <skenton@ou.edu>
---
Modeled on the python-numpy solution to the same fenv.h problem

Comments

Gustavo Zacarias Dec. 17, 2014, 1:07 p.m. UTC | #1
On 12/13/2014 09:07 PM, Steve Kenton wrote:

> freetype needs fenv.h which is not available on uClibc except for x86, add dependencies
> 
> Signed-off-by Stephen M. Kenton <skenton@ou.edu>

Hi.
This is wrong.
I'm using freetype with rrdtool for ARM and PowerPC targets with uClibc
just fine.
In fact any search for fenv.h in the freetype source gives nothing.
And the autobuilders would have caught this by now.
Is it possible that some other application that links to freetype is
breaking, and uses fenv itself?
Regards.
Kenton, Stephen M. Dec. 17, 2014, 3:15 p.m. UTC | #2
On 12/17/2014 7:07 AM, Gustavo Zacarias wrote:
> On 12/13/2014 09:07 PM, Steve Kenton wrote:
>
>> freetype needs fenv.h which is not available on uClibc except for x86, add dependencies
>>
>> Signed-off-by Stephen M. Kenton<skenton@ou.edu>
> Hi.
> This is wrong.
> I'm using freetype with rrdtool for ARM and PowerPC targets with uClibc
> just fine.
My apologies, you are right
> In fact any search for fenv.h in the freetype source gives nothing.
> And the autobuilders would have caught this by now.
> Is it possible that some other application that links to freetype is
> breaking, and uses fenv itself?
Yes, the problem is in the app using freetype, I misinterpreted things.
I will try again with a hopefully better patch.
> Regards.
>
diff mbox

Patch

diff -ru buildroot/package/freetype/Config.in buildroot.modified/package/freetype/Config.in
--- buildroot/package/freetype/Config.in	2014-12-13 17:45:34.547751176 -0600
+++ buildroot.modified/package/freetype/Config.in	2014-12-13 17:43:32.723748839 -0600
@@ -1,5 +1,8 @@ 
 config BR2_PACKAGE_FREETYPE
 	bool "freetype"
+	# freetype needs fenv.h. Available for all architectures in
+	# glibc, but only for x86 and x86-64 in uClibc.
+	depends on !BR2_TOOLCHAIN_USES_UCLIBC || BR2_i386 || BR2_x86_64
 	help
 	  a free, high-quality and portable font engine.