Message ID | 5183eda7f2b375c1f880c1c732f8748b8aa40d17.camel@wiedemann-group.com |
---|---|
State | Changes Requested |
Headers | show |
Series | [1/1] package/network-manager: bump version to 1.22.8 | expand |
Hello Alex, On Mon, 24 Feb 2020 13:49:53 +0000 Michel Alex <Alex.Michel@wiedemann-group.com> wrote: > From cfc2447a49b3113f9642d2e25e43b78039b6431a Mon Sep 17 00:00:00 2001 > From: Alex Michel <alex.michel@wiedemann-group.com> > Date: Mon, 24 Feb 2020 14:42:38 +0100 > Subject: [PATCH 1/1] package/network-manager: bump version to 1.22.8 There is something odd with your patch, it seems like you copy/paste the contents of the file generated by "git format-patch". Could you use "git send-email" instead to send it? Also, see one more important comment below. > # Locally computed > -sha256 49d9659a4f9a09747c320d51d3cf9dfde210de67b70862acf849890f6477b00d COPYING > -sha256 64a6d38d1b551a1bfd8509e732cdc9202d2681b61f5b39298f488674d3466fc9 CONTRIBUTING > +sha256 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643 COPYING > +sha256 f0543c137bc0eece552d42642d1bab31707ca3b3663d9c7a81ac3b270a4780e7 CONTRIBUTING When the hash of the license files are changed, we want an explanation in the commit log, to make sure the changes were checked properly. Could you diff the old and new COPYING and CONTRIBUTING files, and check what the differences are, and summarize them in the commit log ? Thanks a lot! Thomas
Thomas, please see the second version of my patch in the attachment, I'm sorry I am not allowed to use git send-email. Regards, Alex On Mon, 2020-02-24 at 22:19 +0100, Thomas Petazzoni wrote: > Hello Alex, > > On Mon, 24 Feb 2020 13:49:53 +0000 > Michel Alex <Alex.Michel@wiedemann-group.com> wrote: > > > From cfc2447a49b3113f9642d2e25e43b78039b6431a Mon Sep 17 00:00:00 > > 2001 > > From: Alex Michel <alex.michel@wiedemann-group.com> > > Date: Mon, 24 Feb 2020 14:42:38 +0100 > > Subject: [PATCH 1/1] package/network-manager: bump version to > > 1.22.8 > > There is something odd with your patch, it seems like you copy/paste > the contents of the file generated by "git format-patch". Could you > use > "git send-email" instead to send it? > > Also, see one more important comment below. > > > # Locally computed > > -sha256 > > 49d9659a4f9a09747c320d51d3cf9dfde210de67b70862acf849890f6477b00d C > > OPYING > > -sha256 > > 64a6d38d1b551a1bfd8509e732cdc9202d2681b61f5b39298f488674d3466fc9 C > > ONTRIBUTING > > +sha256 > > 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643 C > > OPYING > > +sha256 > > f0543c137bc0eece552d42642d1bab31707ca3b3663d9c7a81ac3b270a4780e7 C > > ONTRIBUTING > > When the hash of the license files are changed, we want an > explanation > in the commit log, to make sure the changes were checked properly. > > Could you diff the old and new COPYING and CONTRIBUTING files, and > check what the differences are, and summarize them in the commit log > ? > > Thanks a lot! > > Thomas
diff --git a/package/network-manager/network-manager.hash b/package/network-manager/network-manager.hash index ca8b0a2f43..74ea98a39f 100644 --- a/package/network-manager/network-manager.hash +++ b/package/network-manager/network-manager.hash @@ -1,5 +1,5 @@ # From https://download.gnome.org/sources/NetworkManager/1.20/NetworkManager-1.20.4.sha256sum -sha256 a3d738b7e702d9548b522a5781a5fb75ba69363f468c400ddd885ca65035914c NetworkManager-1.20.4.tar.xz +sha256 9511b92c72c6b5b4f063de9590ef6560696657bb6ba7d360676151742c7dab4f NetworkManager-1.22.8.tar.xz # Locally computed -sha256 49d9659a4f9a09747c320d51d3cf9dfde210de67b70862acf849890f6477b00d COPYING -sha256 64a6d38d1b551a1bfd8509e732cdc9202d2681b61f5b39298f488674d3466fc9 CONTRIBUTING +sha256 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643 COPYING +sha256 f0543c137bc0eece552d42642d1bab31707ca3b3663d9c7a81ac3b270a4780e7 CONTRIBUTING diff --git a/package/network-manager/network-manager.mk b/package/network-manager/network-manager.mk index 56b768cdef..86a04d342a 100644 --- a/package/network-manager/network-manager.mk +++ b/package/network-manager/network-manager.mk @@ -4,8 +4,8 @@ # ################################################################################ -NETWORK_MANAGER_VERSION_MAJOR = 1.20 -NETWORK_MANAGER_VERSION = $(NETWORK_MANAGER_VERSION_MAJOR).4 +NETWORK_MANAGER_VERSION_MAJOR = 1.22 +NETWORK_MANAGER_VERSION = $(NETWORK_MANAGER_VERSION_MAJOR).8 NETWORK_MANAGER_SOURCE = NetworkManager-$(NETWORK_MANAGER_VERSION).tar.xz NETWORK_MANAGER_SITE = https://download.gnome.org/sources/NetworkManager/$(NETWORK_MANAGER_VERSION_MAJOR) NETWORK_MANAGER_INSTALL_STAGING = YES