| Message ID | 20241029125847.1300382-1-dungeonlords789@naver.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/1] arch/Config.in.x86: sync prompt and help with Linux for Geode CPU | expand |
On Tue, Oct 29, 2024, 21:58 Cherniaev Andrei <dungeonlords789@naver.com> wrote: > From: AndreiCherniaev <dungeonlords789@yandex.ru> > > Linux kernel for AMD Geode CPU > https://github.com/torvalds/linux/blob/e42b1a9a2557aa94fee47f078633677198386a52/arch/x86/Kconfig.cpu#L232 > > Signed-off-by: Cherniaev Andrei < > 27889022+AndreiCherniaev@users.noreply.github.com> > --- > arch/Config.in.x86 | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/Config.in.x86 b/arch/Config.in.x86 > index f9b32130b2..4f2682eb74 100644 > --- a/arch/Config.in.x86 > +++ b/arch/Config.in.x86 > @@ -682,10 +682,12 @@ config BR2_x86_zen4 > select BR2_X86_CPU_HAS_AVX512 > select BR2_ARCH_NEEDS_GCC_AT_LEAST_13 > config BR2_x86_geode > - bool "AMD Geode" > + bool "Geode GX/LX" > I think I put the mention of AMD here to specifically avoid confusion with other Geode-like targets. https://lore.kernel.org/buildroot/20230801211759.45CA484044@busybox.osuosl.org/T/ As opposed to putting it in the help text. Im not sure what this patch is clarifying exactly. depends on !BR2_x86_64 > select BR2_X86_CPU_HAS_MMX > select BR2_X86_CPU_HAS_3DNOW > + help > + Select this for AMD Geode GX and LX processors. > config BR2_x86_c3 > bool "Via/Cyrix C3 (Samuel/Ezra cores)" > depends on !BR2_x86_64 > -- > 2.43.0 > >
I also like "AMD Geode" but I think we should sync with Linux. Because in fact you should set CPU twice, isn't it? First in buildroot config (BR2_x86_geode) and then in Linux config [CONFIG_MGEODE_LX](https://cateee.net/lkddb/web-lkddb/MGEODE_LX.html). Imagine user eyes when he met different naming... Vincent Fazio, do you plan to commit to the Linux kernel to change prompt from "Geode GX/LX" to "AMD Geode"? -----Original Message----- From: "Vincent Fazio"<vfazio@gmail.com> To: "Cherniaev Andrei"<dungeonlords789@naver.com>; Cc: <buildroot@buildroot.org>; "AndreiCherniaev"<dungeonlords789@yandex.ru>; "Cherniaev Andrei"<27889022+AndreiCherniaev@users.noreply.github.com>; Sent: 2024-10-29 (화) 22:12:48 (GMT+09:00) Subject: Re: [Buildroot] [PATCH 1/1] arch/Config.in.x86: sync prompt and help with Linux for Geode CPU On Tue, Oct 29, 2024, 21:58 Cherniaev Andrei <dungeonlords789@naver.com> wrote: From: AndreiCherniaev <dungeonlords789@yandex.ru> Linux kernel for AMD Geode CPU https://github.com/torvalds/linux/blob/e42b1a9a2557aa94fee47f078633677198386a52/arch/x86/Kconfig.cpu#L232 Signed-off-by: Cherniaev Andrei <27889022+AndreiCherniaev@users.noreply.github.com> --- arch/Config.in.x86 | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/Config.in.x86 b/arch/Config.in.x86 index f9b32130b2..4f2682eb74 100644 --- a/arch/Config.in.x86 +++ b/arch/Config.in.x86 @@ -682,10 +682,12 @@ config BR2_x86_zen4 select BR2_X86_CPU_HAS_AVX512 select BR2_ARCH_NEEDS_GCC_AT_LEAST_13 config BR2_x86_geode - bool "AMD Geode" + bool "Geode GX/LX" I think I put the mention of AMD here to specifically avoid confusion with other Geode-like targets. https://lore.kernel.org/buildroot/20230801211759.45CA484044@busybox.osuosl.org/T/ As opposed to putting it in the help text. Im not sure what this patch is clarifying exactly. depends on !BR2_x86_64 select BR2_X86_CPU_HAS_MMX select BR2_X86_CPU_HAS_3DNOW + help + Select this for AMD Geode GX and LX processors. config BR2_x86_c3 bool "Via/Cyrix C3 (Samuel/Ezra cores)" depends on !BR2_x86_64 -- 2.43.0
diff --git a/arch/Config.in.x86 b/arch/Config.in.x86 index f9b32130b2..4f2682eb74 100644 --- a/arch/Config.in.x86 +++ b/arch/Config.in.x86 @@ -682,10 +682,12 @@ config BR2_x86_zen4 select BR2_X86_CPU_HAS_AVX512 select BR2_ARCH_NEEDS_GCC_AT_LEAST_13 config BR2_x86_geode - bool "AMD Geode" + bool "Geode GX/LX" depends on !BR2_x86_64 select BR2_X86_CPU_HAS_MMX select BR2_X86_CPU_HAS_3DNOW + help + Select this for AMD Geode GX and LX processors. config BR2_x86_c3 bool "Via/Cyrix C3 (Samuel/Ezra cores)" depends on !BR2_x86_64