| Message ID | 20240911130407.2925548-1-guillaume.chaye@zeetim.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [PATCHv2,1/2] package/gdk-pixbuf: fix update cache hook | expand |
Hello Guillaume, On Wed, 11 Sep 2024 15:04:06 +0200 "Guillaume GC. Chaye" <guillaume.chaye@zeetim.com> wrote: > Move hook at the rootfs generation so all dependencies are > correctly added in loaders.cache. Thanks for the new iteration, but this commit log is unfortunately still insufficient. What is the problem? What are those "all dependencies"? How is this fixing your problem? All of that needs to be explained in your commit message so that when we go back to this in 5 years we remember the reason why we did this change. Could you submit a v3 with a much more detailed commit log? Thanks a lot! Thomas
diff --git a/package/gdk-pixbuf/gdk-pixbuf.mk b/package/gdk-pixbuf/gdk-pixbuf.mk index e041d2cbde..a8a21f0532 100644 --- a/package/gdk-pixbuf/gdk-pixbuf.mk +++ b/package/gdk-pixbuf/gdk-pixbuf.mk @@ -82,7 +82,7 @@ define GDK_PIXBUF_UPDATE_CACHE $(SED) 's,^"lib,"/usr/lib,g' \ $(TARGET_DIR)/usr/lib/gdk-pixbuf-2.0/2.10.0/loaders.cache endef -GDK_PIXBUF_POST_INSTALL_TARGET_HOOKS += GDK_PIXBUF_UPDATE_CACHE +GDK_PIXBUF_ROOTFS_PRE_CMD_HOOKS += GDK_PIXBUF_UPDATE_CACHE endif # Target gdk-pixbuf needs loaders.cache populated to build for the
Move hook at the rootfs generation so all dependencies are correctly added in loaders.cache. Signed-off-by: Guillaume GC. Chaye <guillaume.chaye@zeetim.com> --- package/gdk-pixbuf/gdk-pixbuf.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)