diff mbox series

[2/2] package/python-pydantic: bump to version 2.9.0

Message ID 20240906184756.1166732-2-james.hilliard1@gmail.com
State Accepted
Headers show
Series [1/2] package/python-tzdata: new package | expand

Commit Message

James Hilliard Sept. 6, 2024, 6:47 p.m. UTC 
Add new python-tzdata runtime dependency.

Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
 package/python-pydantic/Config.in            | 1 +
 package/python-pydantic/python-pydantic.hash | 4 ++--
 package/python-pydantic/python-pydantic.mk   | 4 ++--
 3 files changed, 5 insertions(+), 4 deletions(-)

Comments

Yann E. MORIN Sept. 7, 2024, 7:42 p.m. UTC | #1 
James, All,

On 2024-09-06 12:47 -0600, James Hilliard spake thusly:
> Add new python-tzdata runtime dependency.

This is weird that it is needed, because the dependency is written as
an optional dependency, specific to win32;

   57 [project.optional-dependencies]
   58 email = ['email-validator>=2.0.0']
   59 timezone = [
   60     # See: https://docs.python.org/3/library/zoneinfo.html#data-sources
   61     'tzdata; python_version >= "3.9" and sys_platform == "win32"',
   62 ]

So, how come it is needed on Linux?

Regards,
Yann E. MORIN.

> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>  package/python-pydantic/Config.in            | 1 +
>  package/python-pydantic/python-pydantic.hash | 4 ++--
>  package/python-pydantic/python-pydantic.mk   | 4 ++--
>  3 files changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/package/python-pydantic/Config.in b/package/python-pydantic/Config.in
> index e9cd2e6780..029f86450e 100644
> --- a/package/python-pydantic/Config.in
> +++ b/package/python-pydantic/Config.in
> @@ -4,6 +4,7 @@ config BR2_PACKAGE_PYTHON_PYDANTIC
>  	select BR2_PACKAGE_PYTHON_ANNOTATED_TYPES # runtime
>  	select BR2_PACKAGE_PYTHON_PYDANTIC_CORE # runtime
>  	select BR2_PACKAGE_PYTHON_TYPING_EXTENSIONS # runtime
> +	select BR2_PACKAGE_PYTHON_TZDATA # runtime
>  	help
>  	  Data validation and settings management using python 3.6
>  	  type hinting.
> diff --git a/package/python-pydantic/python-pydantic.hash b/package/python-pydantic/python-pydantic.hash
> index 6127dcaf37..fd8d16dbb1 100644
> --- a/package/python-pydantic/python-pydantic.hash
> +++ b/package/python-pydantic/python-pydantic.hash
> @@ -1,5 +1,5 @@
>  # md5, sha256 from https://pypi.org/pypi/pydantic/json
> -md5  940d760de174d3567d4f5be28fd215f5  pydantic-2.8.2.tar.gz
> -sha256  6f62c13d067b0755ad1c21a34bdd06c0c12625a22b0fc09c6b149816604f7c2a  pydantic-2.8.2.tar.gz
> +md5  f328e2d6c3d511a81e358aac6a8636b6  pydantic-2.9.0.tar.gz
> +sha256  c7a8a9fdf7d100afa49647eae340e2d23efa382466a8d177efcd1381e9be5598  pydantic-2.9.0.tar.gz
>  # Locally computed sha256 checksums
>  sha256  a9e186f3ca16b5eef84318e7a701721351a00cb7b8ae3a4394b67b49e3529ef3  LICENSE
> diff --git a/package/python-pydantic/python-pydantic.mk b/package/python-pydantic/python-pydantic.mk
> index c549970db9..828658af19 100644
> --- a/package/python-pydantic/python-pydantic.mk
> +++ b/package/python-pydantic/python-pydantic.mk
> @@ -4,9 +4,9 @@
>  #
>  ################################################################################
>  
> -PYTHON_PYDANTIC_VERSION = 2.8.2
> +PYTHON_PYDANTIC_VERSION = 2.9.0
>  PYTHON_PYDANTIC_SOURCE = pydantic-$(PYTHON_PYDANTIC_VERSION).tar.gz
> -PYTHON_PYDANTIC_SITE = https://files.pythonhosted.org/packages/8c/99/d0a5dca411e0a017762258013ba9905cd6e7baa9a3fd1fe8b6529472902e
> +PYTHON_PYDANTIC_SITE = https://files.pythonhosted.org/packages/f6/8f/3b9f7a38caa3fa0bcb3cea7ee9958e89a9a6efc0e6f51fd6096f24cac140
>  PYTHON_PYDANTIC_SETUP_TYPE = pep517
>  PYTHON_PYDANTIC_LICENSE = MIT
>  PYTHON_PYDANTIC_LICENSE_FILES = LICENSE
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
James Hilliard Sept. 7, 2024, 8:41 p.m. UTC | #2 
On Sat, Sep 7, 2024 at 1:42 PM Yann E. MORIN <yann.morin.1998@free.fr>
wrote:

> James, All,
>
> On 2024-09-06 12:47 -0600, James Hilliard spake thusly:
> > Add new python-tzdata runtime dependency.
>
> This is weird that it is needed, because the dependency is written as
> an optional dependency, specific to win32;
>
>    57 [project.optional-dependencies]
>    58 email = ['email-validator>=2.0.0']
>    59 timezone = [
>    60     # See:
> https://docs.python.org/3/library/zoneinfo.html#data-sources
>    61     'tzdata; python_version >= "3.9" and sys_platform == "win32"',
>    62 ]
>
> So, how come it is needed on Linux?
>

It's not listed under optional in version 2.9.0:
https://github.com/pydantic/pydantic/blob/v2.9.0/pyproject.toml#L54-L55

But it does look like it was changed in main:
https://github.com/pydantic/pydantic/pull/10331


>
> Regards,
> Yann E. MORIN.
>
> > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> > ---
> >  package/python-pydantic/Config.in            | 1 +
> >  package/python-pydantic/python-pydantic.hash | 4 ++--
> >  package/python-pydantic/python-pydantic.mk   | 4 ++--
> >  3 files changed, 5 insertions(+), 4 deletions(-)
> >
> > diff --git a/package/python-pydantic/Config.in
> b/package/python-pydantic/Config.in
> > index e9cd2e6780..029f86450e 100644
> > --- a/package/python-pydantic/Config.in
> > +++ b/package/python-pydantic/Config.in
> > @@ -4,6 +4,7 @@ config BR2_PACKAGE_PYTHON_PYDANTIC
> >       select BR2_PACKAGE_PYTHON_ANNOTATED_TYPES # runtime
> >       select BR2_PACKAGE_PYTHON_PYDANTIC_CORE # runtime
> >       select BR2_PACKAGE_PYTHON_TYPING_EXTENSIONS # runtime
> > +     select BR2_PACKAGE_PYTHON_TZDATA # runtime
> >       help
> >         Data validation and settings management using python 3.6
> >         type hinting.
> > diff --git a/package/python-pydantic/python-pydantic.hash
> b/package/python-pydantic/python-pydantic.hash
> > index 6127dcaf37..fd8d16dbb1 100644
> > --- a/package/python-pydantic/python-pydantic.hash
> > +++ b/package/python-pydantic/python-pydantic.hash
> > @@ -1,5 +1,5 @@
> >  # md5, sha256 from https://pypi.org/pypi/pydantic/json
> > -md5  940d760de174d3567d4f5be28fd215f5  pydantic-2.8.2.tar.gz
> > -sha256
> 6f62c13d067b0755ad1c21a34bdd06c0c12625a22b0fc09c6b149816604f7c2a
> pydantic-2.8.2.tar.gz
> > +md5  f328e2d6c3d511a81e358aac6a8636b6  pydantic-2.9.0.tar.gz
> > +sha256
> c7a8a9fdf7d100afa49647eae340e2d23efa382466a8d177efcd1381e9be5598
> pydantic-2.9.0.tar.gz
> >  # Locally computed sha256 checksums
> >  sha256
> a9e186f3ca16b5eef84318e7a701721351a00cb7b8ae3a4394b67b49e3529ef3  LICENSE
> > diff --git a/package/python-pydantic/python-pydantic.mk
> b/package/python-pydantic/python-pydantic.mk
> > index c549970db9..828658af19 100644
> > --- a/package/python-pydantic/python-pydantic.mk
> > +++ b/package/python-pydantic/python-pydantic.mk
> > @@ -4,9 +4,9 @@
> >  #
> >
> ################################################################################
> >
> > -PYTHON_PYDANTIC_VERSION = 2.8.2
> > +PYTHON_PYDANTIC_VERSION = 2.9.0
> >  PYTHON_PYDANTIC_SOURCE = pydantic-$(PYTHON_PYDANTIC_VERSION).tar.gz
> > -PYTHON_PYDANTIC_SITE =
> https://files.pythonhosted.org/packages/8c/99/d0a5dca411e0a017762258013ba9905cd6e7baa9a3fd1fe8b6529472902e
> > +PYTHON_PYDANTIC_SITE =
> https://files.pythonhosted.org/packages/f6/8f/3b9f7a38caa3fa0bcb3cea7ee9958e89a9a6efc0e6f51fd6096f24cac140
> >  PYTHON_PYDANTIC_SETUP_TYPE = pep517
> >  PYTHON_PYDANTIC_LICENSE = MIT
> >  PYTHON_PYDANTIC_LICENSE_FILES = LICENSE
> > --
> > 2.34.1
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
>
> --
>
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics'
> conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___
>      |
> | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is
> no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v
>  conspiracy.  |
>
> '------------------------------^-------^------------------^--------------------'
>
Yann E. MORIN Sept. 7, 2024, 8:50 p.m. UTC | #3 
James, All,

On 2024-09-07 14:41 -0600, James Hilliard spake thusly:
> On Sat, Sep 7, 2024 at 1:42 PM Yann E. MORIN <[1]yann.morin.1998@free.fr>
> wrote:
>     This is weird that it is needed, because the dependency is written as
>     an optional dependency, specific to win32;
[--SNIP--]
> It's not listed under optional in version 2.9.0:
> [3]https://github.com/pydantic/pydantic/blob/v2.9.0/pyproject.toml#L54-L55
> 
> But it does look like it was changed in main:
> [4]https://github.com/pydantic/pydantic/pull/10331

OK, right. Too bad. Can we backport this change instead, then?

Regards,
Yann E. MORIN.
James Hilliard Sept. 7, 2024, 8:52 p.m. UTC | #4 
On Sat, Sep 7, 2024 at 2:50 PM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
>
> James, All,
>
> On 2024-09-07 14:41 -0600, James Hilliard spake thusly:
> > On Sat, Sep 7, 2024 at 1:42 PM Yann E. MORIN <[1]yann.morin.1998@free.fr>
> > wrote:
> >     This is weird that it is needed, because the dependency is written as
> >     an optional dependency, specific to win32;
> [--SNIP--]
> > It's not listed under optional in version 2.9.0:
> > [3]https://github.com/pydantic/pydantic/blob/v2.9.0/pyproject.toml#L54-L55
> >
> > But it does look like it was changed in main:
> > [4]https://github.com/pydantic/pydantic/pull/10331
>
> OK, right. Too bad. Can we backport this change instead, then?

No need, we don't enforce runtime dependencies so we can drop
the dependency without a backport.

>
> Regards,
> Yann E. MORIN.
>
> --
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'
Arnout Vandecappelle Sept. 9, 2024, 6:56 p.m. UTC | #5 
On 06/09/2024 20:47, James Hilliard wrote:
> Add new python-tzdata runtime dependency.
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>   package/python-pydantic/Config.in            | 1 +
>   package/python-pydantic/python-pydantic.hash | 4 ++--
>   package/python-pydantic/python-pydantic.mk   | 4 ++--
>   3 files changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/package/python-pydantic/Config.in b/package/python-pydantic/Config.in
> index e9cd2e6780..029f86450e 100644
> --- a/package/python-pydantic/Config.in
> +++ b/package/python-pydantic/Config.in
> @@ -4,6 +4,7 @@ config BR2_PACKAGE_PYTHON_PYDANTIC
>   	select BR2_PACKAGE_PYTHON_ANNOTATED_TYPES # runtime
>   	select BR2_PACKAGE_PYTHON_PYDANTIC_CORE # runtime
>   	select BR2_PACKAGE_PYTHON_TYPING_EXTENSIONS # runtime
> +	select BR2_PACKAGE_PYTHON_TZDATA # runtime

  Applied to master after removing this line and adding an explanation in the 
commit message, thanks.

  Regards,
  Arnout

>   	help
>   	  Data validation and settings management using python 3.6
>   	  type hinting.
> diff --git a/package/python-pydantic/python-pydantic.hash b/package/python-pydantic/python-pydantic.hash
> index 6127dcaf37..fd8d16dbb1 100644
> --- a/package/python-pydantic/python-pydantic.hash
> +++ b/package/python-pydantic/python-pydantic.hash
> @@ -1,5 +1,5 @@
>   # md5, sha256 from https://pypi.org/pypi/pydantic/json
> -md5  940d760de174d3567d4f5be28fd215f5  pydantic-2.8.2.tar.gz
> -sha256  6f62c13d067b0755ad1c21a34bdd06c0c12625a22b0fc09c6b149816604f7c2a  pydantic-2.8.2.tar.gz
> +md5  f328e2d6c3d511a81e358aac6a8636b6  pydantic-2.9.0.tar.gz
> +sha256  c7a8a9fdf7d100afa49647eae340e2d23efa382466a8d177efcd1381e9be5598  pydantic-2.9.0.tar.gz
>   # Locally computed sha256 checksums
>   sha256  a9e186f3ca16b5eef84318e7a701721351a00cb7b8ae3a4394b67b49e3529ef3  LICENSE
> diff --git a/package/python-pydantic/python-pydantic.mk b/package/python-pydantic/python-pydantic.mk
> index c549970db9..828658af19 100644
> --- a/package/python-pydantic/python-pydantic.mk
> +++ b/package/python-pydantic/python-pydantic.mk
> @@ -4,9 +4,9 @@
>   #
>   ################################################################################
>   
> -PYTHON_PYDANTIC_VERSION = 2.8.2
> +PYTHON_PYDANTIC_VERSION = 2.9.0
>   PYTHON_PYDANTIC_SOURCE = pydantic-$(PYTHON_PYDANTIC_VERSION).tar.gz
> -PYTHON_PYDANTIC_SITE = https://files.pythonhosted.org/packages/8c/99/d0a5dca411e0a017762258013ba9905cd6e7baa9a3fd1fe8b6529472902e
> +PYTHON_PYDANTIC_SITE = https://files.pythonhosted.org/packages/f6/8f/3b9f7a38caa3fa0bcb3cea7ee9958e89a9a6efc0e6f51fd6096f24cac140
>   PYTHON_PYDANTIC_SETUP_TYPE = pep517
>   PYTHON_PYDANTIC_LICENSE = MIT
>   PYTHON_PYDANTIC_LICENSE_FILES = LICENSE
diff mbox series

Patch

diff --git a/package/python-pydantic/Config.in b/package/python-pydantic/Config.in
index e9cd2e6780..029f86450e 100644
--- a/package/python-pydantic/Config.in
+++ b/package/python-pydantic/Config.in
@@ -4,6 +4,7 @@  config BR2_PACKAGE_PYTHON_PYDANTIC
 	select BR2_PACKAGE_PYTHON_ANNOTATED_TYPES # runtime
 	select BR2_PACKAGE_PYTHON_PYDANTIC_CORE # runtime
 	select BR2_PACKAGE_PYTHON_TYPING_EXTENSIONS # runtime
+	select BR2_PACKAGE_PYTHON_TZDATA # runtime
 	help
 	  Data validation and settings management using python 3.6
 	  type hinting.
diff --git a/package/python-pydantic/python-pydantic.hash b/package/python-pydantic/python-pydantic.hash
index 6127dcaf37..fd8d16dbb1 100644
--- a/package/python-pydantic/python-pydantic.hash
+++ b/package/python-pydantic/python-pydantic.hash
@@ -1,5 +1,5 @@ 
 # md5, sha256 from https://pypi.org/pypi/pydantic/json
-md5  940d760de174d3567d4f5be28fd215f5  pydantic-2.8.2.tar.gz
-sha256  6f62c13d067b0755ad1c21a34bdd06c0c12625a22b0fc09c6b149816604f7c2a  pydantic-2.8.2.tar.gz
+md5  f328e2d6c3d511a81e358aac6a8636b6  pydantic-2.9.0.tar.gz
+sha256  c7a8a9fdf7d100afa49647eae340e2d23efa382466a8d177efcd1381e9be5598  pydantic-2.9.0.tar.gz
 # Locally computed sha256 checksums
 sha256  a9e186f3ca16b5eef84318e7a701721351a00cb7b8ae3a4394b67b49e3529ef3  LICENSE
diff --git a/package/python-pydantic/python-pydantic.mk b/package/python-pydantic/python-pydantic.mk
index c549970db9..828658af19 100644
--- a/package/python-pydantic/python-pydantic.mk
+++ b/package/python-pydantic/python-pydantic.mk
@@ -4,9 +4,9 @@ 
 #
 ################################################################################
 
-PYTHON_PYDANTIC_VERSION = 2.8.2
+PYTHON_PYDANTIC_VERSION = 2.9.0
 PYTHON_PYDANTIC_SOURCE = pydantic-$(PYTHON_PYDANTIC_VERSION).tar.gz
-PYTHON_PYDANTIC_SITE = https://files.pythonhosted.org/packages/8c/99/d0a5dca411e0a017762258013ba9905cd6e7baa9a3fd1fe8b6529472902e
+PYTHON_PYDANTIC_SITE = https://files.pythonhosted.org/packages/f6/8f/3b9f7a38caa3fa0bcb3cea7ee9958e89a9a6efc0e6f51fd6096f24cac140
 PYTHON_PYDANTIC_SETUP_TYPE = pep517
 PYTHON_PYDANTIC_LICENSE = MIT
 PYTHON_PYDANTIC_LICENSE_FILES = LICENSE