| Message ID | 20240905172607.1322733-1-guillaume.chaye@zeetim.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [PATCHv2,1/2] package/perl-file-slurp: add host package | expand |
Hello Guillaume, Thanks for this v2. Some minor comments below. On Thu, 5 Sep 2024 19:26:06 +0200 "Guillaume GC. Chaye" <guillaume.chaye@zeetim.com> wrote: > Some project like efitools requires host version of this package to build properly. As requested by Yann on your v1, please wrap your commit message to ~72 characters. > Signed-off-by: Guillaume GC. Chaye <guillaume.chaye@zeetim.com> > --- > package/perl-file-slurp/perl-file-slurp.mk | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/perl-file-slurp/perl-file-slurp.mk b/package/perl-file-slurp/perl-file-slurp.mk > index 0d4ab94034..910d50d3c4 100644 > --- a/package/perl-file-slurp/perl-file-slurp.mk > +++ b/package/perl-file-slurp/perl-file-slurp.mk > @@ -12,3 +12,4 @@ PERL_FILE_SLURP_LICENSE_FILES = README.md > PERL_FILE_SLURP_DISTNAME = File-Slurp > > $(eval $(perl-package)) > +$(eval $(host-perl-package)) > \ No newline at end of file Please add a newline at the end of the file, as suggested here by Git :-) Thanks a lot! Thomas
diff --git a/package/perl-file-slurp/perl-file-slurp.mk b/package/perl-file-slurp/perl-file-slurp.mk index 0d4ab94034..910d50d3c4 100644 --- a/package/perl-file-slurp/perl-file-slurp.mk +++ b/package/perl-file-slurp/perl-file-slurp.mk @@ -12,3 +12,4 @@ PERL_FILE_SLURP_LICENSE_FILES = README.md PERL_FILE_SLURP_DISTNAME = File-Slurp $(eval $(perl-package)) +$(eval $(host-perl-package)) \ No newline at end of file
Some project like efitools requires host version of this package to build properly. Signed-off-by: Guillaume GC. Chaye <guillaume.chaye@zeetim.com> --- package/perl-file-slurp/perl-file-slurp.mk | 1 + 1 file changed, 1 insertion(+)