| Message ID | 20240820085848.4242-1-vjardin@free.fr |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/1] package/lsuio: bump to 2020 version | expand |
Hello Vincent, Thanks for this update, see below some comments. On Tue, 20 Aug 2024 10:58:48 +0200 Vincent Jardin <vjardin@free.fr> wrote: > diff --git a/package/lsuio/lsuio.mk b/package/lsuio/lsuio.mk > index 193de15aef..4d5cf35bcf 100644 > --- a/package/lsuio/lsuio.mk > +++ b/package/lsuio/lsuio.mk > @@ -4,8 +4,9 @@ > # > ################################################################################ > > -LSUIO_VERSION = 0.2.0 > -LSUIO_SITE = http://www.osadl.org/projects/downloads/UIO/user > +LSUIO_VERSION = HEAD You can't use "HEAD" because this is a moving thing: if you build today and tomorrow and there's a commit made upstream, you will build something different. If there are no tags, please use a fixed commit hash. > +LSUIO_SITE = https://github.com/DigitalBrains1/lsuio.git Please use $(call github,DigitalBrains1,lsuio,$(LSUIO_VERSION)) see other packages. > +LSUIO_SITE_METHOD = git This can be dropped if you use $(call github,...). Thanks! Thomas
diff --git a/package/lsuio/lsuio.hash b/package/lsuio/lsuio.hash index 2df6d074f4..fc897ba49e 100644 --- a/package/lsuio/lsuio.hash +++ b/package/lsuio/lsuio.hash @@ -1,3 +1,4 @@ # Locally calculated sha256 c88b3850248b2d3419e025abd7b9b0991c8bd33a2d4983f9608408a29900bfb5 lsuio-0.2.0.tar.gz sha256 32b1062f7da84967e7019d01ab805935caa7ab7321a7ced0e30ebe75e5df1670 COPYING +sha256 5520415d6e6e37cf70acefd73743915b2a9bb1e1026f61c132a89b41db861d21 lsuio-HEAD-git4.tar.gz diff --git a/package/lsuio/lsuio.mk b/package/lsuio/lsuio.mk index 193de15aef..4d5cf35bcf 100644 --- a/package/lsuio/lsuio.mk +++ b/package/lsuio/lsuio.mk @@ -4,8 +4,9 @@ # ################################################################################ -LSUIO_VERSION = 0.2.0 -LSUIO_SITE = http://www.osadl.org/projects/downloads/UIO/user +LSUIO_VERSION = HEAD +LSUIO_SITE = https://github.com/DigitalBrains1/lsuio.git +LSUIO_SITE_METHOD = git LSUIO_LICENSE = GPL-2.0 LSUIO_LICENSE_FILES = COPYING
The new version from peter@digitalbrains.com adds some few new features (name, offset, etc.) and it includes some few improvements. The former version was more than 14y old. There is no tag, neither any archive, so currently I assume that HEAD can be used. Signed-off-by: Vincent Jardin <vjardin@free.fr> --- package/lsuio/lsuio.hash | 1 + package/lsuio/lsuio.mk | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-)