diff mbox series

package/python-tpm2-pytss: add missing 'depends on'

Message ID 20240815202356.535066-1-thomas.petazzoni@bootlin.com
State Accepted
Headers show
Series package/python-tpm2-pytss: add missing 'depends on' | expand

Commit Message

Thomas Petazzoni Aug. 15, 2024, 8:23 p.m. UTC
In commit
c72c6f26ed706474f6607f97be2925834c8baa03 ("package/python-tpm2-pytss:
new package"), when the package was introduced, a dependency of a
package being selected was not properly propagated:
BR2_PACKAGE_PYTHON_CRYPTOGRAPHY depends on
BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS, so we should replicate
this dependency.

Fixes:

WARNING: unmet direct dependencies detected for BR2_PACKAGE_PYTHON_CRYPTOGRAPHY
  Depends on [n]: BR2_PACKAGE_PYTHON3 [=y] && BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS [=n]
  Selected by [y]:
  - BR2_PACKAGE_PYTHON_TPM2_PYTSS [=y] && BR2_PACKAGE_PYTHON3 [=y] && !BR2_STATIC_LIBS [=n]

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 package/python-tpm2-pytss/Config.in | 2 ++
 1 file changed, 2 insertions(+)

Comments

Yann E. MORIN Aug. 15, 2024, 8:37 p.m. UTC | #1
Thomas, All,

On 2024-08-15 22:23 +0200, Thomas Petazzoni via buildroot spake thusly:
> In commit
> c72c6f26ed706474f6607f97be2925834c8baa03 ("package/python-tpm2-pytss:
> new package"), when the package was introduced, a dependency of a
> package being selected was not properly propagated:
> BR2_PACKAGE_PYTHON_CRYPTOGRAPHY depends on
> BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS, so we should replicate
> this dependency.
> 
> Fixes:
> 
> WARNING: unmet direct dependencies detected for BR2_PACKAGE_PYTHON_CRYPTOGRAPHY
>   Depends on [n]: BR2_PACKAGE_PYTHON3 [=y] && BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS [=n]
>   Selected by [y]:
>   - BR2_PACKAGE_PYTHON_TPM2_PYTSS [=y] && BR2_PACKAGE_PYTHON3 [=y] && !BR2_STATIC_LIBS [=n]
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/python-tpm2-pytss/Config.in | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/package/python-tpm2-pytss/Config.in b/package/python-tpm2-pytss/Config.in
> index 60d9e8b9d3..dec9a311d4 100644
> --- a/package/python-tpm2-pytss/Config.in
> +++ b/package/python-tpm2-pytss/Config.in
> @@ -1,6 +1,7 @@
>  config BR2_PACKAGE_PYTHON_TPM2_PYTSS
>  	bool "python-tpm2-pytss"
>  	depends on !BR2_STATIC_LIBS # tpm2-tss
> +	depends on BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS # python-cryptography
>  	select BR2_PACKAGE_PYTHON_ASN1CRYPTO # runtime
>  	select BR2_PACKAGE_PYTHON_CFFI # runtime
>  	select BR2_PACKAGE_PYTHON_CRYPTOGRAPHY # runtime
> @@ -11,4 +12,5 @@ config BR2_PACKAGE_PYTHON_TPM2_PYTSS
>  	  https://github.com/tpm2-software/tpm2-pytss
>  
>  comment "python-tpm2-pytss needs a toolchain w/ dynamic library"
> +	depends on BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS
>  	depends on BR2_STATIC_LIBS
> -- 
> 2.46.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
diff mbox series

Patch

diff --git a/package/python-tpm2-pytss/Config.in b/package/python-tpm2-pytss/Config.in
index 60d9e8b9d3..dec9a311d4 100644
--- a/package/python-tpm2-pytss/Config.in
+++ b/package/python-tpm2-pytss/Config.in
@@ -1,6 +1,7 @@ 
 config BR2_PACKAGE_PYTHON_TPM2_PYTSS
 	bool "python-tpm2-pytss"
 	depends on !BR2_STATIC_LIBS # tpm2-tss
+	depends on BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS # python-cryptography
 	select BR2_PACKAGE_PYTHON_ASN1CRYPTO # runtime
 	select BR2_PACKAGE_PYTHON_CFFI # runtime
 	select BR2_PACKAGE_PYTHON_CRYPTOGRAPHY # runtime
@@ -11,4 +12,5 @@  config BR2_PACKAGE_PYTHON_TPM2_PYTSS
 	  https://github.com/tpm2-software/tpm2-pytss
 
 comment "python-tpm2-pytss needs a toolchain w/ dynamic library"
+	depends on BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS
 	depends on BR2_STATIC_LIBS