diff mbox series

[1/1] support/testing: package: gpsd: fix test by enabling python support

Message ID 20240806212850.467698-1-ju.o@free.fr
State Accepted
Headers show
Series [1/1] support/testing: package: gpsd: fix test by enabling python support | expand

Commit Message

Julien Olivain Aug. 6, 2024, 9:28 p.m. UTC
Commit 9696d27756 "package/gpsd: condition python stuff to the proper
kconfig option" changed the condition in which the gpsd python scripts
are installed. After that change, the "gpsfake" command (which is a
python script) is no longer found and the runtime test is failing.

This commit fixes the issue by reflecting the change in the runtime
test Buildroot configuration.

Signed-off-by: Julien Olivain <ju.o@free.fr>
---
Patch testing in:
https://gitlab.com/jolivain/buildroot/-/jobs/7520716177
---
 support/testing/tests/package/test_gpsd.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Petazzoni Aug. 7, 2024, 10:04 a.m. UTC | #1
On Tue,  6 Aug 2024 23:28:50 +0200
Julien Olivain <ju.o@free.fr> wrote:

> Commit 9696d27756 "package/gpsd: condition python stuff to the proper
> kconfig option" changed the condition in which the gpsd python scripts
> are installed. After that change, the "gpsfake" command (which is a
> python script) is no longer found and the runtime test is failing.
> 
> This commit fixes the issue by reflecting the change in the runtime
> test Buildroot configuration.
> 
> Signed-off-by: Julien Olivain <ju.o@free.fr>
> ---
> Patch testing in:
> https://gitlab.com/jolivain/buildroot/-/jobs/7520716177
> ---
>  support/testing/tests/package/test_gpsd.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks.

Thomas
Peter Korsgaard Sept. 3, 2024, 7:30 p.m. UTC | #2
>>>>> "Julien" == Julien Olivain <ju.o@free.fr> writes:

 > Commit 9696d27756 "package/gpsd: condition python stuff to the proper
 > kconfig option" changed the condition in which the gpsd python scripts
 > are installed. After that change, the "gpsfake" command (which is a
 > python script) is no longer found and the runtime test is failing.

 > This commit fixes the issue by reflecting the change in the runtime
 > test Buildroot configuration.

 > Signed-off-by: Julien Olivain <ju.o@free.fr>
 > ---
 > Patch testing in:
 > https://gitlab.com/jolivain/buildroot/-/jobs/7520716177

Committed to 2024.02.x and 2024.05.x, thanks.
diff mbox series

Patch

diff --git a/support/testing/tests/package/test_gpsd.py b/support/testing/tests/package/test_gpsd.py
index 7ca5973981..2c44e25cec 100644
--- a/support/testing/tests/package/test_gpsd.py
+++ b/support/testing/tests/package/test_gpsd.py
@@ -11,7 +11,7 @@  class TestGpsd(infra.basetest.BRTest):
     config = infra.basetest.BASIC_TOOLCHAIN_CONFIG + \
         f"""
         BR2_PACKAGE_GPSD=y
-        BR2_PACKAGE_PYTHON3=y
+        BR2_PACKAGE_GPSD_PYTHON=y
         BR2_ROOTFS_OVERLAY="{rootfs_overlay}"
         BR2_TARGET_ROOTFS_CPIO=y
         # BR2_TARGET_ROOTFS_TAR is not set