| Message ID | 20240726153002.18133-1-fontaine.fabrice@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/1] package/gtkiostream: add BR2_PACKAGE_GTKIOSTREAM_ARCH_SUPPORTS | expand |
On Fri, 26 Jul 2024 17:30:02 +0200 Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote: > diff --git a/package/gtkiostream/Config.in b/package/gtkiostream/Config.in > index 1d1ec27346..0567ce876d 100644 > --- a/package/gtkiostream/Config.in > +++ b/package/gtkiostream/Config.in > @@ -1,5 +1,20 @@ > +config BR2_PACKAGE_GTKIOSTREAM_ARCH_SUPPORTS > + bool > + default y if BR2_arcle > + default y if BR2_aarch64 > + default y if BR2_arm > + default y if BR2_i386 || BR2_x86_64 > + default y if BR2_microblazeel > + default y if BR2_mipsel || BR2_mips64el > + default y if BR2_nios2 > + default y if BR2_powerpc64le > + default y if BR2_riscv > + default y if BR2_sh4 || BR2_sh4a > + default y if BR2_xtensa Thanks for looking into this! Did you try: config BR2_PACKAGE_GTKIOSTREAM_ARCH_SUPPORTS bool default y if BR2_ENDIAN = "LITTLE" ? It seems a bit more concise and future proof. Thanks! Thomas
diff --git a/package/gtkiostream/Config.in b/package/gtkiostream/Config.in index 1d1ec27346..0567ce876d 100644 --- a/package/gtkiostream/Config.in +++ b/package/gtkiostream/Config.in @@ -1,5 +1,20 @@ +config BR2_PACKAGE_GTKIOSTREAM_ARCH_SUPPORTS + bool + default y if BR2_arcle + default y if BR2_aarch64 + default y if BR2_arm + default y if BR2_i386 || BR2_x86_64 + default y if BR2_microblazeel + default y if BR2_mipsel || BR2_mips64el + default y if BR2_nios2 + default y if BR2_powerpc64le + default y if BR2_riscv + default y if BR2_sh4 || BR2_sh4a + default y if BR2_xtensa + config BR2_PACKAGE_GTKIOSTREAM bool "gtkiostream" + depends on BR2_PACKAGE_GTKIOSTREAM_ARCH_SUPPORTS depends on BR2_INSTALL_LIBSTDCPP # eigen depends on BR2_TOOLCHAIN_HAS_THREADS select BR2_PACKAGE_ALSA_LIB_MIXER if BR2_PACKAGE_ALSA_LIB @@ -14,5 +29,6 @@ config BR2_PACKAGE_GTKIOSTREAM https://github.com/flatmax/gtkiostream comment "gtkiostream needs a toolchain w/ C++, threads" + depends on BR2_PACKAGE_GTKIOSTREAM_ARCH_SUPPORTS depends on !BR2_INSTALL_LIBSTDCPP || \ !BR2_TOOLCHAIN_HAS_THREADS
gtkiostream only supports little-endian since its addition in commit fab48302865e5c0c98d91b696bc90e75e38189bb resulting in the following build failure: In file included from BitStream.C:23: ../include/BitStream.H:35:2: error: #error "iobitstream not tested on big endian systems" 35 | #error "iobitstream not tested on big endian systems" | ^~~~~ Fixes: fab48302865e5c0c98d91b696bc90e75e38189bb - http://autobuild.buildroot.org/results/aec24d92cc2196596413cf509d686f1f8d1eca95 Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> --- package/gtkiostream/Config.in | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)