diff mbox series

[1/1] package/mokutil: force libopenssl

Message ID 20240725073908.598145-1-fontaine.fabrice@gmail.com
State Accepted
Headers show
Series [1/1] package/mokutil: force libopenssl | expand

Commit Message

Fabrice Fontaine July 25, 2024, 7:39 a.m. UTC
mokutil unconditionally uses X509_get0_subject_key_id resulting in the
following build failure with libressl since its addition in commit
2e6e121496bfcbe09c018558be13733077b6df9b:

/home/autobuild/autobuild/instance-18/output-1/host/lib/gcc/i686-buildroot-linux-uclibc/13.3.0/../../../../i686-buildroot-linux-uclibc/bin/ld: mokutil-efi_x509.o: in function `get_cert_skid':
efi_x509.c:(.text+0x4e6): undefined reference to `X509_get0_subject_key_id'

Fixes: 2e6e121496bfcbe09c018558be13733077b6df9b
 - http://autobuild.buildroot.org/results/88b549734eae4b25de1b8e1c4f04bace0a7e7418
 - http://autobuild.buildroot.org/results/05ac319bfb2a252f3dcdc5d04761f276afb53b6f

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/mokutil/Config.in | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Petazzoni Aug. 2, 2024, 9:41 p.m. UTC | #1
On Thu, 25 Jul 2024 09:39:08 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> mokutil unconditionally uses X509_get0_subject_key_id resulting in the
> following build failure with libressl since its addition in commit
> 2e6e121496bfcbe09c018558be13733077b6df9b:
> 
> /home/autobuild/autobuild/instance-18/output-1/host/lib/gcc/i686-buildroot-linux-uclibc/13.3.0/../../../../i686-buildroot-linux-uclibc/bin/ld: mokutil-efi_x509.o: in function `get_cert_skid':
> efi_x509.c:(.text+0x4e6): undefined reference to `X509_get0_subject_key_id'
> 
> Fixes: 2e6e121496bfcbe09c018558be13733077b6df9b
>  - http://autobuild.buildroot.org/results/88b549734eae4b25de1b8e1c4f04bace0a7e7418
>  - http://autobuild.buildroot.org/results/05ac319bfb2a252f3dcdc5d04761f276afb53b6f
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/mokutil/Config.in | 1 +
>  1 file changed, 1 insertion(+)

Applied to master, thanks.

Thomas
Peter Korsgaard Sept. 3, 2024, 6:04 p.m. UTC | #2
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > mokutil unconditionally uses X509_get0_subject_key_id resulting in the
 > following build failure with libressl since its addition in commit
 > 2e6e121496bfcbe09c018558be13733077b6df9b:

 > /home/autobuild/autobuild/instance-18/output-1/host/lib/gcc/i686-buildroot-linux-uclibc/13.3.0/../../../../i686-buildroot-linux-uclibc/bin/ld:
 > mokutil-efi_x509.o: in function `get_cert_skid':
 > efi_x509.c:(.text+0x4e6): undefined reference to `X509_get0_subject_key_id'

 > Fixes: 2e6e121496bfcbe09c018558be13733077b6df9b
 >  - http://autobuild.buildroot.org/results/88b549734eae4b25de1b8e1c4f04bace0a7e7418
 >  - http://autobuild.buildroot.org/results/05ac319bfb2a252f3dcdc5d04761f276afb53b6f

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2024.05.x, thanks.
diff mbox series

Patch

diff --git a/package/mokutil/Config.in b/package/mokutil/Config.in
index dd02078b4e..8895b66d20 100644
--- a/package/mokutil/Config.in
+++ b/package/mokutil/Config.in
@@ -14,6 +14,7 @@  config BR2_PACKAGE_MOKUTIL
 	select BR2_PACKAGE_KEYUTILS
 	select BR2_PACKAGE_LIBXCRYPT if BR2_TOOLCHAIN_USES_GLIBC
 	select BR2_PACKAGE_OPENSSL
+	select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL
 	help
 	  mokutil is a tool to import or delete the machines owner
 	  keys (MOK) stored in the database of shim.