diff mbox series

[1/1] support/testing: package: gpsd: fix gpsfake command line

Message ID 20240722223923.278333-1-ju.o@free.fr
State Accepted
Headers show
Series [1/1] support/testing: package: gpsd: fix gpsfake command line | expand

Commit Message

Julien Olivain July 22, 2024, 10:39 p.m. UTC 
The gpsfake command line has a typo (a missing space), which makes the
next gpsctl command to always fail.

This commit fixes the issue by adding the missing space.

Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/7391792948

Signed-off-by: Julien Olivain <ju.o@free.fr>
---
 support/testing/tests/package/test_gpsd.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Petazzoni July 23, 2024, 8:50 a.m. UTC | #1 
On Tue, 23 Jul 2024 00:39:22 +0200
Julien Olivain <ju.o@free.fr> wrote:

> The gpsfake command line has a typo (a missing space), which makes the
> next gpsctl command to always fail.
> 
> This commit fixes the issue by adding the missing space.
> 
> Fixes:
> https://gitlab.com/buildroot.org/buildroot/-/jobs/7391792948
> 
> Signed-off-by: Julien Olivain <ju.o@free.fr>
> ---
>  support/testing/tests/package/test_gpsd.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Ah, I had missed this during the review, it was not easy to spot.
Thanks for fixing quickly!

Applied!

Best regards,

Thomas
Peter Korsgaard Aug. 29, 2024, 1:38 p.m. UTC | #2 
>>>>> "Julien" == Julien Olivain <ju.o@free.fr> writes:

 > The gpsfake command line has a typo (a missing space), which makes the
 > next gpsctl command to always fail.

 > This commit fixes the issue by adding the missing space.

 > Fixes:
 > https://gitlab.com/buildroot.org/buildroot/-/jobs/7391792948

 > Signed-off-by: Julien Olivain <ju.o@free.fr>

Committed to 2024.02.x and 2024.05.x, thanks.
diff mbox series

Patch

diff --git a/support/testing/tests/package/test_gpsd.py b/support/testing/tests/package/test_gpsd.py
index deed586c17..7ca5973981 100644
--- a/support/testing/tests/package/test_gpsd.py
+++ b/support/testing/tests/package/test_gpsd.py
@@ -33,7 +33,7 @@  class TestGpsd(infra.basetest.BRTest):
         # We start the "gpsfake" GPS emulator instead.
         cmd = "gpsfake"
         cmd += " --slow --cycle 0.1 --quiet"
-        cmd += "/root/udp-nmea.log &> /dev/null &"
+        cmd += " /root/udp-nmea.log &> /dev/null &"
         self.assertRunOk(cmd)
 
         # Wait a bit, to let the gpsfake and gpsd to settle...