| Message ID | 20240722-tfa-src-update-v1-1-e68bba62f146@ti.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | boot/arm-trusted-firmware: version bump and source update | expand |
Hello Bryan, On Mon, 22 Jul 2024 14:17:37 -0500 Bryan Brattlof via buildroot <buildroot@buildroot.org> wrote: > Tags are no longer being pused to the old ARM-softwre > mirror. Let's move to the new mirror at TrustedFirmware-A which > continues to publish newer tags > > Signed-off-by: Bryan Brattlof <bb@ti.com> > --- > .../fvp-ebbr/patches/arm-trusted-firmware/arm-trusted-firmware.hash | 2 +- > .../patches/arm-trusted-firmware/arm-trusted-firmware.hash | 2 +- > .../beagleplay/patches/arm-trusted-firmware/arm-trusted-firmware.hash | 2 +- > .../patches/arm-trusted-firmware/arm-trusted-firmware.hash | 2 +- > .../patches/arm-trusted-firmware/arm-trusted-firmware.hash | 2 +- > board/qemu/patches/arm-trusted-firmware/arm-trusted-firmware.hash | 2 +- > .../stm32mp157/patches/arm-trusted-firmware/arm-trusted-firmware.hash | 2 +- > .../am62ax-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash | 2 +- > .../am62x-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash | 2 +- > .../am64x-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash | 2 +- > boot/arm-trusted-firmware/arm-trusted-firmware.hash | 4 ++-- > boot/arm-trusted-firmware/arm-trusted-firmware.mk | 2 +- > 12 files changed, 13 insertions(+), 13 deletions(-) I have applied locally, but not yet pushed. My concern is that it's really annoying that it breaks hashes for all previous versions of TF-A. This means that all people having existing defconfigs (not the one in Buildroot) that use BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_VERSION_VALUE will see their build fail now. And even for those using the defconfigs in Buildroot, they will see a hash mismatch message and a redownload. But I don't really see any other way around that. The issue is basically that we are not fetching real tarballs, but auto-generated ones, which are different when fetched from one repo or another. Should we instead switch to fetching via Git all the time? Should we switch to using the official Git repo, instead of a Github mirror? As you can see, I am not 100% sure about this change, even though we obviously need to change something to be able to use the newer versions of TF-A... Best regards, Thomas
Hi Thomas On August 3, 2024 thus sayeth Thomas Petazzoni: > Hello Bryan, > > On Mon, 22 Jul 2024 14:17:37 -0500 > Bryan Brattlof via buildroot <buildroot@buildroot.org> wrote: > > > Tags are no longer being pused to the old ARM-softwre > > mirror. Let's move to the new mirror at TrustedFirmware-A which > > continues to publish newer tags > > > > Signed-off-by: Bryan Brattlof <bb@ti.com> > > --- > > .../fvp-ebbr/patches/arm-trusted-firmware/arm-trusted-firmware.hash | 2 +- > > .../patches/arm-trusted-firmware/arm-trusted-firmware.hash | 2 +- > > .../beagleplay/patches/arm-trusted-firmware/arm-trusted-firmware.hash | 2 +- > > .../patches/arm-trusted-firmware/arm-trusted-firmware.hash | 2 +- > > .../patches/arm-trusted-firmware/arm-trusted-firmware.hash | 2 +- > > board/qemu/patches/arm-trusted-firmware/arm-trusted-firmware.hash | 2 +- > > .../stm32mp157/patches/arm-trusted-firmware/arm-trusted-firmware.hash | 2 +- > > .../am62ax-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash > > | 2 +- > > .../am62x-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash | 2 +- > > .../am64x-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash | 2 +- > > boot/arm-trusted-firmware/arm-trusted-firmware.hash | 4 ++-- > > boot/arm-trusted-firmware/arm-trusted-firmware.mk | 2 +- > > 12 files changed, 13 insertions(+), 13 deletions(-) > > I have applied locally, but not yet pushed. My concern is that it's > really annoying that it breaks hashes for all previous versions of > TF-A. This means that all people having existing defconfigs (not the > one in Buildroot) that use > BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_VERSION_VALUE will see their > build fail now. And even for those using the defconfigs in Buildroot, > they will see a hash mismatch message and a redownload. > > But I don't really see any other way around that. The issue is > basically that we are not fetching real tarballs, but auto-generated > ones, which are different when fetched from one repo or another. > > Should we instead switch to fetching via Git all the time? Should we > switch to using the official Git repo, instead of a Github mirror? > > As you can see, I am not 100% sure about this change, even though we > obviously need to change something to be able to use the newer versions > of TF-A... > Ah I agree completely. I saw we originally used the mirror and assumed we did that for bandwidth reasons. I can update this to use the trustedfirmware.org source. Thanks for the review ~Bryan
diff --git a/board/arm/fvp-ebbr/patches/arm-trusted-firmware/arm-trusted-firmware.hash b/board/arm/fvp-ebbr/patches/arm-trusted-firmware/arm-trusted-firmware.hash index 02714d06a09c0..c056d6ad0ddc8 100644 --- a/board/arm/fvp-ebbr/patches/arm-trusted-firmware/arm-trusted-firmware.hash +++ b/board/arm/fvp-ebbr/patches/arm-trusted-firmware/arm-trusted-firmware.hash @@ -1,2 +1,2 @@ # Locally calculated -sha256 2e18b881ada9198173238cca80086c787b1fa3f698944bde1743142823fc511c arm-trusted-firmware-v2.10.tar.gz +sha256 88215a62291b9ba87da8e50b077741103cdc08fb6c9e1ebd34dfaace746d3201 arm-trusted-firmware-v2.10.tar.gz diff --git a/board/beagleboard/beagleboneai64/patches/arm-trusted-firmware/arm-trusted-firmware.hash b/board/beagleboard/beagleboneai64/patches/arm-trusted-firmware/arm-trusted-firmware.hash index 02714d06a09c0..c056d6ad0ddc8 100644 --- a/board/beagleboard/beagleboneai64/patches/arm-trusted-firmware/arm-trusted-firmware.hash +++ b/board/beagleboard/beagleboneai64/patches/arm-trusted-firmware/arm-trusted-firmware.hash @@ -1,2 +1,2 @@ # Locally calculated -sha256 2e18b881ada9198173238cca80086c787b1fa3f698944bde1743142823fc511c arm-trusted-firmware-v2.10.tar.gz +sha256 88215a62291b9ba87da8e50b077741103cdc08fb6c9e1ebd34dfaace746d3201 arm-trusted-firmware-v2.10.tar.gz diff --git a/board/beagleboard/beagleplay/patches/arm-trusted-firmware/arm-trusted-firmware.hash b/board/beagleboard/beagleplay/patches/arm-trusted-firmware/arm-trusted-firmware.hash index 02714d06a09c0..c056d6ad0ddc8 100644 --- a/board/beagleboard/beagleplay/patches/arm-trusted-firmware/arm-trusted-firmware.hash +++ b/board/beagleboard/beagleplay/patches/arm-trusted-firmware/arm-trusted-firmware.hash @@ -1,2 +1,2 @@ # Locally calculated -sha256 2e18b881ada9198173238cca80086c787b1fa3f698944bde1743142823fc511c arm-trusted-firmware-v2.10.tar.gz +sha256 88215a62291b9ba87da8e50b077741103cdc08fb6c9e1ebd34dfaace746d3201 arm-trusted-firmware-v2.10.tar.gz diff --git a/board/bsh/common/imx8mn-bsh-smm-s2/patches/arm-trusted-firmware/arm-trusted-firmware.hash b/board/bsh/common/imx8mn-bsh-smm-s2/patches/arm-trusted-firmware/arm-trusted-firmware.hash index 80e592dab6065..6dcfb66431f22 100644 --- a/board/bsh/common/imx8mn-bsh-smm-s2/patches/arm-trusted-firmware/arm-trusted-firmware.hash +++ b/board/bsh/common/imx8mn-bsh-smm-s2/patches/arm-trusted-firmware/arm-trusted-firmware.hash @@ -1,2 +1,2 @@ # Locally calculated -sha256 fc4cdac7c08fc398b6d4b705285dc13ac2d2b30a7449c6f07e9ccd81207241df arm-trusted-firmware-v2.5.tar.gz +sha256 ad8a2ffcbcd12d919723da07630fc0840c3c2fba7656d1462e45488e42995d7c arm-trusted-firmware-v2.5.tar.gz diff --git a/board/orangepi/orangepi-zero2w/patches/arm-trusted-firmware/arm-trusted-firmware.hash b/board/orangepi/orangepi-zero2w/patches/arm-trusted-firmware/arm-trusted-firmware.hash index c9d043c46f129..2f00eec47ccd3 100644 --- a/board/orangepi/orangepi-zero2w/patches/arm-trusted-firmware/arm-trusted-firmware.hash +++ b/board/orangepi/orangepi-zero2w/patches/arm-trusted-firmware/arm-trusted-firmware.hash @@ -1,2 +1,2 @@ # Locally computed: -sha256 2e18b881ada9198173238cca80086c787b1fa3f698944bde1743142823fc511c arm-trusted-firmware-v2.10.tar.gz +sha256 88215a62291b9ba87da8e50b077741103cdc08fb6c9e1ebd34dfaace746d3201 arm-trusted-firmware-v2.10.tar.gz diff --git a/board/qemu/patches/arm-trusted-firmware/arm-trusted-firmware.hash b/board/qemu/patches/arm-trusted-firmware/arm-trusted-firmware.hash index 74fe35c9bc733..5f8b9fa4419cd 100644 --- a/board/qemu/patches/arm-trusted-firmware/arm-trusted-firmware.hash +++ b/board/qemu/patches/arm-trusted-firmware/arm-trusted-firmware.hash @@ -1,2 +1,2 @@ # Locally computed: -sha256 327c65b1bc231608a7a808b068b00c1a22310e9fc86158813cd10a9711d5725e arm-trusted-firmware-v2.7.tar.gz +sha256 53422dc649153838e03820330ba17cb10afe3e330ecde0db11e4d5f1361a33e6 arm-trusted-firmware-v2.7.tar.gz diff --git a/board/stmicroelectronics/common/stm32mp157/patches/arm-trusted-firmware/arm-trusted-firmware.hash b/board/stmicroelectronics/common/stm32mp157/patches/arm-trusted-firmware/arm-trusted-firmware.hash index 8b69a5a96453b..5a4e619135aa2 100644 --- a/board/stmicroelectronics/common/stm32mp157/patches/arm-trusted-firmware/arm-trusted-firmware.hash +++ b/board/stmicroelectronics/common/stm32mp157/patches/arm-trusted-firmware/arm-trusted-firmware.hash @@ -1,2 +1,2 @@ # Locally calculated -sha256 06d32acf42808b682859008292f0591d2d872f19aa1a8021bfcd1c1c626285e6 arm-trusted-firmware-v2.9.tar.gz +sha256 76a66a1de0c01aeb83dfc7b72b51173fe62c6e51d6fca17cc562393117bed08b arm-trusted-firmware-v2.9.tar.gz diff --git a/board/ti/am62ax-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash b/board/ti/am62ax-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash index 8f60864fbf67f..ded5f952cd3d7 100644 --- a/board/ti/am62ax-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash +++ b/board/ti/am62ax-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash @@ -1,2 +1,2 @@ # Locally computed: -sha256 ba215404fe9db26e5f2cef3fdce17b7c8ed344a2a1d592dd01a5f1c5e72cfdbd arm-trusted-firmware-lts-v2.10.4.tar.gz +sha256 05f08e6728474e7af3cca3c0d6f6d065e5b2622aabaca942d57377a46d4ae0ab arm-trusted-firmware-lts-v2.10.4.tar.gz diff --git a/board/ti/am62x-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash b/board/ti/am62x-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash index 7494e04ead5d0..b7927be6e85b9 100644 --- a/board/ti/am62x-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash +++ b/board/ti/am62x-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash @@ -1,2 +1,2 @@ # Locally calculated -sha256 ba215404fe9db26e5f2cef3fdce17b7c8ed344a2a1d592dd01a5f1c5e72cfdbd arm-trusted-firmware-lts-v2.10.4.tar.gz +sha256 05f08e6728474e7af3cca3c0d6f6d065e5b2622aabaca942d57377a46d4ae0ab arm-trusted-firmware-lts-v2.10.4.tar.gz diff --git a/board/ti/am64x-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash b/board/ti/am64x-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash index 7494e04ead5d0..b7927be6e85b9 100644 --- a/board/ti/am64x-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash +++ b/board/ti/am64x-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash @@ -1,2 +1,2 @@ # Locally calculated -sha256 ba215404fe9db26e5f2cef3fdce17b7c8ed344a2a1d592dd01a5f1c5e72cfdbd arm-trusted-firmware-lts-v2.10.4.tar.gz +sha256 05f08e6728474e7af3cca3c0d6f6d065e5b2622aabaca942d57377a46d4ae0ab arm-trusted-firmware-lts-v2.10.4.tar.gz diff --git a/boot/arm-trusted-firmware/arm-trusted-firmware.hash b/boot/arm-trusted-firmware/arm-trusted-firmware.hash index 73ab431b9fc97..2c541674bf54b 100644 --- a/boot/arm-trusted-firmware/arm-trusted-firmware.hash +++ b/boot/arm-trusted-firmware/arm-trusted-firmware.hash @@ -1,4 +1,4 @@ # Locally calculated -sha256 2e18b881ada9198173238cca80086c787b1fa3f698944bde1743142823fc511c arm-trusted-firmware-v2.10.tar.gz -sha256 e55ae7105c996b60f748b2eb6adeaf5ac8946425e1d4294ecc1c56aebf435274 arm-trusted-firmware-lts-v2.8.13.tar.gz +sha256 88215a62291b9ba87da8e50b077741103cdc08fb6c9e1ebd34dfaace746d3201 arm-trusted-firmware-v2.10.tar.gz +sha256 24b530f15cd714fa82cd8b80fbde0c18b8b8ea33778104532185ad67cb364bf9 arm-trusted-firmware-lts-v2.8.13.tar.gz sha256 130d0c6e5159fa454b1e969fd281fa1d388819aefb203f65dd282544b5ab7ba9 docs/license.rst diff --git a/boot/arm-trusted-firmware/arm-trusted-firmware.mk b/boot/arm-trusted-firmware/arm-trusted-firmware.mk index abf917948eeee..d13998ce091c2 100644 --- a/boot/arm-trusted-firmware/arm-trusted-firmware.mk +++ b/boot/arm-trusted-firmware/arm-trusted-firmware.mk @@ -16,7 +16,7 @@ ARM_TRUSTED_FIRMWARE_SITE = $(call qstrip,$(BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUST ARM_TRUSTED_FIRMWARE_SITE_METHOD = git else # Handle stable official ATF versions -ARM_TRUSTED_FIRMWARE_SITE = $(call github,ARM-software,arm-trusted-firmware,$(ARM_TRUSTED_FIRMWARE_VERSION)) +ARM_TRUSTED_FIRMWARE_SITE = $(call github,TrustedFirmware-A,trusted-firmware-a,$(ARM_TRUSTED_FIRMWARE_VERSION)) # The licensing of custom or from-git versions is unknown. # This is valid only for the latest (i.e. known) version. ifeq ($(BR2_TARGET_ARM_TRUSTED_FIRMWARE_LATEST_VERSION),y)
Tags are no longer being pused to the old ARM-softwre mirror. Let's move to the new mirror at TrustedFirmware-A which continues to publish newer tags Signed-off-by: Bryan Brattlof <bb@ti.com> --- .../fvp-ebbr/patches/arm-trusted-firmware/arm-trusted-firmware.hash | 2 +- .../patches/arm-trusted-firmware/arm-trusted-firmware.hash | 2 +- .../beagleplay/patches/arm-trusted-firmware/arm-trusted-firmware.hash | 2 +- .../patches/arm-trusted-firmware/arm-trusted-firmware.hash | 2 +- .../patches/arm-trusted-firmware/arm-trusted-firmware.hash | 2 +- board/qemu/patches/arm-trusted-firmware/arm-trusted-firmware.hash | 2 +- .../stm32mp157/patches/arm-trusted-firmware/arm-trusted-firmware.hash | 2 +- .../am62ax-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash | 2 +- .../am62x-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash | 2 +- .../am64x-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash | 2 +- boot/arm-trusted-firmware/arm-trusted-firmware.hash | 4 ++-- boot/arm-trusted-firmware/arm-trusted-firmware.mk | 2 +- 12 files changed, 13 insertions(+), 13 deletions(-)