diff mbox series

[v5,1/3] package/rpi-firmware: bump version to 1.20240529

Message ID 20240715160941.90353-1-foss@athaariq.my.id
State New
Headers show
Series [v5,1/3] package/rpi-firmware: bump version to 1.20240529 | expand

Commit Message

Athaariq Ardhiansyah July 15, 2024, 4:09 p.m. UTC
DTB Firmware support for Raspberry Pi 5 since 1.20240306 and several
critical bug fixes including Wi-Fi breakage on BCM2712 chip.

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

---
Changes v1 -> v2:
  - Fix missing description due to terminal issue

Changes v2 -> v4:
  - Change back from commit ID to commit tag

Changes v4 -> v5:
  - Reword commit description due to ambiguous 'latest' word
---
 package/rpi-firmware/rpi-firmware.hash | 2 +-
 package/rpi-firmware/rpi-firmware.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Gaël PORTAY July 16, 2024, 6:46 a.m. UTC | #1
Hello Athaariq,

On Mon Jul 15, 2024 at 6:09 PM CEST, Athaariq Ardhiansyah wrote:
> DTB Firmware support for Raspberry Pi 5 since 1.20240306 and several
> critical bug fixes including Wi-Fi breakage on BCM2712 chip.
>

I am still a bit perplex about the commit message :/

As it was said, BR installs the dtbs from the linux kernel package, and
thus, the dtbs are **NOT** from the rpi-firmware package, so I guess the
bump would not fix anything.

Unless the fixes come from the dtb overlays you have installed. But, if
not, I would leave it blank, because it could be wrong and confusing.

> diff --git a/package/rpi-firmware/rpi-firmware.mk b/package/rpi-firmware/rpi-firmware.mk
> index 7ae9ff6c28..81066f0fc0 100644
> --- a/package/rpi-firmware/rpi-firmware.mk
> +++ b/package/rpi-firmware/rpi-firmware.mk
> @@ -4,7 +4,7 @@
>  #
>  ################################################################################
>  

As requested by Thomas, you can add the following comment:

	# Please keep in sync with configs/raspberrypi*_deconfig

> -RPI_FIRMWARE_VERSION = 5476720d52cf579dc1627715262b30ba1242525e
> +RPI_FIRMWARE_VERSION = 1.20240529
>  RPI_FIRMWARE_SITE = $(call github,raspberrypi,firmware,$(RPI_FIRMWARE_VERSION))
>  RPI_FIRMWARE_LICENSE = BSD-3-Clause
>  RPI_FIRMWARE_LICENSE_FILES = boot/LICENCE.broadcom

Regards,
Gaël
Athaariq Ardhiansyah July 16, 2024, 11:45 a.m. UTC | #2
Hello Gaël,

 > As it was said, BR installs the dtbs from the linux kernel package, and
 > thus, the dtbs are **NOT** from the rpi-firmware package, so I guess the
 > bump would not fix anything.
 >
 > Unless the fixes come from the dtb overlays you have installed. But, if
 > not, I would leave it blank, because it could be wrong and confusing.

Yeah I agree. I think this patch series is no longer relevant for now.
The Wi-Fi breakage fix only exist on linux v6.6.39, not v6.6.31 which is
currently latest stable now. Therefore, the bump won't do anyting useful
until the newer stable tag.

 > As requested by Thomas, you can add the following comment:
 >	# Please keep in sync with configs/raspberrypi*_deconfig

This going to be submitted on the next raspberry's linux kernel stable
tag, as I want to experiment to make the version tag synchronized on
both kernel and rpi-firmware version. If it impossible, then Thomas'
suggestion would be the best option. I'm going to bump all of
raspberry pi boards at once on that patch submission.

Regards,
Athaariq Ardhiansyah
Gaël PORTAY July 16, 2024, 6:16 p.m. UTC | #3
Hello Athaariq,

On Tue Jul 16, 2024 at 1:45 PM CEST, Athaariq Ardhiansyah wrote:
> Yeah I agree. I think this patch series is no longer relevant for now.
> The Wi-Fi breakage fix only exist on linux v6.6.39, not v6.6.31 which is
> currently latest stable now. Therefore, the bump won't do anyting useful
> until the newer stable tag.
>

Well no, it does make sense to bump both rpi-firmware and linux!

Especially, it is very nice to bump to a tagged commit, I guess, it has
never been before :)

>  > As requested by Thomas, you can add the following comment:
>  >	# Please keep in sync with configs/raspberrypi*_deconfig
>
> This going to be submitted on the next raspberry's linux kernel stable
> tag, as I want to experiment to make the version tag synchronized on
> both kernel and rpi-firmware version. If it impossible, then Thomas'
> suggestion would be the best option. I'm going to bump all of
> raspberry pi boards at once on that patch submission.
>

It is possible, it is what it is done up to now (at the exception of
bumping to a tagged commit).

And, do not forget to comment below as well in the defconfig files ;)

	# Please keep in sync with package/rpi-firmware/rpi-firmware.mk

> Regards,
> Athaariq Ardhiansyah

Kind Regards,
Gaël
diff mbox series

Patch

diff --git a/package/rpi-firmware/rpi-firmware.hash b/package/rpi-firmware/rpi-firmware.hash
index 4501db739c..5dc6efd8b3 100644
--- a/package/rpi-firmware/rpi-firmware.hash
+++ b/package/rpi-firmware/rpi-firmware.hash
@@ -1,3 +1,3 @@ 
 # Locally computed
-sha256  00fe5487376e9d5ed14cbc72a9b7a5bd8d6900c84aee10f6d656f192a26d161c  rpi-firmware-5476720d52cf579dc1627715262b30ba1242525e.tar.gz
+sha256  48d0b1b041bf77dc81d7ed04c423a7f4ce0afd0e3fbea26462309e738b89a552  rpi-firmware-1.20240529.tar.gz
 sha256  c7283ff51f863d93a275c66e3b4cb08021a5dd4d8c1e7acc47d872fbe52d3d6b  boot/LICENCE.broadcom
diff --git a/package/rpi-firmware/rpi-firmware.mk b/package/rpi-firmware/rpi-firmware.mk
index 7ae9ff6c28..81066f0fc0 100644
--- a/package/rpi-firmware/rpi-firmware.mk
+++ b/package/rpi-firmware/rpi-firmware.mk
@@ -4,7 +4,7 @@ 
 #
 ################################################################################
 
-RPI_FIRMWARE_VERSION = 5476720d52cf579dc1627715262b30ba1242525e
+RPI_FIRMWARE_VERSION = 1.20240529
 RPI_FIRMWARE_SITE = $(call github,raspberrypi,firmware,$(RPI_FIRMWARE_VERSION))
 RPI_FIRMWARE_LICENSE = BSD-3-Clause
 RPI_FIRMWARE_LICENSE_FILES = boot/LICENCE.broadcom