| Message ID | 20240607090236.2858457-1-p-bhagat@ti.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v3] boot/ti-k3-boot-firmware: Add config option to specify version | expand |
On June 7, 2024 thus sayeth Paresh Bhagat via buildroot: > Previously the version of ti-k3-boot-firmware (TI_K3_BOOT_FIRMWARE_VERSION) was > fixed in mk file. Introduce a new config option > BR2_TARGET_TI_K3_BOOT_FIRMWARE_CUSTOM_VERSION so that user can change the version > for ti-k3-boot-firmware using menuconfig. > > This provides greater flexibility for users to select different versions of > ti-k3-boot-firmware without modfying the build script directly. > > Signed-off-by: Paresh Bhagat <p-bhagat@ti.com> > > --- > Changes v2 -> v3: > - flexibilty -> flexibility (Suggested by Chirag Shilwant) > > Changes v1 -> v2: > - Fix whitespaces/indentation in Config.in file (Suggested by Bryan Brattlof) > > boot/ti-k3-boot-firmware/Config.in | 30 +++++++++++++++++++ > .../ti-k3-boot-firmware.mk | 2 +- > 2 files changed, 31 insertions(+), 1 deletion(-) > Thanks for fixing the white-space stuff Reviewed-by: Bryan Brattlof <bb@ti.com> ~Bryan
Hi, On 07/06/24 14:32, Paresh Bhagat wrote: > Previously the version of ti-k3-boot-firmware (TI_K3_BOOT_FIRMWARE_VERSION) was > fixed in mk file. Introduce a new config option > BR2_TARGET_TI_K3_BOOT_FIRMWARE_CUSTOM_VERSION so that user can change the version > for ti-k3-boot-firmware using menuconfig. > > This provides greater flexibility for users to select different versions of > ti-k3-boot-firmware without modfying the build script directly. > > Signed-off-by: Paresh Bhagat <p-bhagat@ti.com> > > --- Acked-by: Chirag Shilwant <c-shilwant@ti.com> > Changes v2 -> v3: > - flexibilty -> flexibility (Suggested by Chirag Shilwant) > > Changes v1 -> v2: > - Fix whitespaces/indentation in Config.in file (Suggested by Bryan Brattlof) > > boot/ti-k3-boot-firmware/Config.in | 30 +++++++++++++++++++ > .../ti-k3-boot-firmware.mk | 2 +- > 2 files changed, 31 insertions(+), 1 deletion(-) > > diff --git a/boot/ti-k3-boot-firmware/Config.in b/boot/ti-k3-boot-firmware/Config.in > index d80bb4bdb3..1c2382f610 100644 > --- a/boot/ti-k3-boot-firmware/Config.in > +++ b/boot/ti-k3-boot-firmware/Config.in > @@ -5,3 +5,33 @@ config BR2_TARGET_TI_K3_BOOT_FIRMWARE > This package downloads and installs the TI-specific ti-sysfw > and ti-dm firmware needed to boot TI K3 platforms (which > include AM62x, AM64x, AM65x and more). > + > +if BR2_TARGET_TI_K3_BOOT_FIRMWARE > +choice > + prompt "ti-k3-boot-firmware version" > + default BR2_TARGET_TI_K3_BOOT_FIRMWARE_LATEST_VERSION > + help > + Select the version of Ti k3 boot firmware you want to use > + > +config BR2_TARGET_TI_K3_BOOT_FIRMWARE_LATEST_VERSION > + bool "09.02.00.009" > + > +config BR2_TARGET_TI_K3_BOOT_FIRMWARE_CUSTOM_VERSION > + bool "Custom version" > + help > + This option allows to use a specific official version from > + git.ti.org. > + > +endchoice > + > +config BR2_TARGET_TI_K3_BOOT_FIRMWARE_CUSTOM_VERSION_VALUE > + string "Custom ti-k3-boot-firmware version" > + depends on BR2_TARGET_TI_K3_BOOT_FIRMWARE_CUSTOM_VERSION > + > +config BR2_TARGET_TI_K3_BOOT_FIRMWARE_VERSION > + string > + default "09.02.00.009" if BR2_TARGET_TI_K3_BOOT_FIRMWARE_LATEST_VERSION > + default BR2_TARGET_TI_K3_BOOT_FIRMWARE_CUSTOM_VERSION_VALUE \ > + if BR2_TARGET_TI_K3_BOOT_FIRMWARE_CUSTOM_VERSION > + > +endif > diff --git a/boot/ti-k3-boot-firmware/ti-k3-boot-firmware.mk b/boot/ti-k3-boot-firmware/ti-k3-boot-firmware.mk > index 9332732ad4..350381ebbe 100644 > --- a/boot/ti-k3-boot-firmware/ti-k3-boot-firmware.mk > +++ b/boot/ti-k3-boot-firmware/ti-k3-boot-firmware.mk > @@ -4,7 +4,7 @@ > # > ################################################################################ > > -TI_K3_BOOT_FIRMWARE_VERSION = 09.02.00.009 > +TI_K3_BOOT_FIRMWARE_VERSION = $(call qstrip,$(BR2_TARGET_TI_K3_BOOT_FIRMWARE_VERSION)) > TI_K3_BOOT_FIRMWARE_SITE = https://git.ti.com/cgit/processor-firmware/ti-linux-firmware/snapshot > TI_K3_BOOT_FIRMWARE_SOURCE = ti-linux-firmware-$(TI_K3_BOOT_FIRMWARE_VERSION).tar.xz > TI_K3_BOOT_FIRMWARE_INSTALL_IMAGES = YES
Hi Paresh, some quick feedback below... On Fri, Jun 07, 2024 at 02:32:36PM +0530, Paresh Bhagat via buildroot wrote: > Previously the version of ti-k3-boot-firmware (TI_K3_BOOT_FIRMWARE_VERSION) was > fixed in mk file. Introduce a new config option > BR2_TARGET_TI_K3_BOOT_FIRMWARE_CUSTOM_VERSION so that user can change the version > for ti-k3-boot-firmware using menuconfig. > > This provides greater flexibility for users to select different versions of > ti-k3-boot-firmware without modfying the build script directly. > > Signed-off-by: Paresh Bhagat <p-bhagat@ti.com> > > --- > Changes v2 -> v3: > - flexibilty -> flexibility (Suggested by Chirag Shilwant) > > Changes v1 -> v2: > - Fix whitespaces/indentation in Config.in file (Suggested by Bryan Brattlof) > > boot/ti-k3-boot-firmware/Config.in | 30 +++++++++++++++++++ > .../ti-k3-boot-firmware.mk | 2 +- > 2 files changed, 31 insertions(+), 1 deletion(-) > > diff --git a/boot/ti-k3-boot-firmware/Config.in b/boot/ti-k3-boot-firmware/Config.in > index d80bb4bdb3..1c2382f610 100644 > --- a/boot/ti-k3-boot-firmware/Config.in > +++ b/boot/ti-k3-boot-firmware/Config.in > @@ -5,3 +5,33 @@ config BR2_TARGET_TI_K3_BOOT_FIRMWARE > This package downloads and installs the TI-specific ti-sysfw > and ti-dm firmware needed to boot TI K3 platforms (which > include AM62x, AM64x, AM65x and more). > + > +if BR2_TARGET_TI_K3_BOOT_FIRMWARE > +choice > + prompt "ti-k3-boot-firmware version" > + default BR2_TARGET_TI_K3_BOOT_FIRMWARE_LATEST_VERSION > + help > + Select the version of Ti k3 boot firmware you want to use Ti k3 -> TI K3 > + > +config BR2_TARGET_TI_K3_BOOT_FIRMWARE_LATEST_VERSION > + bool "09.02.00.009" > + > +config BR2_TARGET_TI_K3_BOOT_FIRMWARE_CUSTOM_VERSION > + bool "Custom version" > + help > + This option allows to use a specific official version from > + git.ti.org. git.ti.org -> git.ti.com Reviewed-by: Andreas Dannenberg <dannenberg@ti.com> > + > +endchoice > + > +config BR2_TARGET_TI_K3_BOOT_FIRMWARE_CUSTOM_VERSION_VALUE > + string "Custom ti-k3-boot-firmware version" > + depends on BR2_TARGET_TI_K3_BOOT_FIRMWARE_CUSTOM_VERSION > + > +config BR2_TARGET_TI_K3_BOOT_FIRMWARE_VERSION > + string > + default "09.02.00.009" if BR2_TARGET_TI_K3_BOOT_FIRMWARE_LATEST_VERSION > + default BR2_TARGET_TI_K3_BOOT_FIRMWARE_CUSTOM_VERSION_VALUE \ > + if BR2_TARGET_TI_K3_BOOT_FIRMWARE_CUSTOM_VERSION > + > +endif > diff --git a/boot/ti-k3-boot-firmware/ti-k3-boot-firmware.mk b/boot/ti-k3-boot-firmware/ti-k3-boot-firmware.mk > index 9332732ad4..350381ebbe 100644 > --- a/boot/ti-k3-boot-firmware/ti-k3-boot-firmware.mk > +++ b/boot/ti-k3-boot-firmware/ti-k3-boot-firmware.mk > @@ -4,7 +4,7 @@ > # > ################################################################################ > > -TI_K3_BOOT_FIRMWARE_VERSION = 09.02.00.009 > +TI_K3_BOOT_FIRMWARE_VERSION = $(call qstrip,$(BR2_TARGET_TI_K3_BOOT_FIRMWARE_VERSION)) > TI_K3_BOOT_FIRMWARE_SITE = https://git.ti.com/cgit/processor-firmware/ti-linux-firmware/snapshot > TI_K3_BOOT_FIRMWARE_SOURCE = ti-linux-firmware-$(TI_K3_BOOT_FIRMWARE_VERSION).tar.xz > TI_K3_BOOT_FIRMWARE_INSTALL_IMAGES = YES > -- > 2.34.1 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
diff --git a/boot/ti-k3-boot-firmware/Config.in b/boot/ti-k3-boot-firmware/Config.in index d80bb4bdb3..1c2382f610 100644 --- a/boot/ti-k3-boot-firmware/Config.in +++ b/boot/ti-k3-boot-firmware/Config.in @@ -5,3 +5,33 @@ config BR2_TARGET_TI_K3_BOOT_FIRMWARE This package downloads and installs the TI-specific ti-sysfw and ti-dm firmware needed to boot TI K3 platforms (which include AM62x, AM64x, AM65x and more). + +if BR2_TARGET_TI_K3_BOOT_FIRMWARE +choice + prompt "ti-k3-boot-firmware version" + default BR2_TARGET_TI_K3_BOOT_FIRMWARE_LATEST_VERSION + help + Select the version of Ti k3 boot firmware you want to use + +config BR2_TARGET_TI_K3_BOOT_FIRMWARE_LATEST_VERSION + bool "09.02.00.009" + +config BR2_TARGET_TI_K3_BOOT_FIRMWARE_CUSTOM_VERSION + bool "Custom version" + help + This option allows to use a specific official version from + git.ti.org. + +endchoice + +config BR2_TARGET_TI_K3_BOOT_FIRMWARE_CUSTOM_VERSION_VALUE + string "Custom ti-k3-boot-firmware version" + depends on BR2_TARGET_TI_K3_BOOT_FIRMWARE_CUSTOM_VERSION + +config BR2_TARGET_TI_K3_BOOT_FIRMWARE_VERSION + string + default "09.02.00.009" if BR2_TARGET_TI_K3_BOOT_FIRMWARE_LATEST_VERSION + default BR2_TARGET_TI_K3_BOOT_FIRMWARE_CUSTOM_VERSION_VALUE \ + if BR2_TARGET_TI_K3_BOOT_FIRMWARE_CUSTOM_VERSION + +endif diff --git a/boot/ti-k3-boot-firmware/ti-k3-boot-firmware.mk b/boot/ti-k3-boot-firmware/ti-k3-boot-firmware.mk index 9332732ad4..350381ebbe 100644 --- a/boot/ti-k3-boot-firmware/ti-k3-boot-firmware.mk +++ b/boot/ti-k3-boot-firmware/ti-k3-boot-firmware.mk @@ -4,7 +4,7 @@ # ################################################################################ -TI_K3_BOOT_FIRMWARE_VERSION = 09.02.00.009 +TI_K3_BOOT_FIRMWARE_VERSION = $(call qstrip,$(BR2_TARGET_TI_K3_BOOT_FIRMWARE_VERSION)) TI_K3_BOOT_FIRMWARE_SITE = https://git.ti.com/cgit/processor-firmware/ti-linux-firmware/snapshot TI_K3_BOOT_FIRMWARE_SOURCE = ti-linux-firmware-$(TI_K3_BOOT_FIRMWARE_VERSION).tar.xz TI_K3_BOOT_FIRMWARE_INSTALL_IMAGES = YES
Previously the version of ti-k3-boot-firmware (TI_K3_BOOT_FIRMWARE_VERSION) was fixed in mk file. Introduce a new config option BR2_TARGET_TI_K3_BOOT_FIRMWARE_CUSTOM_VERSION so that user can change the version for ti-k3-boot-firmware using menuconfig. This provides greater flexibility for users to select different versions of ti-k3-boot-firmware without modfying the build script directly. Signed-off-by: Paresh Bhagat <p-bhagat@ti.com> --- Changes v2 -> v3: - flexibilty -> flexibility (Suggested by Chirag Shilwant) Changes v1 -> v2: - Fix whitespaces/indentation in Config.in file (Suggested by Bryan Brattlof) boot/ti-k3-boot-firmware/Config.in | 30 +++++++++++++++++++ .../ti-k3-boot-firmware.mk | 2 +- 2 files changed, 31 insertions(+), 1 deletion(-)