Message ID | 20240519105436.354168-1-fontaine.fabrice@gmail.com |
---|---|
State | Accepted |
Headers | show |
Series | [1/1] package/ivi-homescreen: needs gcc >= 8 | expand |
Fabrice, All, On 2024-05-19 12:54 +0200, Fabrice Fontaine spake thusly: > ivi-homescreen needs C++17 filesystem resulting in the following build > failure with gcc < 8 since its addition in commit > 9d8497e79de3ced144877ba6ee38cc5b7181aaeb: > > In file included from /home/buildroot/instance-0/output-1/build/ivi-homescreen-5ab78a19e95c88cc5d6b173ab1260a211e78cf0a/third_party/flutter/shell/platform/common/path_utils.cc:5:0: > /home/buildroot/instance-0/output-1/build/ivi-homescreen-5ab78a19e95c88cc5d6b173ab1260a211e78cf0a/third_party/./flutter/shell/platform/common/path_utils.h:8:10: fatal error: filesystem: No such file or directory > #include <filesystem> > ^~~~~~~~~~~~ > > Fixes: 9d8497e79de3ced144877ba6ee38cc5b7181aaeb > - http://autobuild.buildroot.org/results/a5e88d5a4264a6165be31a99f1c123af53fa382e > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> Applied to master, thanks. Regards, Yann E. MORIN. > --- > package/ivi-homescreen/Config.in | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/package/ivi-homescreen/Config.in b/package/ivi-homescreen/Config.in > index dc2ccb0c97..a4f5f6835f 100644 > --- a/package/ivi-homescreen/Config.in > +++ b/package/ivi-homescreen/Config.in > @@ -3,7 +3,7 @@ menuconfig BR2_PACKAGE_IVI_HOMESCREEN > depends on BR2_PACKAGE_HOST_FLUTTER_SDK_BIN_ARCH_SUPPORTS > depends on BR2_PACKAGE_FLUTTER_ENGINE_ARCH_SUPPORTS > depends on BR2_HOST_GCC_AT_LEAST_5 # flutter-engine > - depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # flutter-engine > + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_8 # C++17 filesystem > depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # flutter-engine > depends on BR2_TOOLCHAIN_USES_GLIBC # flutter-engine > depends on BR2_INSTALL_LIBSTDCPP # flutter-engine > @@ -250,11 +250,11 @@ comment "OpenGL texture plugin needs an EGL backend" > > endif # BR2_PACKAGE_IVI_HOMESCREEN > > -comment "ivi-homescreen needs a glibc toolchain w/ wchar, C++, gcc >= 5, dynamic library, host gcc >= 5" > +comment "ivi-homescreen needs a glibc toolchain w/ wchar, C++, gcc >= 8, dynamic library, host gcc >= 5" > depends on BR2_PACKAGE_HOST_FLUTTER_SDK_BIN_ARCH_SUPPORTS > depends on BR2_PACKAGE_FLUTTER_ENGINE_ARCH_SUPPORTS > depends on !BR2_TOOLCHAIN_USES_GLIBC \ > - || !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_GCC_AT_LEAST_5 \ > + || !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_GCC_AT_LEAST_8 \ > || BR2_STATIC_LIBS || !BR2_USE_WCHAR \ > || !BR2_HOST_GCC_AT_LEAST_5 > > -- > 2.43.0 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes: > ivi-homescreen needs C++17 filesystem resulting in the following build > failure with gcc < 8 since its addition in commit > 9d8497e79de3ced144877ba6ee38cc5b7181aaeb: > In file included from /home/buildroot/instance-0/output-1/build/ivi-homescreen-5ab78a19e95c88cc5d6b173ab1260a211e78cf0a/third_party/flutter/shell/platform/common/path_utils.cc:5:0: > /home/buildroot/instance-0/output-1/build/ivi-homescreen-5ab78a19e95c88cc5d6b173ab1260a211e78cf0a/third_party/./flutter/shell/platform/common/path_utils.h:8:10: fatal error: filesystem: No such file or directory > #include <filesystem> > ^~~~~~~~~~~~ > Fixes: 9d8497e79de3ced144877ba6ee38cc5b7181aaeb > - http://autobuild.buildroot.org/results/a5e88d5a4264a6165be31a99f1c123af53fa382e > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> Committed to 2024.02.x, thanks.
diff --git a/package/ivi-homescreen/Config.in b/package/ivi-homescreen/Config.in index dc2ccb0c97..a4f5f6835f 100644 --- a/package/ivi-homescreen/Config.in +++ b/package/ivi-homescreen/Config.in @@ -3,7 +3,7 @@ menuconfig BR2_PACKAGE_IVI_HOMESCREEN depends on BR2_PACKAGE_HOST_FLUTTER_SDK_BIN_ARCH_SUPPORTS depends on BR2_PACKAGE_FLUTTER_ENGINE_ARCH_SUPPORTS depends on BR2_HOST_GCC_AT_LEAST_5 # flutter-engine - depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # flutter-engine + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_8 # C++17 filesystem depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # flutter-engine depends on BR2_TOOLCHAIN_USES_GLIBC # flutter-engine depends on BR2_INSTALL_LIBSTDCPP # flutter-engine @@ -250,11 +250,11 @@ comment "OpenGL texture plugin needs an EGL backend" endif # BR2_PACKAGE_IVI_HOMESCREEN -comment "ivi-homescreen needs a glibc toolchain w/ wchar, C++, gcc >= 5, dynamic library, host gcc >= 5" +comment "ivi-homescreen needs a glibc toolchain w/ wchar, C++, gcc >= 8, dynamic library, host gcc >= 5" depends on BR2_PACKAGE_HOST_FLUTTER_SDK_BIN_ARCH_SUPPORTS depends on BR2_PACKAGE_FLUTTER_ENGINE_ARCH_SUPPORTS depends on !BR2_TOOLCHAIN_USES_GLIBC \ - || !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_GCC_AT_LEAST_5 \ + || !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_GCC_AT_LEAST_8 \ || BR2_STATIC_LIBS || !BR2_USE_WCHAR \ || !BR2_HOST_GCC_AT_LEAST_5
ivi-homescreen needs C++17 filesystem resulting in the following build failure with gcc < 8 since its addition in commit 9d8497e79de3ced144877ba6ee38cc5b7181aaeb: In file included from /home/buildroot/instance-0/output-1/build/ivi-homescreen-5ab78a19e95c88cc5d6b173ab1260a211e78cf0a/third_party/flutter/shell/platform/common/path_utils.cc:5:0: /home/buildroot/instance-0/output-1/build/ivi-homescreen-5ab78a19e95c88cc5d6b173ab1260a211e78cf0a/third_party/./flutter/shell/platform/common/path_utils.h:8:10: fatal error: filesystem: No such file or directory #include <filesystem> ^~~~~~~~~~~~ Fixes: 9d8497e79de3ced144877ba6ee38cc5b7181aaeb - http://autobuild.buildroot.org/results/a5e88d5a4264a6165be31a99f1c123af53fa382e Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> --- package/ivi-homescreen/Config.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)