| Message ID | 20240213123753.2471309-2-buildroot@bubu1.eu |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/2] package/python-can/Config.in: sort selects | expand |
On Tue, 13 Feb 2024 13:37:53 +0100 Marcus Hoffmann via buildroot <buildroot@buildroot.org> wrote: > The can.viewer tool requires curses support. [1] > > [1] https://github.com/hardbyte/python-can/blob/v4.3.1/can/viewer.py#L44-L53 > > Signed-off-by: Marcus Hoffmann <buildroot@bubu1.eu> > --- > package/python-can/Config.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/python-can/Config.in b/package/python-can/Config.in > index 61955a2b00..106da4560c 100644 > --- a/package/python-can/Config.in > +++ b/package/python-can/Config.in > @@ -1,5 +1,6 @@ > config BR2_PACKAGE_PYTHON_CAN > bool "python-can" > + select BR2_PACKAGE_PYTHON3_CURSES # runtime for can.viewer tool I am not 100% sure on this one. Do we want to make this dependency mandatory, while it is only needed for a viewer tool, which probably most users of python-can won't use? I see two alternatives here: 1. Leave things are they are today, i.e let users figure out that they need to enable curses support for the viewer. 2. Add an explicit BR2_PACKAGE_PYTHON_CAN_VIEWER option, which selects BR2_PACKAGE_PYTHON3_CURSES and enables the installation of the viewer tool. When this option is disabled, viewer.py is not installed (or removed if disabling installation is not possible) Thoughts? This is not a hard feeling on my side. Thomas
Hi Thomas, On 22.07.24 22:37, Thomas Petazzoni wrote: > On Tue, 13 Feb 2024 13:37:53 +0100 > Marcus Hoffmann via buildroot <buildroot@buildroot.org> wrote: > >> The can.viewer tool requires curses support. [1] >> >> [1] https://github.com/hardbyte/python-can/blob/v4.3.1/can/viewer.py#L44-L53 >> >> Signed-off-by: Marcus Hoffmann <buildroot@bubu1.eu> >> --- >> package/python-can/Config.in | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/package/python-can/Config.in b/package/python-can/Config.in >> index 61955a2b00..106da4560c 100644 >> --- a/package/python-can/Config.in >> +++ b/package/python-can/Config.in >> @@ -1,5 +1,6 @@ >> config BR2_PACKAGE_PYTHON_CAN >> bool "python-can" >> + select BR2_PACKAGE_PYTHON3_CURSES # runtime for can.viewer tool > > I am not 100% sure on this one. Do we want to make this dependency > mandatory, while it is only needed for a viewer tool, which probably > most users of python-can won't use? > > I see two alternatives here: > > 1. Leave things are they are today, i.e let users figure out that they > need to enable curses support for the viewer. > > 2. Add an explicit BR2_PACKAGE_PYTHON_CAN_VIEWER option, which selects > BR2_PACKAGE_PYTHON3_CURSES and enables the installation of the viewer > tool. When this option is disabled, viewer.py is not installed (or > removed if disabling installation is not possible) > > Thoughts? This is not a hard feeling on my side. I didn't really have a strong opinion either, but I went ahead and submitted a patch with the second options now. Hope this makes sense :). Marcus > > Thomas
diff --git a/package/python-can/Config.in b/package/python-can/Config.in index 61955a2b00..106da4560c 100644 --- a/package/python-can/Config.in +++ b/package/python-can/Config.in @@ -1,5 +1,6 @@ config BR2_PACKAGE_PYTHON_CAN bool "python-can" + select BR2_PACKAGE_PYTHON3_CURSES # runtime for can.viewer tool select BR2_PACKAGE_PYTHON3_SQLITE # runtime select BR2_PACKAGE_PYTHON3_ZLIB # runtime select BR2_PACKAGE_PYTHON_MSGPACK # runtime
The can.viewer tool requires curses support. [1] [1] https://github.com/hardbyte/python-can/blob/v4.3.1/can/viewer.py#L44-L53 Signed-off-by: Marcus Hoffmann <buildroot@bubu1.eu> --- package/python-can/Config.in | 1 + 1 file changed, 1 insertion(+)