| Message ID | 20240125144121.1534299-1-aperez@igalia.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | package/libwpe: switch back to version 1.14.2 | expand |
>>>>> "Adrian" == Adrian Perez de Castro <aperez@igalia.com> writes: > The versioning scheme for libwpe uses the middle version number to > indicate stability: an even number for stable releases, odd for > development preview releases. As such, Buildroot should be using > version 1.14.2, which is the most recent of the stable releases. > While at it, add a note in the .mk file about the versioning scheme. Hmm, this was bumped back in July before 2023.08-rc1. Is there no 1.16.x version coming? > Signed-off-by: Adrian Perez de Castro <aperez@igalia.com> > --- > package/libwpe/libwpe.hash | 6 +++--- > package/libwpe/libwpe.mk | 3 ++- > 2 files changed, 5 insertions(+), 4 deletions(-) > diff --git a/package/libwpe/libwpe.hash b/package/libwpe/libwpe.hash > index 226b4f3295..554b1f2b0e 100644 > --- a/package/libwpe/libwpe.hash > +++ b/package/libwpe/libwpe.hash > @@ -1,6 +1,6 @@ > -# From https://wpewebkit.org/releases/libwpe-1.15.1.tar.xz.sums > -sha1 0082ceb475175bfecd1172f2c0b292824d31561b libwpe-1.15.1.tar.xz > -sha256 14d36a93a05ab7ada9bec581720b8057336fe681bbbe59bda7d50cb8f3eba3a6 libwpe-1.15.1.tar.xz > +# From https://wpewebkit.org/releases/libwpe-1.14.2.tar.xz.sums > +sha1 70a2b894af2b50d7082260158a89524974a480f3 libwpe-1.14.2.tar.xz > +sha256 8ae38022c50cb340c96fdbee1217f1e46ab57fbc1c8ba98142565abbedbe22ef libwpe-1.14.2.tar.xz > # Hashes for license files: > sha256 35bef295cedbbf179eaee14328002587a0e7dc08ebf3f15ea080a6f2815f0d7b COPYING > diff --git a/package/libwpe/libwpe.mk b/package/libwpe/libwpe.mk > index f8c6b0fc76..1fbdd5fcc3 100644 > --- a/package/libwpe/libwpe.mk > +++ b/package/libwpe/libwpe.mk > @@ -4,7 +4,8 @@ > # > ################################################################################ > -LIBWPE_VERSION = 1.15.1 > +# The middle number is even for stable releases, odd for development ones. > +LIBWPE_VERSION = 1.14.2 > LIBWPE_SITE = https://wpewebkit.org/releases > LIBWPE_SOURCE = libwpe-$(LIBWPE_VERSION).tar.xz > LIBWPE_INSTALL_STAGING = YES > -- > 2.43.0 > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
Hello, On Thu, 25 Jan 2024 22:11:39 +0100 Peter Korsgaard <peter@korsgaard.com> wrote: > >>>>> "Adrian" == Adrian Perez de Castro <aperez@igalia.com> writes: > > > The versioning scheme for libwpe uses the middle version number to > > indicate stability: an even number for stable releases, odd for > > development preview releases. As such, Buildroot should be using > > version 1.14.2, which is the most recent of the stable releases. > > While at it, add a note in the .mk file about the versioning scheme. > > Hmm, this was bumped back in July before 2023.08-rc1. Is there no 1.16.x > version coming? Not anytime soon. Release 1.14.2 which I just made yesterday includes all the fixes that are also in 1.15.2 -- usually we only do a new stable branch if there are new features, and we haven't added anything to libwpe for a quite long time. Also, Yann asked on IRC whether the packages that depend on libwpe (wpebackend-fdo, wpewebkit, gst1-plugins-bad) can use 1.14.x... Yes, they can. For WPE WebKit we even have a compatibility table here: https://wpewebkit.org/release/schedule/ =) Maybe we should reconsider the versioning scheme, using suffixes for development releases and release candidates ("X.Y-devN", "X-Y-rcN") instead of even/odd numbering. It seems to cause enough confusion to at least consider the change. > > Signed-off-by: Adrian Perez de Castro <aperez@igalia.com> > > --- > > package/libwpe/libwpe.hash | 6 +++--- > > package/libwpe/libwpe.mk | 3 ++- > > 2 files changed, 5 insertions(+), 4 deletions(-) > > > diff --git a/package/libwpe/libwpe.hash b/package/libwpe/libwpe.hash > > index 226b4f3295..554b1f2b0e 100644 > > --- a/package/libwpe/libwpe.hash > > +++ b/package/libwpe/libwpe.hash > > @@ -1,6 +1,6 @@ > > -# From https://wpewebkit.org/releases/libwpe-1.15.1.tar.xz.sums > > -sha1 0082ceb475175bfecd1172f2c0b292824d31561b libwpe-1.15.1.tar.xz > > -sha256 14d36a93a05ab7ada9bec581720b8057336fe681bbbe59bda7d50cb8f3eba3a6 libwpe-1.15.1.tar.xz > > +# From https://wpewebkit.org/releases/libwpe-1.14.2.tar.xz.sums > > +sha1 70a2b894af2b50d7082260158a89524974a480f3 libwpe-1.14.2.tar.xz > > +sha256 8ae38022c50cb340c96fdbee1217f1e46ab57fbc1c8ba98142565abbedbe22ef libwpe-1.14.2.tar.xz > > > # Hashes for license files: > > sha256 35bef295cedbbf179eaee14328002587a0e7dc08ebf3f15ea080a6f2815f0d7b COPYING > > diff --git a/package/libwpe/libwpe.mk b/package/libwpe/libwpe.mk > > index f8c6b0fc76..1fbdd5fcc3 100644 > > --- a/package/libwpe/libwpe.mk > > +++ b/package/libwpe/libwpe.mk > > @@ -4,7 +4,8 @@ > > # > > ################################################################################ > > > -LIBWPE_VERSION = 1.15.1 > > +# The middle number is even for stable releases, odd for development ones. > > +LIBWPE_VERSION = 1.14.2 > > LIBWPE_SITE = https://wpewebkit.org/releases > > LIBWPE_SOURCE = libwpe-$(LIBWPE_VERSION).tar.xz > > LIBWPE_INSTALL_STAGING = YES > > -- > > > 2.43.0 > > > _______________________________________________ > > buildroot mailing list > > buildroot@buildroot.org > > https://lists.buildroot.org/mailman/listinfo/buildroot > > > -- > Bye, Peter Korsgaard > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot > Cheers, —Adrián
On 25/01/2024 23.33, Adrian Perez de Castro wrote: >> Hmm, this was bumped back in July before 2023.08-rc1. Is there no 1.16.x >> version coming? > > Not anytime soon. Release 1.14.2 which I just made yesterday includes all the > fixes that are also in 1.15.2 -- usually we only do a new stable branch if > there are new features, and we haven't added anything to libwpe for a quite > long time. > > Also, Yann asked on IRC whether the packages that depend on libwpe > (wpebackend-fdo, wpewebkit, gst1-plugins-bad) can use 1.14.x... Yes, > they can. For WPE WebKit we even have a compatibility table here: > > https://wpewebkit.org/release/schedule/ > > =) OK, good - Applied, thanks. > Maybe we should reconsider the versioning scheme, using suffixes for > development releases and release candidates ("X.Y-devN", "X-Y-rcN") > instead of even/odd numbering. It seems to cause enough confusion to > at least consider the change. I don't really feel strongly about it. It is a bit "odd", but consistent with the gtk/gnome stuff.
On Fri, 26 Jan 2024 09:43:23 +0100 Peter Korsgaard <peter@korsgaard.com> wrote: > On 25/01/2024 23.33, Adrian Perez de Castro wrote: > >> Hmm, this was bumped back in July before 2023.08-rc1. Is there no 1.16.x > >> version coming? > > > > Not anytime soon. Release 1.14.2 which I just made yesterday includes all the > > fixes that are also in 1.15.2 -- usually we only do a new stable branch if > > there are new features, and we haven't added anything to libwpe for a quite > > long time. > > > > Also, Yann asked on IRC whether the packages that depend on libwpe > > (wpebackend-fdo, wpewebkit, gst1-plugins-bad) can use 1.14.x... Yes, > > they can. For WPE WebKit we even have a compatibility table here: > > > > https://wpewebkit.org/release/schedule/ > > > > =) > > OK, good - Applied, thanks. Super :) > > Maybe we should reconsider the versioning scheme, using suffixes for > > development releases and release candidates ("X.Y-devN", "X-Y-rcN") > > instead of even/odd numbering. It seems to cause enough confusion to > > at least consider the change. > > I don't really feel strongly about it. It is a bit "odd", but consistent > with the gtk/gnome stuff. GNOME has been slowly trying to phase out the even/odd numbering scheme, but it is true that most libraries are still using it, and so far it has been mostly user-facing applications the ones that have adopted the new versioning scheme [1]. Given it's not really a "problem", we actually prefer to avoid changing it in the WebKit components to avoid churn. What I'll do is add a comment next to the version string in the .mk files, like I did in this patch, next time I update the other packages. Cheers, —Adrián --- [1] https://discourse.gnome.org/t/new-gnome-versioning-scheme/4235
diff --git a/package/libwpe/libwpe.hash b/package/libwpe/libwpe.hash index 226b4f3295..554b1f2b0e 100644 --- a/package/libwpe/libwpe.hash +++ b/package/libwpe/libwpe.hash @@ -1,6 +1,6 @@ -# From https://wpewebkit.org/releases/libwpe-1.15.1.tar.xz.sums -sha1 0082ceb475175bfecd1172f2c0b292824d31561b libwpe-1.15.1.tar.xz -sha256 14d36a93a05ab7ada9bec581720b8057336fe681bbbe59bda7d50cb8f3eba3a6 libwpe-1.15.1.tar.xz +# From https://wpewebkit.org/releases/libwpe-1.14.2.tar.xz.sums +sha1 70a2b894af2b50d7082260158a89524974a480f3 libwpe-1.14.2.tar.xz +sha256 8ae38022c50cb340c96fdbee1217f1e46ab57fbc1c8ba98142565abbedbe22ef libwpe-1.14.2.tar.xz # Hashes for license files: sha256 35bef295cedbbf179eaee14328002587a0e7dc08ebf3f15ea080a6f2815f0d7b COPYING diff --git a/package/libwpe/libwpe.mk b/package/libwpe/libwpe.mk index f8c6b0fc76..1fbdd5fcc3 100644 --- a/package/libwpe/libwpe.mk +++ b/package/libwpe/libwpe.mk @@ -4,7 +4,8 @@ # ################################################################################ -LIBWPE_VERSION = 1.15.1 +# The middle number is even for stable releases, odd for development ones. +LIBWPE_VERSION = 1.14.2 LIBWPE_SITE = https://wpewebkit.org/releases LIBWPE_SOURCE = libwpe-$(LIBWPE_VERSION).tar.xz LIBWPE_INSTALL_STAGING = YES
The versioning scheme for libwpe uses the middle version number to indicate stability: an even number for stable releases, odd for development preview releases. As such, Buildroot should be using version 1.14.2, which is the most recent of the stable releases. While at it, add a note in the .mk file about the versioning scheme. Signed-off-by: Adrian Perez de Castro <aperez@igalia.com> --- package/libwpe/libwpe.hash | 6 +++--- package/libwpe/libwpe.mk | 3 ++- 2 files changed, 5 insertions(+), 4 deletions(-)