Message ID | 20231226135941.2784505-1-thomas.petazzoni@bootlin.com |
---|---|
State | Accepted |
Headers | show |
Series | [v2,1/2] package/gmpc: remove package | expand |
Thomas, All, On 2023-12-26 14:59 +0100, Thomas Petazzoni via buildroot spake thusly: > This package is unmaintained upstream: > > - The URL in our Config.in, > http://gmpcwiki.sarine.nl/index.php?title=GMPC, no longer works > > - https://github.com/DaveDavenport/gmpc says it's unmaintained > > - The official lists of MPD clients at > https://www.musicpd.org/clients/ says it's maintained, and points at > http://gmpclient.org/, which is no longer owned by the developers of > GMPC. > > - It still uses libsoup (2) which we want to get rid of at some > point. > > - It was added by Gustavo Zacarias, and no version bumped occurred > since 2011. > > So let's kill this package. > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> Both applied to master, thanks. Regards, Yann E. MORIN. > --- > Config.in.legacy | 7 +++++++ > package/Config.in | 1 - > package/gmpc/Config.in | 26 -------------------------- > package/gmpc/gmpc.hash | 3 --- > package/gmpc/gmpc.mk | 18 ------------------ > 5 files changed, 7 insertions(+), 48 deletions(-) > delete mode 100644 package/gmpc/Config.in > delete mode 100644 package/gmpc/gmpc.hash > delete mode 100644 package/gmpc/gmpc.mk > > diff --git a/Config.in.legacy b/Config.in.legacy > index d46bd97442..0ab9dcadff 100644 > --- a/Config.in.legacy > +++ b/Config.in.legacy > @@ -146,6 +146,13 @@ endif > > comment "Legacy options removed in 2023.11" > > +config BR2_PACKAGE_GMPC > + bool "gmpc package was removed" > + select BR2_LEGACY > + help > + The gmpc package was removed because it was unmaintained, > + and still using the old libsoup2 library. > + > config BR2_PACKAGE_ONEVPL > bool "onevpl package was renamed" > select BR2_LEGACY > diff --git a/package/Config.in b/package/Config.in > index 98653ff29d..34efaf29e5 100644 > --- a/package/Config.in > +++ b/package/Config.in > @@ -405,7 +405,6 @@ comment "X applications" > source "package/dillo/Config.in" > source "package/docker/Config.in" > source "package/feh/Config.in" > - source "package/gmpc/Config.in" > source "package/gtkperf/Config.in" > source "package/leafpad/Config.in" > source "package/mupdf/Config.in" > diff --git a/package/gmpc/Config.in b/package/gmpc/Config.in > deleted file mode 100644 > index 1aa74251f0..0000000000 > --- a/package/gmpc/Config.in > +++ /dev/null > @@ -1,26 +0,0 @@ > -config BR2_PACKAGE_GMPC > - bool "gmpc" > - depends on BR2_PACKAGE_LIBGTK2 > - depends on BR2_USE_WCHAR # glib2 > - depends on BR2_TOOLCHAIN_HAS_THREADS # glib2 > - depends on BR2_USE_MMU # glib2 > - depends on BR2_PACKAGE_XORG7 > - select BR2_PACKAGE_LIBGLIB2 > - select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE > - select BR2_PACKAGE_LIBMPD > - select BR2_PACKAGE_LIBSOUP > - select BR2_PACKAGE_LIBXML2 > - select BR2_PACKAGE_SQLITE > - select BR2_PACKAGE_XLIB_LIBICE > - select BR2_PACKAGE_XLIB_LIBSM > - select BR2_PACKAGE_XLIB_LIBX11 > - help > - Gnome Music Player Client is a GNOME/GTK2.2 client for > - Music Player Daemon. > - > - http://gmpcwiki.sarine.nl/index.php?title=GMPC > - > -comment "gmpc needs a toolchain w/ wchar, threads" > - depends on BR2_USE_MMU > - depends on BR2_PACKAGE_XORG7 && BR2_PACKAGE_LIBGTK2 > - depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS > diff --git a/package/gmpc/gmpc.hash b/package/gmpc/gmpc.hash > deleted file mode 100644 > index 66de8b6226..0000000000 > --- a/package/gmpc/gmpc.hash > +++ /dev/null > @@ -1,3 +0,0 @@ > -# Locally calculated > -sha256 a69414f35396846733632ca9619921d7acda537ffd6d49bd84b444945cb76b2c gmpc-11.8.16.tar.gz > -sha256 ab15fd526bd8dd18a9e77ebc139656bf4d33e97fc7238cd11bf60e2b9b8666c6 COPYING > diff --git a/package/gmpc/gmpc.mk b/package/gmpc/gmpc.mk > deleted file mode 100644 > index 40b77eb189..0000000000 > --- a/package/gmpc/gmpc.mk > +++ /dev/null > @@ -1,18 +0,0 @@ > -################################################################################ > -# > -# gmpc > -# > -################################################################################ > - > -GMPC_VERSION = 11.8.16 > -GMPC_SITE = http://download.sarine.nl/Programs/gmpc/$(GMPC_VERSION) > -GMPC_CONF_ENV = ac_cv_path_GOB2=$(GOB2_HOST_BINARY) > -GMPC_CONF_OPTS = --disable-mmkeys --disable-unique > -GMPC_LICENSE = GPL-2.0+ > -GMPC_LICENSE_FILES = COPYING > -GMPC_DEPENDENCIES = host-gob2 host-intltool host-pkgconf host-vala \ > - libglib2 libgtk2 libmpd libsoup sqlite \ > - xlib_libICE xlib_libSM xlib_libX11 \ > - $(TARGET_NLS_DEPENDENCIES) > - > -$(eval $(autotools-package)) > -- > 2.43.0 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
diff --git a/Config.in.legacy b/Config.in.legacy index d46bd97442..0ab9dcadff 100644 --- a/Config.in.legacy +++ b/Config.in.legacy @@ -146,6 +146,13 @@ endif comment "Legacy options removed in 2023.11" +config BR2_PACKAGE_GMPC + bool "gmpc package was removed" + select BR2_LEGACY + help + The gmpc package was removed because it was unmaintained, + and still using the old libsoup2 library. + config BR2_PACKAGE_ONEVPL bool "onevpl package was renamed" select BR2_LEGACY diff --git a/package/Config.in b/package/Config.in index 98653ff29d..34efaf29e5 100644 --- a/package/Config.in +++ b/package/Config.in @@ -405,7 +405,6 @@ comment "X applications" source "package/dillo/Config.in" source "package/docker/Config.in" source "package/feh/Config.in" - source "package/gmpc/Config.in" source "package/gtkperf/Config.in" source "package/leafpad/Config.in" source "package/mupdf/Config.in" diff --git a/package/gmpc/Config.in b/package/gmpc/Config.in deleted file mode 100644 index 1aa74251f0..0000000000 --- a/package/gmpc/Config.in +++ /dev/null @@ -1,26 +0,0 @@ -config BR2_PACKAGE_GMPC - bool "gmpc" - depends on BR2_PACKAGE_LIBGTK2 - depends on BR2_USE_WCHAR # glib2 - depends on BR2_TOOLCHAIN_HAS_THREADS # glib2 - depends on BR2_USE_MMU # glib2 - depends on BR2_PACKAGE_XORG7 - select BR2_PACKAGE_LIBGLIB2 - select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE - select BR2_PACKAGE_LIBMPD - select BR2_PACKAGE_LIBSOUP - select BR2_PACKAGE_LIBXML2 - select BR2_PACKAGE_SQLITE - select BR2_PACKAGE_XLIB_LIBICE - select BR2_PACKAGE_XLIB_LIBSM - select BR2_PACKAGE_XLIB_LIBX11 - help - Gnome Music Player Client is a GNOME/GTK2.2 client for - Music Player Daemon. - - http://gmpcwiki.sarine.nl/index.php?title=GMPC - -comment "gmpc needs a toolchain w/ wchar, threads" - depends on BR2_USE_MMU - depends on BR2_PACKAGE_XORG7 && BR2_PACKAGE_LIBGTK2 - depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS diff --git a/package/gmpc/gmpc.hash b/package/gmpc/gmpc.hash deleted file mode 100644 index 66de8b6226..0000000000 --- a/package/gmpc/gmpc.hash +++ /dev/null @@ -1,3 +0,0 @@ -# Locally calculated -sha256 a69414f35396846733632ca9619921d7acda537ffd6d49bd84b444945cb76b2c gmpc-11.8.16.tar.gz -sha256 ab15fd526bd8dd18a9e77ebc139656bf4d33e97fc7238cd11bf60e2b9b8666c6 COPYING diff --git a/package/gmpc/gmpc.mk b/package/gmpc/gmpc.mk deleted file mode 100644 index 40b77eb189..0000000000 --- a/package/gmpc/gmpc.mk +++ /dev/null @@ -1,18 +0,0 @@ -################################################################################ -# -# gmpc -# -################################################################################ - -GMPC_VERSION = 11.8.16 -GMPC_SITE = http://download.sarine.nl/Programs/gmpc/$(GMPC_VERSION) -GMPC_CONF_ENV = ac_cv_path_GOB2=$(GOB2_HOST_BINARY) -GMPC_CONF_OPTS = --disable-mmkeys --disable-unique -GMPC_LICENSE = GPL-2.0+ -GMPC_LICENSE_FILES = COPYING -GMPC_DEPENDENCIES = host-gob2 host-intltool host-pkgconf host-vala \ - libglib2 libgtk2 libmpd libsoup sqlite \ - xlib_libICE xlib_libSM xlib_libX11 \ - $(TARGET_NLS_DEPENDENCIES) - -$(eval $(autotools-package))
This package is unmaintained upstream: - The URL in our Config.in, http://gmpcwiki.sarine.nl/index.php?title=GMPC, no longer works - https://github.com/DaveDavenport/gmpc says it's unmaintained - The official lists of MPD clients at https://www.musicpd.org/clients/ says it's maintained, and points at http://gmpclient.org/, which is no longer owned by the developers of GMPC. - It still uses libsoup (2) which we want to get rid of at some point. - It was added by Gustavo Zacarias, and no version bumped occurred since 2011. So let's kill this package. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> --- Config.in.legacy | 7 +++++++ package/Config.in | 1 - package/gmpc/Config.in | 26 -------------------------- package/gmpc/gmpc.hash | 3 --- package/gmpc/gmpc.mk | 18 ------------------ 5 files changed, 7 insertions(+), 48 deletions(-) delete mode 100644 package/gmpc/Config.in delete mode 100644 package/gmpc/gmpc.hash delete mode 100644 package/gmpc/gmpc.mk