diff mbox series

[v2,2/2] board/versal: fix atf build failure

Message ID 20230731154739.1371164-2-neal.frager@amd.com
State Accepted
Headers show
Series [v2,1/2] board/zynqmp: fix atf build failure | expand

Commit Message

Neal Frager July 31, 2023, 3:47 p.m. UTC
Binutils 2.39 now warns when a segment has RXW permissions:
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=ba951afb99912da01a6e8434126b8fac7aa75107

This causes the following build error:
aarch64-buildroot-linux-gnu-ld: bl31.elf has a LOAD segment with RWX
permissions.

This patch applies the upstream boot/arm-trusted-firmware/v2.6 patch already
included with buildroot to solve the problem.

Fixes: https://developer.trustedfirmware.org/T996
Signed-off-by: Neal Frager <neal.frager@amd.com>
---
V1->V2:
  -switch to upstream version of patch already included with buildroot
  -fix commit message accordingly
---
 .../0001-feat-build-add-support-for-new-binutils-versions.patch  | 1 +
 configs/versal_vck190_defconfig                                  | 1 +
 2 files changed, 2 insertions(+)
 create mode 120000 board/versal/patches/arm-trusted-firmware/0001-feat-build-add-support-for-new-binutils-versions.patch

Comments

Thomas Petazzoni Aug. 1, 2023, 9:26 p.m. UTC | #1
Hello Neal,

On Mon, 31 Jul 2023 16:47:39 +0100
Neal Frager via buildroot <buildroot@buildroot.org> wrote:

> Binutils 2.39 now warns when a segment has RXW permissions:
> https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=ba951afb99912da01a6e8434126b8fac7aa75107
> 
> This causes the following build error:
> aarch64-buildroot-linux-gnu-ld: bl31.elf has a LOAD segment with RWX
> permissions.
> 
> This patch applies the upstream boot/arm-trusted-firmware/v2.6 patch already
> included with buildroot to solve the problem.
> 
> Fixes: https://developer.trustedfirmware.org/T996

Same comment as for PATCH 1/2, so I changed to:

    Fixes:
    
      https://gitlab.com/buildroot.org/buildroot/-/jobs/4749556395 (versal_vck190)

when applying. Thanks!

Thomas
diff mbox series

Patch

diff --git a/board/versal/patches/arm-trusted-firmware/0001-feat-build-add-support-for-new-binutils-versions.patch b/board/versal/patches/arm-trusted-firmware/0001-feat-build-add-support-for-new-binutils-versions.patch
new file mode 120000
index 0000000000..695cc80b94
--- /dev/null
+++ b/board/versal/patches/arm-trusted-firmware/0001-feat-build-add-support-for-new-binutils-versions.patch
@@ -0,0 +1 @@ 
+../../../../boot/arm-trusted-firmware/v2.6/0001-feat-build-add-support-for-new-binutils-versions.patch
\ No newline at end of file
diff --git a/configs/versal_vck190_defconfig b/configs/versal_vck190_defconfig
index a393b681c8..fab41a2991 100644
--- a/configs/versal_vck190_defconfig
+++ b/configs/versal_vck190_defconfig
@@ -39,3 +39,4 @@  BR2_PACKAGE_HOST_DOSFSTOOLS=y
 BR2_PACKAGE_HOST_GENIMAGE=y
 BR2_PACKAGE_HOST_MTOOLS=y
 BR2_PACKAGE_HOST_BOOTGEN=y
+BR2_GLOBAL_PATCH_DIR="board/versal/patches"