| Message ID | 20230420144537.2660650-1-raphael.melotte@mind.be |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/1] package/python-pymupdf: add missing host swig dependency | expand |
Raphaël, All, On 2023-04-20 16:45 +0200, Raphaël Mélotte spake thusly: > It appears that python-pymupdf needs swig when building since mupdf > was bumped to 1.18.0 in commit > f00da714a20a7826dda67d66f2a6b6ef858ef3e3. This was not noticed before > because when building on a machine where swig is already available > outside buildroot, it is used and the build succeeds. > > This fixes the following build failure: > > swigging fitz/fitz.i to fitz/fitz_wrap.c > swig -python -w509 -o fitz/fitz_wrap.c fitz/fitz.i > error: command 'swig' failed: No such file or directory > make: *** [package/pkg-generic.mk:293: > /home/buildroot/autobuild/instance-2/output-1/build/python-pymupdf-1.21.1/.stamp_built] > Error 1 > > Fixes: > - http://autobuild.buildroot.net/results/c689a385d984b87b63f3f2ff30338049774b1bf2 > - http://autobuild.buildroot.net/results/cf268d3631330a8288fb8ad2af009abb7f1ca6b0 > > Signed-off-by: Raphaël Mélotte <raphael.melotte@mind.be> Applied to master, thanks. Regards, Yann E. MORIN. > --- > package/python-pymupdf/Config.in | 1 + > package/python-pymupdf/python-pymupdf.mk | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/package/python-pymupdf/Config.in b/package/python-pymupdf/Config.in > index b3f9565238..ecaa5496b5 100644 > --- a/package/python-pymupdf/Config.in > +++ b/package/python-pymupdf/Config.in > @@ -4,6 +4,7 @@ config BR2_PACKAGE_PYTHON_PYMUPDF > depends on BR2_TOOLCHAIN_HAS_SYNC_4 # mupdf -> harfbuzz > depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # mupdf -> harfbuzz > depends on BR2_PACKAGE_XORG7 > + select BR2_PACKAGE_HOST_SWIG > select BR2_PACKAGE_FREETYPE > select BR2_PACKAGE_MUPDF > select BR2_PACKAGE_ZLIB > diff --git a/package/python-pymupdf/python-pymupdf.mk b/package/python-pymupdf/python-pymupdf.mk > index 70448e8d90..03fc8bc4fb 100644 > --- a/package/python-pymupdf/python-pymupdf.mk > +++ b/package/python-pymupdf/python-pymupdf.mk > @@ -12,7 +12,7 @@ PYTHON_PYMUPDF_SETUP_TYPE = setuptools > PYTHON_PYMUPDF_LICENSE = AGPL-3.0+ > PYTHON_PYMUPDF_LICENSE_FILES = COPYING > # No license file included in pip, but it's present on github > -PYTHON_PYMUPDF_DEPENDENCIES = freetype mupdf zlib > +PYTHON_PYMUPDF_DEPENDENCIES = freetype host-swig mupdf zlib > > PYTHON_PYMUPDF_ENV = CFLAGS="-I$(STAGING_DIR)/usr/include/mupdf -I$(STAGING_DIR)/usr/include/freetype2" > > -- > 2.37.3 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
>>>>> "Raphaël" == Raphaël Mélotte <raphael.melotte@mind.be> writes: > It appears that python-pymupdf needs swig when building since mupdf > was bumped to 1.18.0 in commit > f00da714a20a7826dda67d66f2a6b6ef858ef3e3. This was not noticed before > because when building on a machine where swig is already available > outside buildroot, it is used and the build succeeds. > This fixes the following build failure: > swigging fitz/fitz.i to fitz/fitz_wrap.c > swig -python -w509 -o fitz/fitz_wrap.c fitz/fitz.i > error: command 'swig' failed: No such file or directory > make: *** [package/pkg-generic.mk:293: > /home/buildroot/autobuild/instance-2/output-1/build/python-pymupdf-1.21.1/.stamp_built] > Error 1 > Fixes: > - http://autobuild.buildroot.net/results/c689a385d984b87b63f3f2ff30338049774b1bf2 > - http://autobuild.buildroot.net/results/cf268d3631330a8288fb8ad2af009abb7f1ca6b0 > Signed-off-by: Raphaël Mélotte <raphael.melotte@mind.be> Committed to 2023.02.x, thanks.
diff --git a/package/python-pymupdf/Config.in b/package/python-pymupdf/Config.in index b3f9565238..ecaa5496b5 100644 --- a/package/python-pymupdf/Config.in +++ b/package/python-pymupdf/Config.in @@ -4,6 +4,7 @@ config BR2_PACKAGE_PYTHON_PYMUPDF depends on BR2_TOOLCHAIN_HAS_SYNC_4 # mupdf -> harfbuzz depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # mupdf -> harfbuzz depends on BR2_PACKAGE_XORG7 + select BR2_PACKAGE_HOST_SWIG select BR2_PACKAGE_FREETYPE select BR2_PACKAGE_MUPDF select BR2_PACKAGE_ZLIB diff --git a/package/python-pymupdf/python-pymupdf.mk b/package/python-pymupdf/python-pymupdf.mk index 70448e8d90..03fc8bc4fb 100644 --- a/package/python-pymupdf/python-pymupdf.mk +++ b/package/python-pymupdf/python-pymupdf.mk @@ -12,7 +12,7 @@ PYTHON_PYMUPDF_SETUP_TYPE = setuptools PYTHON_PYMUPDF_LICENSE = AGPL-3.0+ PYTHON_PYMUPDF_LICENSE_FILES = COPYING # No license file included in pip, but it's present on github -PYTHON_PYMUPDF_DEPENDENCIES = freetype mupdf zlib +PYTHON_PYMUPDF_DEPENDENCIES = freetype host-swig mupdf zlib PYTHON_PYMUPDF_ENV = CFLAGS="-I$(STAGING_DIR)/usr/include/mupdf -I$(STAGING_DIR)/usr/include/freetype2"
It appears that python-pymupdf needs swig when building since mupdf was bumped to 1.18.0 in commit f00da714a20a7826dda67d66f2a6b6ef858ef3e3. This was not noticed before because when building on a machine where swig is already available outside buildroot, it is used and the build succeeds. This fixes the following build failure: swigging fitz/fitz.i to fitz/fitz_wrap.c swig -python -w509 -o fitz/fitz_wrap.c fitz/fitz.i error: command 'swig' failed: No such file or directory make: *** [package/pkg-generic.mk:293: /home/buildroot/autobuild/instance-2/output-1/build/python-pymupdf-1.21.1/.stamp_built] Error 1 Fixes: - http://autobuild.buildroot.net/results/c689a385d984b87b63f3f2ff30338049774b1bf2 - http://autobuild.buildroot.net/results/cf268d3631330a8288fb8ad2af009abb7f1ca6b0 Signed-off-by: Raphaël Mélotte <raphael.melotte@mind.be> --- package/python-pymupdf/Config.in | 1 + package/python-pymupdf/python-pymupdf.mk | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-)