diff mbox series

[v4] package/cutekeyboard: new package

Message ID 20221018151624.882453-1-angelo@amarulasolutions.com
State Accepted
Headers show
Series [v4] package/cutekeyboard: new package | expand

Commit Message

Angelo Compagnucci Oct. 18, 2022, 3:16 p.m. UTC
CuteKeyboard is a Qt virtual keyboard plugin for embedded applications

Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
Acked-by: Andrea Ricchi <andrea.ricchi@amarulasolutions.com>
---
v2:
* bump to verison v1.0.1
v3:
* Adding me to developers file
v4:
* Fixing typo in Config.in

 package/Config.in                      |  1 +
 package/cutekeyboard/Config.in         | 19 +++++++++++++++++++
 package/cutekeyboard/cutekeyboard.hash |  3 +++
 package/cutekeyboard/cutekeyboard.mk   | 18 ++++++++++++++++++
 4 files changed, 41 insertions(+)
 create mode 100644 package/cutekeyboard/Config.in
 create mode 100644 package/cutekeyboard/cutekeyboard.hash
 create mode 100644 package/cutekeyboard/cutekeyboard.mk

Comments

Arnout Vandecappelle Oct. 15, 2023, 6:48 p.m. UTC | #1
Hi Angelo,

  I'm going through some old patches :-)

On 18/10/2022 17:16, Angelo Compagnucci wrote:
> CuteKeyboard is a Qt virtual keyboard plugin for embedded applications
> 
> Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
> Acked-by: Andrea Ricchi <andrea.ricchi@amarulasolutions.com>

  Applied to master, thanks, with some changes, see below.


> ---
> v2:
> * bump to verison v1.0.1
> v3:
> * Adding me to developers file
> v4:
> * Fixing typo in Config.in
> 
>   package/Config.in                      |  1 +
>   package/cutekeyboard/Config.in         | 19 +++++++++++++++++++
>   package/cutekeyboard/cutekeyboard.hash |  3 +++
>   package/cutekeyboard/cutekeyboard.mk   | 18 ++++++++++++++++++

  DEVELOPERS entry missing. I put it under your name - with the gmail address, 
not the Amarula address. If it's not OK, please send a patch to fix it.

>   4 files changed, 41 insertions(+)
>   create mode 100644 package/cutekeyboard/Config.in
>   create mode 100644 package/cutekeyboard/cutekeyboard.hash
>   create mode 100644 package/cutekeyboard/cutekeyboard.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index e3a34d6e97..f11210d313 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1522,6 +1522,7 @@ menu "Graphics"
>   	source "package/cairo/Config.in"
>   	source "package/cairomm/Config.in"
>   	source "package/chipmunk/Config.in"
> +	source "package/cutekeyboard/Config.in"
>   	source "package/exempi/Config.in"
>   	source "package/exiv2/Config.in"
>   	source "package/fltk/Config.in"
> diff --git a/package/cutekeyboard/Config.in b/package/cutekeyboard/Config.in
> new file mode 100644
> index 0000000000..59362f0648
> --- /dev/null
> +++ b/package/cutekeyboard/Config.in
> @@ -0,0 +1,19 @@
> +config BR2_PACKAGE_CUTEKEYBOARD
> +	bool "cutekeyboard"
> +	depends on BR2_PACKAGE_QT5DECLARATIVE
> +	depends on BR2_PACKAGE_QT5DECLARATIVE_QUICK
> +	depends on BR2_PACKAGE_QT5QUICKCONTROLS2

  This should have been select rather than depends. I did leave a depends on Qt5 
itself, of course.

> +	help
> +	  CuteKeyboard is a Qt virtual keyboard plugin for
> +	  embedded applications.

  Just for my information, what differentiates this from qt5virtualkeyboard?

> +
> +	  https://amarula.github.io/cutekeyboard/
> +
> +if BR2_PACKAGE_CUTEKEYBOARD
> +
> +config BR2_PACKAGE_CUTEKEYBOARD_EXAMPLES
> +	bool "cutekeyboard examples"
> +	help
> +	  Compile also application example
> +
> +endif
> diff --git a/package/cutekeyboard/cutekeyboard.hash b/package/cutekeyboard/cutekeyboard.hash
> new file mode 100644
> index 0000000000..3d3ec2f858
> --- /dev/null
> +++ b/package/cutekeyboard/cutekeyboard.hash
> @@ -0,0 +1,3 @@
> +# Locally computed
> +sha256  8cbaddc5fbf479d5e20fc88228e9af5928fa5e588052ee496c2f2efbe2afc510  cutekeyboard-afacc3210b75d7e0de27dcc4c0f2bed0212cc4c7.tar.gz
> +sha256  bdde6ec2ae2686623c0bb414bfb8bd731b314beff2264c602116ea60dd65964d  LICENSE
> diff --git a/package/cutekeyboard/cutekeyboard.mk b/package/cutekeyboard/cutekeyboard.mk
> new file mode 100644
> index 0000000000..3e4c08f44e
> --- /dev/null
> +++ b/package/cutekeyboard/cutekeyboard.mk
> @@ -0,0 +1,18 @@
> +################################################################################
> +#
> +# qt5virtualkeyboard

  cutekeyboard :-)

  Regards,
  Arnout
> +#
> +################################################################################
> +
> +CUTEKEYBOARD_VERSION = afacc3210b75d7e0de27dcc4c0f2bed0212cc4c7
> +CUTEKEYBOARD_SITE = $(call github,amarula,cutekeyboard,$(CUTEKEYBOARD_VERSION))
> +CUTEKEYBOARD_DEPENDENCIES = qt5declarative qt5quickcontrols2
> +CUTEKEYBOARD_INSTALL_STAGING = YES
> +CUTEKEYBOARD_LICENSE = MIT
> +CUTEKEYBOARD_LICENSE_FILES = LICENSE
> +
> +ifeq ($(BR2_PACKAGE_CUTEKEYBOARD_EXAMPLES),y)
> +CUTEKEYBOARD_CONF_OPTS += CONFIG+=BUILD_EXAMPLES

  This installs something called "example" in /usr/bin. Not the most distinctive 
name... I left it like that though.

  Regards,
  Arnout

> +endif
> +
> +$(eval $(qmake-package))
diff mbox series

Patch

diff --git a/package/Config.in b/package/Config.in
index e3a34d6e97..f11210d313 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1522,6 +1522,7 @@  menu "Graphics"
 	source "package/cairo/Config.in"
 	source "package/cairomm/Config.in"
 	source "package/chipmunk/Config.in"
+	source "package/cutekeyboard/Config.in"
 	source "package/exempi/Config.in"
 	source "package/exiv2/Config.in"
 	source "package/fltk/Config.in"
diff --git a/package/cutekeyboard/Config.in b/package/cutekeyboard/Config.in
new file mode 100644
index 0000000000..59362f0648
--- /dev/null
+++ b/package/cutekeyboard/Config.in
@@ -0,0 +1,19 @@ 
+config BR2_PACKAGE_CUTEKEYBOARD
+	bool "cutekeyboard"
+	depends on BR2_PACKAGE_QT5DECLARATIVE
+	depends on BR2_PACKAGE_QT5DECLARATIVE_QUICK
+	depends on BR2_PACKAGE_QT5QUICKCONTROLS2
+	help
+	  CuteKeyboard is a Qt virtual keyboard plugin for
+	  embedded applications.
+
+	  https://amarula.github.io/cutekeyboard/
+
+if BR2_PACKAGE_CUTEKEYBOARD
+
+config BR2_PACKAGE_CUTEKEYBOARD_EXAMPLES
+	bool "cutekeyboard examples"
+	help
+	  Compile also application example
+
+endif
diff --git a/package/cutekeyboard/cutekeyboard.hash b/package/cutekeyboard/cutekeyboard.hash
new file mode 100644
index 0000000000..3d3ec2f858
--- /dev/null
+++ b/package/cutekeyboard/cutekeyboard.hash
@@ -0,0 +1,3 @@ 
+# Locally computed
+sha256  8cbaddc5fbf479d5e20fc88228e9af5928fa5e588052ee496c2f2efbe2afc510  cutekeyboard-afacc3210b75d7e0de27dcc4c0f2bed0212cc4c7.tar.gz
+sha256  bdde6ec2ae2686623c0bb414bfb8bd731b314beff2264c602116ea60dd65964d  LICENSE
diff --git a/package/cutekeyboard/cutekeyboard.mk b/package/cutekeyboard/cutekeyboard.mk
new file mode 100644
index 0000000000..3e4c08f44e
--- /dev/null
+++ b/package/cutekeyboard/cutekeyboard.mk
@@ -0,0 +1,18 @@ 
+################################################################################
+#
+# qt5virtualkeyboard
+#
+################################################################################
+
+CUTEKEYBOARD_VERSION = afacc3210b75d7e0de27dcc4c0f2bed0212cc4c7
+CUTEKEYBOARD_SITE = $(call github,amarula,cutekeyboard,$(CUTEKEYBOARD_VERSION))
+CUTEKEYBOARD_DEPENDENCIES = qt5declarative qt5quickcontrols2
+CUTEKEYBOARD_INSTALL_STAGING = YES
+CUTEKEYBOARD_LICENSE = MIT
+CUTEKEYBOARD_LICENSE_FILES = LICENSE
+
+ifeq ($(BR2_PACKAGE_CUTEKEYBOARD_EXAMPLES),y)
+CUTEKEYBOARD_CONF_OPTS += CONFIG+=BUILD_EXAMPLES
+endif
+
+$(eval $(qmake-package))