| Message ID | 20220726163951.2111731-1-thomas.petazzoni@bootlin.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2,1/4] arch/Config.in.riscv: lp64f ABI is only supported if MMU is enabled | expand |
Thomas, All, On 2022-07-26 18:39 +0200, Thomas Petazzoni via buildroot spake thusly: > Even though that seems weird, the LP64F ABI is only supported when MMU > support is enabled. Indeed, as per commit > 9a51381cedc16e6d70cb85e1144f6e0fa89af69a ("package/uclibc: prevent > config with unsupported RISC-V float ABI"), uClibc does not support > LP64F. But uClibc is the only C library that support RISC-V 64-bit > noMMU. > > So the selection of LP64F and !MMU is impossible. Right now this > selection causes a build failure as no C library is enabled. > > This commit fixes this by ensuring we cannot use LP64F when MMU > support is not available. > > Fixes: > > http://autobuild.buildroot.net/results/6320dcc655f1871eb8bf6a9689bddde7447385f5/ > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> Applied to master, thanks. Regards, Yann E. MORIN. > --- > arch/Config.in.riscv | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/Config.in.riscv b/arch/Config.in.riscv > index 288ed833eb..30bdcaa80b 100644 > --- a/arch/Config.in.riscv > +++ b/arch/Config.in.riscv > @@ -108,6 +108,7 @@ config BR2_RISCV_ABI_LP64 > config BR2_RISCV_ABI_LP64F > bool "lp64f" > depends on BR2_ARCH_IS_64 && BR2_RISCV_ISA_RVF > + depends on BR2_USE_MMU > > config BR2_RISCV_ABI_LP64D > bool "lp64d" > -- > 2.37.1 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes: > Even though that seems weird, the LP64F ABI is only supported when MMU > support is enabled. Indeed, as per commit > 9a51381cedc16e6d70cb85e1144f6e0fa89af69a ("package/uclibc: prevent > config with unsupported RISC-V float ABI"), uClibc does not support > LP64F. But uClibc is the only C library that support RISC-V 64-bit > noMMU. > So the selection of LP64F and !MMU is impossible. Right now this > selection causes a build failure as no C library is enabled. > This commit fixes this by ensuring we cannot use LP64F when MMU > support is not available. > Fixes: > http://autobuild.buildroot.net/results/6320dcc655f1871eb8bf6a9689bddde7447385f5/ > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> Committed to 2022.05.x and 2022.02.x, thanks.
diff --git a/arch/Config.in.riscv b/arch/Config.in.riscv index 288ed833eb..30bdcaa80b 100644 --- a/arch/Config.in.riscv +++ b/arch/Config.in.riscv @@ -108,6 +108,7 @@ config BR2_RISCV_ABI_LP64 config BR2_RISCV_ABI_LP64F bool "lp64f" depends on BR2_ARCH_IS_64 && BR2_RISCV_ISA_RVF + depends on BR2_USE_MMU config BR2_RISCV_ABI_LP64D bool "lp64d"
Even though that seems weird, the LP64F ABI is only supported when MMU support is enabled. Indeed, as per commit 9a51381cedc16e6d70cb85e1144f6e0fa89af69a ("package/uclibc: prevent config with unsupported RISC-V float ABI"), uClibc does not support LP64F. But uClibc is the only C library that support RISC-V 64-bit noMMU. So the selection of LP64F and !MMU is impossible. Right now this selection causes a build failure as no C library is enabled. This commit fixes this by ensuring we cannot use LP64F when MMU support is not available. Fixes: http://autobuild.buildroot.net/results/6320dcc655f1871eb8bf6a9689bddde7447385f5/ Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> --- arch/Config.in.riscv | 1 + 1 file changed, 1 insertion(+)