diff mbox series

[v2] package/libdill: new package

Message ID 20220326220727.827332-1-angelo@amarulasolutions.com
State Superseded
Headers show
Series [v2] package/libdill: new package | expand

Commit Message

Angelo Compagnucci March 26, 2022, 10:07 p.m. UTC 
Libdill is a C library that makes writing structured concurrent programs
easy.

Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
---
v1-v2:
Better configuration options handling:
libdill build can actually be customized only when using configure
indeed cmake doesn't offer the same configuration option,

 DEVELOPERS                   |  1 +
 package/Config.in            |  1 +
 package/libdill/Config.in    |  7 +++++++
 package/libdill/libdill.hash |  3 +++
 package/libdill/libdill.mk   | 25 +++++++++++++++++++++++++
 5 files changed, 37 insertions(+)
 create mode 100644 package/libdill/Config.in
 create mode 100644 package/libdill/libdill.hash
 create mode 100644 package/libdill/libdill.mk

Comments

Romain Naour July 26, 2022, 9:49 p.m. UTC | #1 
Hello Angelo,

Le 26/03/2022 à 23:07, Angelo Compagnucci a écrit :
> Libdill is a C library that makes writing structured concurrent programs
> easy.
> 
> Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
> ---
> v1-v2:
> Better configuration options handling:
> libdill build can actually be customized only when using configure
> indeed cmake doesn't offer the same configuration option,
> 
>  DEVELOPERS                   |  1 +
>  package/Config.in            |  1 +
>  package/libdill/Config.in    |  7 +++++++
>  package/libdill/libdill.hash |  3 +++
>  package/libdill/libdill.mk   | 25 +++++++++++++++++++++++++
>  5 files changed, 37 insertions(+)
>  create mode 100644 package/libdill/Config.in
>  create mode 100644 package/libdill/libdill.hash
>  create mode 100644 package/libdill/libdill.mk
> 
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 70d71186ed..9410944584 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -167,6 +167,7 @@ F:	package/i2c-tools/
>  F:	package/jq/
>  F:	package/libapparmor/
>  F:	package/libb64/
> +F:	package/libdill/
>  F:	package/mender/
>  F:	package/mender-artifact/
>  F:	package/mono/
> diff --git a/package/Config.in b/package/Config.in
> index 0d5d763180..47f84a08dc 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1968,6 +1968,7 @@ menu "Other"
>  	source "package/libcrossguid/Config.in"
>  	source "package/libcsv/Config.in"
>  	source "package/libdaemon/Config.in"
> +	source "package/libdill/Config.in"
>  	source "package/libeastl/Config.in"
>  	source "package/libee/Config.in"
>  	source "package/libev/Config.in"
> diff --git a/package/libdill/Config.in b/package/libdill/Config.in
> new file mode 100644
> index 0000000000..0e6757b809
> --- /dev/null
> +++ b/package/libdill/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_LIBDILL

Have you checked with test-pkg ?

> +	bool "libdill"
> +	help
> +	  Libdill is a C library that makes writing structured concurrent
> +	  programs easy.
> +
> +	  http://libdill.org
> diff --git a/package/libdill/libdill.hash b/package/libdill/libdill.hash
> new file mode 100644
> index 0000000000..4a1fb91a57
> --- /dev/null
> +++ b/package/libdill/libdill.hash
> @@ -0,0 +1,3 @@
> +# sha256 locally computed
> +sha256  6df7527e8f1e91f5106c21c5bfeaa69eee470bec476c74585143e3e439864404  libdill-fa01648cf2a8d06e53c965b45eeacfb3ac57bd04.tar.gz
> +sha256  3f78d9c42c8919cb6dc63e51de17b9eb40a49d9cdd876ce59e77392721e8c2c6  COPYING
> diff --git a/package/libdill/libdill.mk b/package/libdill/libdill.mk
> new file mode 100644
> index 0000000000..8efe1ff356
> --- /dev/null
> +++ b/package/libdill/libdill.mk
> @@ -0,0 +1,25 @@
> +################################################################################
> +#
> +# libdill
> +#
> +################################################################################
> +
> +LIBDILL_VERSION = fa01648cf2a8d06e53c965b45eeacfb3ac57bd04
> +LIBDILL_SITE = $(call github,sustrik,libdill,$(LIBDILL_VERSION))
> +LIBDILL_LICENSE = MIT
> +LIBDILL_LICENSE_FILES = COPYING
> +LIBDILL_CPE_ID_VENDOR = libdill
> +LIBDILL_CPE_ID_PRODUCT = libdill
> +LIBDILL_INSTALL_STAGING = YES
> +LIBDILL_AUTORECONF = YES

Usually we requires a comment to remember why autoreconf is needed.
Here it's directly fetched from github and we need autoreconf to generate the
configure script.

> +
> +ifneq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
> +LIBDILL_CONF_OPTS += --disable-threads
> +endif
> +
> +ifeq ($(BR2_PACKAGE_OPENSSL),y)
> +LIBDILL_DEPENDENCIES = openssl

Openssl is a virtual package. Did you check with other ssl provided such libressl ?

Best regards,
Romain


> +LIBDILL_CONF_OPTS += --enable-tls
> +endif
> +
> +$(eval $(autotools-package))
Angelo Compagnucci July 28, 2022, 9:11 p.m. UTC | #2 
Il giorno mar 26 lug 2022 alle ore 23:49 Romain Naour
<romain.naour@smile.fr> ha scritto:
>
> Hello Angelo,
>
> Le 26/03/2022 à 23:07, Angelo Compagnucci a écrit :
> > Libdill is a C library that makes writing structured concurrent programs
> > easy.
> >
> > Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
> > ---
> > v1-v2:
> > Better configuration options handling:
> > libdill build can actually be customized only when using configure
> > indeed cmake doesn't offer the same configuration option,
> >
> >  DEVELOPERS                   |  1 +
> >  package/Config.in            |  1 +
> >  package/libdill/Config.in    |  7 +++++++
> >  package/libdill/libdill.hash |  3 +++
> >  package/libdill/libdill.mk   | 25 +++++++++++++++++++++++++
> >  5 files changed, 37 insertions(+)
> >  create mode 100644 package/libdill/Config.in
> >  create mode 100644 package/libdill/libdill.hash
> >  create mode 100644 package/libdill/libdill.mk
> >
> > diff --git a/DEVELOPERS b/DEVELOPERS
> > index 70d71186ed..9410944584 100644
> > --- a/DEVELOPERS
> > +++ b/DEVELOPERS
> > @@ -167,6 +167,7 @@ F:        package/i2c-tools/
> >  F:   package/jq/
> >  F:   package/libapparmor/
> >  F:   package/libb64/
> > +F:   package/libdill/
> >  F:   package/mender/
> >  F:   package/mender-artifact/
> >  F:   package/mono/
> > diff --git a/package/Config.in b/package/Config.in
> > index 0d5d763180..47f84a08dc 100644
> > --- a/package/Config.in
> > +++ b/package/Config.in
> > @@ -1968,6 +1968,7 @@ menu "Other"
> >       source "package/libcrossguid/Config.in"
> >       source "package/libcsv/Config.in"
> >       source "package/libdaemon/Config.in"
> > +     source "package/libdill/Config.in"
> >       source "package/libeastl/Config.in"
> >       source "package/libee/Config.in"
> >       source "package/libev/Config.in"
> > diff --git a/package/libdill/Config.in b/package/libdill/Config.in
> > new file mode 100644
> > index 0000000000..0e6757b809
> > --- /dev/null
> > +++ b/package/libdill/Config.in
> > @@ -0,0 +1,7 @@
> > +config BR2_PACKAGE_LIBDILL
>
> Have you checked with test-pkg ?

Not really, I tested it with some configuration I'm working with. I'll
do a run with test-pkg too.

>
> > +     bool "libdill"
> > +     help
> > +       Libdill is a C library that makes writing structured concurrent
> > +       programs easy.
> > +
> > +       http://libdill.org
> > diff --git a/package/libdill/libdill.hash b/package/libdill/libdill.hash
> > new file mode 100644
> > index 0000000000..4a1fb91a57
> > --- /dev/null
> > +++ b/package/libdill/libdill.hash
> > @@ -0,0 +1,3 @@
> > +# sha256 locally computed
> > +sha256  6df7527e8f1e91f5106c21c5bfeaa69eee470bec476c74585143e3e439864404  libdill-fa01648cf2a8d06e53c965b45eeacfb3ac57bd04.tar.gz
> > +sha256  3f78d9c42c8919cb6dc63e51de17b9eb40a49d9cdd876ce59e77392721e8c2c6  COPYING
> > diff --git a/package/libdill/libdill.mk b/package/libdill/libdill.mk
> > new file mode 100644
> > index 0000000000..8efe1ff356
> > --- /dev/null
> > +++ b/package/libdill/libdill.mk
> > @@ -0,0 +1,25 @@
> > +################################################################################
> > +#
> > +# libdill
> > +#
> > +################################################################################
> > +
> > +LIBDILL_VERSION = fa01648cf2a8d06e53c965b45eeacfb3ac57bd04
> > +LIBDILL_SITE = $(call github,sustrik,libdill,$(LIBDILL_VERSION))
> > +LIBDILL_LICENSE = MIT
> > +LIBDILL_LICENSE_FILES = COPYING
> > +LIBDILL_CPE_ID_VENDOR = libdill
> > +LIBDILL_CPE_ID_PRODUCT = libdill
> > +LIBDILL_INSTALL_STAGING = YES
> > +LIBDILL_AUTORECONF = YES
>
> Usually we requires a comment to remember why autoreconf is needed.
> Here it's directly fetched from github and we need autoreconf to generate the
> configure script.

I'll add to V2

>
> > +
> > +ifneq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
> > +LIBDILL_CONF_OPTS += --disable-threads
> > +endif
> > +
> > +ifeq ($(BR2_PACKAGE_OPENSSL),y)
> > +LIBDILL_DEPENDENCIES = openssl
>
> Openssl is a virtual package. Did you check with other ssl provided such libressl ?

Yes and it work with both open/libressl

>
> Best regards,
> Romain
>
>
> > +LIBDILL_CONF_OPTS += --enable-tls
> > +endif
> > +
> > +$(eval $(autotools-package))
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
diff mbox series

Patch

diff --git a/DEVELOPERS b/DEVELOPERS
index 70d71186ed..9410944584 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -167,6 +167,7 @@  F:	package/i2c-tools/
 F:	package/jq/
 F:	package/libapparmor/
 F:	package/libb64/
+F:	package/libdill/
 F:	package/mender/
 F:	package/mender-artifact/
 F:	package/mono/
diff --git a/package/Config.in b/package/Config.in
index 0d5d763180..47f84a08dc 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1968,6 +1968,7 @@  menu "Other"
 	source "package/libcrossguid/Config.in"
 	source "package/libcsv/Config.in"
 	source "package/libdaemon/Config.in"
+	source "package/libdill/Config.in"
 	source "package/libeastl/Config.in"
 	source "package/libee/Config.in"
 	source "package/libev/Config.in"
diff --git a/package/libdill/Config.in b/package/libdill/Config.in
new file mode 100644
index 0000000000..0e6757b809
--- /dev/null
+++ b/package/libdill/Config.in
@@ -0,0 +1,7 @@ 
+config BR2_PACKAGE_LIBDILL
+	bool "libdill"
+	help
+	  Libdill is a C library that makes writing structured concurrent
+	  programs easy.
+
+	  http://libdill.org
diff --git a/package/libdill/libdill.hash b/package/libdill/libdill.hash
new file mode 100644
index 0000000000..4a1fb91a57
--- /dev/null
+++ b/package/libdill/libdill.hash
@@ -0,0 +1,3 @@ 
+# sha256 locally computed
+sha256  6df7527e8f1e91f5106c21c5bfeaa69eee470bec476c74585143e3e439864404  libdill-fa01648cf2a8d06e53c965b45eeacfb3ac57bd04.tar.gz
+sha256  3f78d9c42c8919cb6dc63e51de17b9eb40a49d9cdd876ce59e77392721e8c2c6  COPYING
diff --git a/package/libdill/libdill.mk b/package/libdill/libdill.mk
new file mode 100644
index 0000000000..8efe1ff356
--- /dev/null
+++ b/package/libdill/libdill.mk
@@ -0,0 +1,25 @@ 
+################################################################################
+#
+# libdill
+#
+################################################################################
+
+LIBDILL_VERSION = fa01648cf2a8d06e53c965b45eeacfb3ac57bd04
+LIBDILL_SITE = $(call github,sustrik,libdill,$(LIBDILL_VERSION))
+LIBDILL_LICENSE = MIT
+LIBDILL_LICENSE_FILES = COPYING
+LIBDILL_CPE_ID_VENDOR = libdill
+LIBDILL_CPE_ID_PRODUCT = libdill
+LIBDILL_INSTALL_STAGING = YES
+LIBDILL_AUTORECONF = YES
+
+ifneq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
+LIBDILL_CONF_OPTS += --disable-threads
+endif
+
+ifeq ($(BR2_PACKAGE_OPENSSL),y)
+LIBDILL_DEPENDENCIES = openssl
+LIBDILL_CONF_OPTS += --enable-tls
+endif
+
+$(eval $(autotools-package))