From patchwork Thu Apr 1 12:04:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Ziegler X-Patchwork-Id: 1461005 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FB23Y0bp0z9sVq for ; Thu, 1 Apr 2021 23:06:47 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 0803860BBE; Thu, 1 Apr 2021 12:06:41 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UcyDCMyMB6mk; Thu, 1 Apr 2021 12:06:40 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 47D6360BB6; Thu, 1 Apr 2021 12:06:39 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 5D59D1BF852 for ; Thu, 1 Apr 2021 12:06:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 4C7F060BB6 for ; Thu, 1 Apr 2021 12:06:37 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Tho8n4XRP46A for ; Thu, 1 Apr 2021 12:06:36 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from serv15.avernis.de (serv15.avernis.de [176.9.89.163]) by smtp3.osuosl.org (Postfix) with ESMTPS id 1315C606DB for ; Thu, 1 Apr 2021 12:06:35 +0000 (UTC) Received: from localhost.localdomain (unknown [151.36.165.77]) by serv15.avernis.de (Postfix) with ESMTPSA id E678BCBE3D5E; Thu, 1 Apr 2021 14:04:57 +0200 (CEST) From: Andreas Ziegler To: buildroot@buildroot.org Date: Thu, 1 Apr 2021 14:04:12 +0200 Message-Id: <20210401120412.232714-1-br015@umbiko.net> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210329184503.10514-1-ps.report@gmx.net> References: <20210329184503.10514-1-ps.report@gmx.net> MIME-Version: 1.0 X-Virus-Scanned: clamav-milter 0.102.4 at serv15.avernis.de X-Virus-Status: Clean Subject: [Buildroot] [PATCH v2 1/1] package/rpi-wifi-firmware: provide board specific links to firmware configuration files for BCM43430 and BCM43455 based Raspberry Pi models X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andreas Ziegler , Peter Seiderer , Martin Bark Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" The Broadcom FMAC firmware loader in the current Linux kernel branch (5.x.y), when loading NVRAM files, tries to load a board specific file first. If that fails, the standard file name is used. The package rpi-wifi-firmware does not provide these board specific files; this results in unneccesary warning messages in the kernel log: (RPi3B+): brcmfmac mmc1:0001:1: Direct firmware load for brcm/brcmfmac43455-sdio.raspberrypi,3-model-b-plus.txt failed with error -2 (RPi4B): brcmfmac mmc1:0001:1: Direct firmware load for brcm/brcmfmac43455-sdio.raspberrypi,4-model-b.txt failed with error -2 (RPi0W): brcmfmac mmc1:0001:1: Direct firmware load for brcm/brcmfmac43430-sdio.raspberrypi,model-zero-w.txt failed with error -2 (RPi3B): This was found to be present in linux-firmware [1] and Ubuntu 20.04.2 [2] [1] https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git [2] https://ubuntu.com/download/raspberry-pi This patch provides links for BCM43430 and BCM43455 based Raspberry Pi models, to avoid the observed firmware load failure messages in the kernel log. Signed-off-by: Peter Seiderer Changes v1 -> v2: - added links for brcmfmac43430 based RPi0W and RPi3B Signed-off-by: Andreas Ziegler --- package/rpi-wifi-firmware/rpi-wifi-firmware.mk | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/package/rpi-wifi-firmware/rpi-wifi-firmware.mk b/package/rpi-wifi-firmware/rpi-wifi-firmware.mk index 24ba5941b0..f98fc4cd68 100644 --- a/package/rpi-wifi-firmware/rpi-wifi-firmware.mk +++ b/package/rpi-wifi-firmware/rpi-wifi-firmware.mk @@ -12,6 +12,11 @@ RPI_WIFI_FIRMWARE_LICENSE_FILES = LICENCE.broadcom_bcm43xx define RPI_WIFI_FIRMWARE_INSTALL_TARGET_CMDS $(INSTALL) -d $(TARGET_DIR)/lib/firmware/brcm $(INSTALL) -m 0644 $(@D)/firmware/brcm/brcmfmac* $(TARGET_DIR)/lib/firmware/brcm -endef + ln -sf brcmfmac43430-sdio.txt $(TARGET_DIR)/lib/firmware/brcm/brcmfmac43430-sdio.raspberrypi,model-zero-w.txt + ln -sf brcmfmac43430-sdio.txt $(TARGET_DIR)/lib/firmware/brcm/brcmfmac43430-sdio.raspberrypi,3-model-b.txt + ln -sf brcmfmac43455-sdio.txt $(TARGET_DIR)/lib/firmware/brcm/brcmfmac43455-sdio.raspberrypi,3-model-a-plus.txt + ln -sf brcmfmac43455-sdio.txt $(TARGET_DIR)/lib/firmware/brcm/brcmfmac43455-sdio.raspberrypi,3-model-b-plus.txt + ln -sf brcmfmac43455-sdio.txt $(TARGET_DIR)/lib/firmware/brcm/brcmfmac43455-sdio.raspberrypi,4-model-b.txt + endef $(eval $(generic-package))