From patchwork Wed Feb 17 07:39:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?J=C3=B6rg_Krause?= X-Patchwork-Id: 1441187 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="key not found in DNS" header.d=embedded.rocks header.i=@embedded.rocks header.a=rsa-sha256 header.s=default header.b=CaPZ8n3A; dkim-atps=neutral Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DgV9220dJz9sBy for ; Wed, 17 Feb 2021 18:39:34 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 2E2E283F1D; Wed, 17 Feb 2021 07:39:32 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0_n1UGxSyMt9; Wed, 17 Feb 2021 07:39:31 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id ED091835BC; Wed, 17 Feb 2021 07:39:30 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 6587C1BF354 for ; Wed, 17 Feb 2021 07:39:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 6202586FEF for ; Wed, 17 Feb 2021 07:39:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Fb4IDrdesgZB for ; Wed, 17 Feb 2021 07:39:28 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.141]) by hemlock.osuosl.org (Postfix) with ESMTPS id BA8F186FEB for ; Wed, 17 Feb 2021 07:39:27 +0000 (UTC) Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id C98B216005C for ; Wed, 17 Feb 2021 08:39:24 +0100 (CET) Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4DgV8q71HDz6tmH for ; Wed, 17 Feb 2021 08:39:23 +0100 (CET) Authentication-Results: mail.embedded.rocks (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=embedded.rocks DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embedded.rocks; h=content-transfer-encoding:content-type:content-type :mime-version:x-mailer:message-id:date:date:subject:subject:from :from:received:received; s=default; t=1613547561; x=1614152362; bh=eDblb3sZZJebUBA1JtgAa5sCiYXq+gH1UeISuIOzJVs=; b=CaPZ8n3AzFJK jv2jRdFn4V25U0C2lfvHcCPih/qU6W8xB2dclM/sbwZGy0z0Bz6lpUs67skfFe/m mzfyxsQR/TpIfcfmqqihHniQGHnn/RYGp9ZgkiTDBckxv4a2jfhoF187X1euQ5K2 MnNidKpo+q6tcGH2ny8iRjOnCV4cFHR26x/TP2qERZuKavkq7mNscKokW92HCPkM IMnw61vhVHQH+yAo5HMv3SQAcY6wraAcO2tfgbBBrnzRTHuXtJpLia1yD0Chci0N 94osqknWdxn3ZcJNsYxeouDnhiOO1E/pRquxUkOpJwDS3xzeUYUw1/cuFJDbbu9y HcL6u6z+cg== Received: from mail.embedded.rocks ([127.0.0.1]) by localhost (mail.embedded.rocks [127.0.0.1]) (amavisd-new, port 10025) with ESMTP id HWinnLDqTIWs; Wed, 17 Feb 2021 08:39:21 +0100 (CET) Received: from nzxt.localdomain (business-176-095-158-210.static.arcor-ip.net [176.95.158.210]) (Authenticated sender: joerg.krause@embedded.rocks) by mail.embedded.rocks (Postfix) with ESMTPSA; Wed, 17 Feb 2021 08:39:21 +0100 (CET) From: =?utf-8?q?J=C3=B6rg_Krause?= To: buildroot@buildroot.org Date: Wed, 17 Feb 2021 08:39:12 +0100 Message-Id: <20210217073912.19314-1-joerg.krause@embedded.rocks> X-Mailer: git-send-email 2.30.1 MIME-Version: 1.0 Subject: [Buildroot] [PATCH 1/1] package/taglib: drop config options to enable MP4/ASF support X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Both options where removed in TagLib in [1] back in year 2011. [1] https://github.com/taglib/taglib/commit/dd846904cbc1ef3ee628d77f0c9df88ef8967816 Signed-off-by: Jörg Krause --- Config.in.legacy | 12 ++++++++++++ package/taglib/Config.in | 10 ---------- package/taglib/taglib.mk | 8 -------- 3 files changed, 12 insertions(+), 18 deletions(-) diff --git a/Config.in.legacy b/Config.in.legacy index 9deb67b31f..9c794877d4 100644 --- a/Config.in.legacy +++ b/Config.in.legacy @@ -146,6 +146,18 @@ endif comment "Legacy options removed in 2021.02" +config BR2_PACKAGE_TAGLIB_MP4 + bool "taglib mp4 support" + select BR2_LEGACY + help + mp4 support is enabled in TagLib by default since 2011. + +config BR2_PACKAGE_TAGLIB_ASF + "taglib wma support" + select BR2_LEGACY + help + asf/wma support is enabled in TagLib by default since 2011. + config BR2_PACKAGE_MPD_AUDIOFILE bool "mpd audiofile support removed" select BR2_LEGACY diff --git a/package/taglib/Config.in b/package/taglib/Config.in index 9e6bb707fc..6a87a13215 100644 --- a/package/taglib/Config.in +++ b/package/taglib/Config.in @@ -11,15 +11,5 @@ config BR2_PACKAGE_TAGLIB http://taglib.org/ -if BR2_PACKAGE_TAGLIB - -config BR2_PACKAGE_TAGLIB_MP4 - bool "taglib mp4 support" - -config BR2_PACKAGE_TAGLIB_ASF - bool "taglib wma support" - -endif - comment "taglib needs a toolchain w/ C++, wchar" depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR diff --git a/package/taglib/taglib.mk b/package/taglib/taglib.mk index 9381e16672..738be35756 100644 --- a/package/taglib/taglib.mk +++ b/package/taglib/taglib.mk @@ -20,14 +20,6 @@ ifeq ($(BR2_PACKAGE_ZLIB),y) TAGLIB_DEPENDENCIES += zlib endif -ifeq ($(BR2_PACKAGE_TAGLIB_ASF),y) -TAGLIB_CONF_OPTS += -DWITH_ASF=ON -endif - -ifeq ($(BR2_PACKAGE_TAGLIB_MP4),y) -TAGLIB_CONF_OPTS += -DWITH_MP4=ON -endif - define TAGLIB_REMOVE_DEVFILE rm -f $(TARGET_DIR)/usr/bin/taglib-config endef