diff mbox series

[v2] package/netsnmp: unix domain socket transport

Message ID 20200414175500.28891-1-matthew.weber@rockwellcollins.com
State Accepted
Headers show
Series [v2] package/netsnmp: unix domain socket transport | expand

Commit Message

Matt Weber April 14, 2020, 5:55 p.m. UTC 
From: Ryan Steffens <ryan.steffens@rockwellcollins.com>

Adds support for connecting unix socket based AgentX subagents

Signed-off-by: Ryan Steffens <ryan.steffens@rockwellcollins.com>
Signed-off-by: Clayton Shotwell <clayton.shotwell@rockwellcollins.com>
Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com>
---
Changes v1 -> v2
 - (Thomas) Added a commit message about why
---
 package/netsnmp/netsnmp.mk | 1 -
 1 file changed, 1 deletion(-)

Comments

Thomas Petazzoni April 18, 2020, 4:22 p.m. UTC | #1 
On Tue, 14 Apr 2020 12:55:00 -0500
Matt Weber <matthew.weber@rockwellcollins.com> wrote:

> From: Ryan Steffens <ryan.steffens@rockwellcollins.com>
> 
> Adds support for connecting unix socket based AgentX subagents
> 
> Signed-off-by: Ryan Steffens <ryan.steffens@rockwellcollins.com>
> Signed-off-by: Clayton Shotwell <clayton.shotwell@rockwellcollins.com>
> Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com>

I have further extended the commit log, and applied. Especially, it is
always useful to go back in the history of the package and try to
figure out the reason why something was done in a given way, and now
needs to be done differently.

Thanks!

Thomas
Peter Korsgaard May 6, 2020, 5:30 a.m. UTC | #2 
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > On Tue, 14 Apr 2020 12:55:00 -0500
 > Matt Weber <matthew.weber@rockwellcollins.com> wrote:

 >> From: Ryan Steffens <ryan.steffens@rockwellcollins.com>
 >> 
 >> Adds support for connecting unix socket based AgentX subagents
 >> 
 >> Signed-off-by: Ryan Steffens <ryan.steffens@rockwellcollins.com>
 >> Signed-off-by: Clayton Shotwell <clayton.shotwell@rockwellcollins.com>
 >> Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com>

 > I have further extended the commit log, and applied. Especially, it is
 > always useful to go back in the history of the package and try to
 > figure out the reason why something was done in a given way, and now
 > needs to be done differently.

Committed to 2020.02.x, thanks.
diff mbox series

Patch

diff --git a/package/netsnmp/netsnmp.mk b/package/netsnmp/netsnmp.mk
index ed573c51e3..904279d1fb 100644
--- a/package/netsnmp/netsnmp.mk
+++ b/package/netsnmp/netsnmp.mk
@@ -30,7 +30,6 @@  NETSNMP_CONF_OPTS = \
 	--with-sys-location="Unknown" \
 	--with-mib-modules="$(call qstrip,$(BR2_PACKAGE_NETSNMP_WITH_MIB_MODULES))" \
 	--with-out-mib-modules="$(call qstrip,$(BR2_PACKAGE_NETSNMP_WITHOUT_MIB_MODULES))" \
-	--with-out-transports="Unix" \
 	--disable-manuals
 NETSNMP_INSTALL_STAGING_OPTS = DESTDIR=$(STAGING_DIR) LIB_LDCONFIG_CMD=true install
 NETSNMP_INSTALL_TARGET_OPTS = DESTDIR=$(TARGET_DIR) LIB_LDCONFIG_CMD=true install