diff mbox series

[next] utils/scanpypi: remind developer about updating DEVELOPERS and Config.in

Message ID 20191119171527.18570-1-matthew.weber@rockwellcollins.com
State Accepted
Headers show
Series [next] utils/scanpypi: remind developer about updating DEVELOPERS and Config.in | expand

Commit Message

Matt Weber Nov. 19, 2019, 5:15 p.m. UTC
Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
---
 utils/scanpypi | 2 ++
 1 file changed, 2 insertions(+)

Comments

Bartosz Bilas Nov. 19, 2019, 5:46 p.m. UTC | #1
Hi Matt,

On 2019-11-19 18:15, Matt Weber wrote:
> Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
> ---
> utils/scanpypi | 2 ++
> 1 file changed, 2 insertions(+)
> 
> diff --git a/utils/scanpypi b/utils/scanpypi
> index 55b3d1e61c..abb190a536 100755
> --- a/utils/scanpypi
> +++ b/utils/scanpypi
> @@ -739,6 +739,8 @@ def main():
> package.create_hash_file()
> 
> package.create_config_in()
> +            print("NOTE: Remember to also make an update to the
> DEVELOPERS file")
> +            print("      and include an entry for the pkg in
> packages/Config.in")
> print()
> # printing an empty line for visual confort
> finally:

why wouldn't we do that automatically? ;) We shouldn't have much trouble 
with that.

Best
Bartek
Thomas Petazzoni Dec. 26, 2019, 8:38 a.m. UTC | #2
On Tue, 19 Nov 2019 11:15:27 -0600
Matt Weber <matthew.weber@rockwellcollins.com> wrote:

> Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
> ---
>  utils/scanpypi | 2 ++
>  1 file changed, 2 insertions(+)

Applied to master, thanks. As Bartek replied to your patch, it would
however be nice if scanpypi would do this automatically, but that's for
a future improvement.

Thanks!

Thomas
Peter Korsgaard Jan. 7, 2020, 9:27 p.m. UTC | #3
>>>>> "Matt" == Matt Weber <matthew.weber@rockwellcollins.com> writes:

 > Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>

Committed to 2019.02.x and 2019.11.x, thanks.
diff mbox series

Patch

diff --git a/utils/scanpypi b/utils/scanpypi
index 55b3d1e61c..abb190a536 100755
--- a/utils/scanpypi
+++ b/utils/scanpypi
@@ -739,6 +739,8 @@  def main():
             package.create_hash_file()
 
             package.create_config_in()
+            print("NOTE: Remember to also make an update to the DEVELOPERS file")
+            print("      and include an entry for the pkg in packages/Config.in")
             print()
             # printing an empty line for visual confort
     finally: