From patchwork Sat Nov 16 13:49:38 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Avi Shukron X-Patchwork-Id: 1196120 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=140.211.166.136; helo=silver.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="l1u02Cx+"; dkim-atps=neutral Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 47Fc7q6TTCz9s4Y for ; Sun, 17 Nov 2019 00:51:17 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 8E0DE203C4; Sat, 16 Nov 2019 13:51:11 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JrSk-d9rtQP6; Sat, 16 Nov 2019 13:51:09 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 3125C20491; Sat, 16 Nov 2019 13:51:09 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 2C2051BF83E for ; Sat, 16 Nov 2019 13:51:08 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 217B420491 for ; Sat, 16 Nov 2019 13:51:08 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XKrZUdN+Ln+O for ; Sat, 16 Nov 2019 13:51:07 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by silver.osuosl.org (Postfix) with ESMTPS id 2496E203C4 for ; Sat, 16 Nov 2019 13:51:07 +0000 (UTC) Received: by mail-wr1-f50.google.com with SMTP id b3so13964833wrs.13 for ; Sat, 16 Nov 2019 05:51:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=F+Dc1BRmOnMdHsXq1vHCS0luYSn6WoTtT33Q7+waLXU=; b=l1u02Cx+JGfw2gNw+NyVCYvsznfrGgBarwTLZxue/G3lhx3SJn9Bnp6AIKE/cEI6zh bwqFCQfNTGmiSoNcW1VQYyGtSDeHC+PcQD/OKC1wT5DC7p+aNRCsKtQiA8G5G+AWaMfP 9Npj6Gerrj/hRytFeU6p+L0Ie6Zmvj+r5plQuV4yvxBvPW7QxYNbdpvxnwZrB1G+hBmH 6IQBKIvn6C2OCEeM8S3hLH8tZ33tXNBluzkwDEtpFZv2kWg+A6/KfXaXRuqrV2Xpfr4a iRQWGuUyj/Eqczr3GeS/J+DQq5a8ZMK4r3pgihCwg3m9B07XLIhGGXHpcrxNkwdbTy5h 8+lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=F+Dc1BRmOnMdHsXq1vHCS0luYSn6WoTtT33Q7+waLXU=; b=TD7xFouXYOgNywscwAPXsEKjrtv8++gBoNC11+BkeXsQTnNhWaQfpn2hXq7keD2qQZ c2eUaGruA59hQ2sF0wF4fQK+at26CuxgmqOTr9tXjRUrmqWxpR3CtX/DWskjUHpYtJGh 3XNLmMK0FXJLvnlkIi6+UFBsG1NFau50LvLnIuEJqY/1ztbFjX/95LkXBfbDm6KCeMAJ 8Z1knApllmU8K2IUjgpnZehcQYqKF4bgoFNlLavOd0PDDhkGHLV6+tAxR79upvOpAzGp c2oSSySsHskYK0mKwV0YdkET9eeVZRF3BxHzXAceWhZm5zxUmUWgx3u3nbPE7NGLEJIs Otrg== X-Gm-Message-State: APjAAAWoWgPM1WzC6eZZ2Rd/8T7KxMRKqVE4mzZbTsqQA8Se6u3+6e1c sBbjZfMFIVlV8jBIrvpuRUVN2u/YWGA= X-Google-Smtp-Source: APXvYqyQqXq7KMZfuVaDsAMncI0N3TqeASWCwMUjxrPw7lpODZ/4nqHHFO7DGIdYyPqiMd2wFRV5Pg== X-Received: by 2002:adf:ed4b:: with SMTP id u11mr19486969wro.215.1573912264905; Sat, 16 Nov 2019 05:51:04 -0800 (PST) Received: from localhost.localdomain (93-173-232-205.bb.netvision.net.il. [93.173.232.205]) by smtp.gmail.com with ESMTPSA id x8sm15460877wrm.7.2019.11.16.05.51.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Nov 2019 05:51:04 -0800 (PST) From: Avi Shukron To: buildroot@buildroot.org Date: Sat, 16 Nov 2019 15:49:38 +0200 Message-Id: <20191116134951.25508-1-avraham.shukron@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: Subject: [Buildroot] [PATCH v4] package/qemu: add host-python3 as an explicit dependency X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Avi Shukron MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" qemu requires python in its configre script. Yet host-python was not listed as one of the package's dependencies. If no other package requested host-python, then configuring this package will fail since it won't find any executable named python in the host dir. In order to reproduce this issue you must not have python2 installed on your host machine. Signed-off-by: Avi Shukron --- Changes v2->v3: - Depend directly on host-python3, since it is already a transitive dependency of qemu Changes v3->v4: - Pass python3 explicitly to the configure script --- package/qemu/qemu.mk | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/package/qemu/qemu.mk b/package/qemu/qemu.mk index a91f9d3eeb..283577d749 100644 --- a/package/qemu/qemu.mk +++ b/package/qemu/qemu.mk @@ -20,8 +20,7 @@ QEMU_LICENSE_FILES = COPYING COPYING.LIB #------------------------------------------------------------- # Target-qemu - -QEMU_DEPENDENCIES = host-pkgconf libglib2 zlib pixman +QEMU_DEPENDENCIES = host-pkgconf libglib2 zlib pixman host-python3 # Need the LIBS variable because librt and libm are # not automatically pulled. :-( @@ -132,6 +131,7 @@ define QEMU_CONFIGURE_CMDS --prefix=/usr \ --cross-prefix=$(TARGET_CROSS) \ --audio-drv-list= \ + --python=$(HOST_DIR)/bin/python3 \ --enable-kvm \ --enable-attr \ --enable-vhost-net \ @@ -182,7 +182,7 @@ $(eval $(generic-package)) #------------------------------------------------------------- # Host-qemu -HOST_QEMU_DEPENDENCIES = host-pkgconf host-zlib host-libglib2 host-pixman +HOST_QEMU_DEPENDENCIES = host-pkgconf host-zlib host-libglib2 host-pixman host-python3 # BR ARCH qemu # ------- ---- @@ -299,6 +299,7 @@ define HOST_QEMU_CONFIGURE_CMDS --host-cc="$(HOSTCC)" \ --extra-cflags="$(HOST_CFLAGS)" \ --extra-ldflags="$(HOST_LDFLAGS)" \ + --python=$(HOST_DIR)/bin/python3 \ $(HOST_QEMU_OPTS) endef