From patchwork Mon Nov 11 20:03:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Avi Shukron X-Patchwork-Id: 1193106 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=140.211.166.138; helo=whitealder.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="XzzUnALk"; dkim-atps=neutral Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 47Bhg62CCxz9s4Y for ; Tue, 12 Nov 2019 07:04:50 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 27EDE8475D; Mon, 11 Nov 2019 20:04:48 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jYtOVnONEMZ9; Mon, 11 Nov 2019 20:04:47 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 4E39E826E0; Mon, 11 Nov 2019 20:04:47 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 6536C1BF337 for ; Mon, 11 Nov 2019 20:04:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 5F5658441F for ; Mon, 11 Nov 2019 20:04:46 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JIH7PwMyjmif for ; Mon, 11 Nov 2019 20:04:44 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 041EA84409 for ; Mon, 11 Nov 2019 20:04:44 +0000 (UTC) Received: by mail-wm1-f66.google.com with SMTP id f3so575132wmc.5 for ; Mon, 11 Nov 2019 12:04:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=aIfA9wbCfiBiUBGcrU/yY6Uy3z9IiSsdK3CsIIVgLlM=; b=XzzUnALkmOJxmnC+pWue8MXkUr/wvcPQS5k1P+tg7JoGbQLOmUuNXdgutaC/2QMN6T U2XSw67rnPmG103U07RHXUw+4TVRZG6afVmVJ1cNemsDXY5im7qT9DXImBKmjilpLETE 8POonKC9CZvaHPtbommfg3HiJAr3fZ2llc/Y+gOnkOkx3/od1qyFbnni5fs8FXyOpQOt 8jQus45Vw+PXRsgdjILXPdh77lwSsy4E6vfo1Ta3ecW4MQmXt07Vqc63zeqxN1uuzSGG toZntbmxItUBA0HSDMQsctlK8AnwjP5qXX/mWrZOXAs930yTDz2VyckodpgPbtMdgW+t 8Ffg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=aIfA9wbCfiBiUBGcrU/yY6Uy3z9IiSsdK3CsIIVgLlM=; b=JWRsliQ95WWJ/J1Cp36mqkO0kM33jSsAHrCdFdAHQzDfHX72z3C0EAyIZ5Q5xy6m54 T19jPwcn2RwTPttnuGykHNrT4lMNL0OhCudw73oiaCkeGdp8LTyjJ1jr21TT+firagBp oY1G7LOy5VatKuY+u+knzBfvdWoaT9cWXEo0frMPM4Uw+zfnRDukMfACjXbvYJcsni7j NpNXSwQ6qebJoaNS16TJ6EbwGY/12F8vIAm6tfnf83Kb1eq5TBX/8lFDQuzwaKSZGAB+ c766/TVazjTwb0rltZk4jh6S8xsTW6TQ6mJYIo5CjBSoQ4AsZooREY8AK+F9ptXEmHRT t5gg== X-Gm-Message-State: APjAAAU7HyvO8JrI7XeFktYmL0QixYbHkYXrVn07WfcJKoywEa77VGB9 PHdyqHvxQWUPmhpGEGdn+00IG4QFM/o= X-Google-Smtp-Source: APXvYqxCMUqi6jPesnR4gAz47re7v2xE4YDiuJ6bdJkhLJDByO2DrZVkbqy21lqV8d1TuGlRq/Ugbw== X-Received: by 2002:a05:600c:294e:: with SMTP id n14mr651474wmd.18.1573502681804; Mon, 11 Nov 2019 12:04:41 -0800 (PST) Received: from localhost.localdomain (93-173-242-11.bb.netvision.net.il. [93.173.242.11]) by smtp.gmail.com with ESMTPSA id o10sm18593956wrq.92.2019.11.11.12.04.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Nov 2019 12:04:40 -0800 (PST) From: Avi Shukron To: buildroot@buildroot.org Date: Mon, 11 Nov 2019 22:03:52 +0200 Message-Id: <20191111200401.16924-1-avraham.shukron@gmail.com> X-Mailer: git-send-email 2.17.1 Subject: [Buildroot] [PATCH 1/2] package/ninja: invoke python3 explicitly to configure the package X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eric Le Bihan , Avi Shukron MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" ninja depends on python3 specifically, but the configure.py file simply uses "env python". Where no python is selected for the target you simply won't get a python symlink in $(HOST_DIR)/usr/bin, so the configure.py script fails to run since it can't find "python". Notice that in order to reproduce the issue, you must not have python2 installed on your host machine. Signed-off-by: Avi Shukron --- package/ninja/ninja.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/ninja/ninja.mk b/package/ninja/ninja.mk index 4897012150..867b92c4c3 100644 --- a/package/ninja/ninja.mk +++ b/package/ninja/ninja.mk @@ -17,7 +17,7 @@ NINJA_LICENSE_FILES = COPYING HOST_NINJA_DEPENDENCIES = host-python3 define HOST_NINJA_BUILD_CMDS - (cd $(@D); ./configure.py --bootstrap) + (cd $(@D); $(HOST_DIR)/bin/python3 ./configure.py --bootstrap) endef define HOST_NINJA_INSTALL_CMDS