Message ID | 20191005122227.7297-5-jerzy.m.grzegorek@gmail.com |
---|---|
State | Accepted |
Headers | show |
Series | Improve alphabetical order checking of Config.in files | expand |
Hello, On Sat, Oct 05, 2019 at 09:22 AM, Jerzy Grzegorek wrote: > Also order them alphabetically. > > Signed-off-by: Jerzy Grzegorek <jerzy.m.grzegorek@gmail.com> > Cc: Ricardo Martincoski <ricardo.martincoski@gmail.com> Acked-by: Ricardo Martincoski <ricardo.martincoski@gmail.com> Regards, Ricardo
diff --git a/utils/checkpackagelib/lib_config.py b/utils/checkpackagelib/lib_config.py index d1d4a4f549..c5d0dc0fdb 100644 --- a/utils/checkpackagelib/lib_config.py +++ b/utils/checkpackagelib/lib_config.py @@ -61,14 +61,13 @@ class AttributesOrder(_CheckFunction): class CommentsMenusPackagesOrder(_CheckFunction): - menu_of_packages = [""] - package = [""] - print_package_warning = [True] - def before(self): - self.state = "" self.level = 0 + self.menu_of_packages = [""] self.new_package = "" + self.package = [""] + self.print_package_warning = [True] + self.state = "" def get_level(self): return len(self.state.split('-')) - 1
Also order them alphabetically. Signed-off-by: Jerzy Grzegorek <jerzy.m.grzegorek@gmail.com> Cc: Ricardo Martincoski <ricardo.martincoski@gmail.com> --- utils/checkpackagelib/lib_config.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)