From patchwork Tue Sep 10 10:59:10 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carlos Santos X-Patchwork-Id: 1160263 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.136; helo=silver.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="N5yp9TE6"; dkim-atps=neutral Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46SMVX4Yl0z9sP3 for ; Tue, 10 Sep 2019 20:59:32 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 3166C203F2; Tue, 10 Sep 2019 10:59:30 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LnMNrXEx-d7a; Tue, 10 Sep 2019 10:59:27 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id D9A36203F9; Tue, 10 Sep 2019 10:59:27 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id BC1A91BF20B for ; Tue, 10 Sep 2019 10:59:26 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id B913481B86 for ; Tue, 10 Sep 2019 10:59:26 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9dlDE9EGCHXN for ; Tue, 10 Sep 2019 10:59:26 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-qt1-f195.google.com (mail-qt1-f195.google.com [209.85.160.195]) by whitealder.osuosl.org (Postfix) with ESMTPS id DA69981B7D for ; Tue, 10 Sep 2019 10:59:25 +0000 (UTC) Received: by mail-qt1-f195.google.com with SMTP id c17so784774qtv.9 for ; Tue, 10 Sep 2019 03:59:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=jHB9tO7GhtpShH9azauQTzqmPomQsm+ntjCcAeIW2JI=; b=N5yp9TE6dY3z72V5lN2tKrzsxoiVkVCHlANqVsjksGE7hfiL5O00V1EysC+p9UNnxY HXMkRwX9KCPyTuD1dOn4vHD5XtKed++BgsWfAxci3FCJ09uFnCqqivlP+83/f3VrYQ6F IyunZ9Wv73s6AgcCGKTdsOLkcKEGDd9ISLLK9i5SweyfQ8aJXyPITVDayuP24UIsmuia xvNhzpT1t/kQpywRJG8w2qUJdUJ1aJOeaV0ByYyWnr8iM/fC0lrikGzyCIVg1cQq+2k2 b+3KtoK6l68YBB0Fpkc03UcGud/M8Um5tw5rI9QvJIfL+AFsdHF0BGRvk1pYNWklaswI 7e+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=jHB9tO7GhtpShH9azauQTzqmPomQsm+ntjCcAeIW2JI=; b=UTUcDaJrtpy4eLwgtSfNTNneTO6CbkL+yBwRfeRCaDWLANHCXbZbK1N90zzW9nrX/y qbUeeqZ582CZo3gqBVC2HoWvxJN8rxPtqTn7vw/mCpXw8cBCcVM2tnvNvrgWqh6IdILR 3BKQdB0633cMVtYy/hju/jCZjPseTn+AflDd0qGeAhDCCXRTXWTSH3ldxGyaSKe8EQtR Q4ZrKM/7X6tZRDWnD09EZrzWQDmDBDX+PhZF2h7G/oh/ucCH9PdiaSXViU0QblXoRz11 QW4VlLICTkz3I2CVV6/IqVu8o34+F/Gs/lsBhSF5XNhGTxcOmX1aPpWVK7Gg+0pSCAtu /QlQ== X-Gm-Message-State: APjAAAWNZJe+f+Tl32+9Mt8K1Yz3kHQ0s51pZ9g5h4Pqo6S5ZZKsayAN iwqdFRUpMYqTw6IJf0Z0LM7Jk30nv+M= X-Google-Smtp-Source: APXvYqz5g4/ONnZvIR0OxZcYHTN4cwXmr4wlgl6296qOdJRvjX/woyukCNWoFWMunS0IHCk27zWHWg== X-Received: by 2002:ac8:6b50:: with SMTP id x16mr26940224qts.61.1568113164687; Tue, 10 Sep 2019 03:59:24 -0700 (PDT) Received: from casantos.remote.csb ([187.112.54.22]) by smtp.gmail.com with ESMTPSA id h10sm10261758qtk.18.2019.09.10.03.59.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Sep 2019 03:59:24 -0700 (PDT) From: unixmania@gmail.com To: buildroot@buildroot.org Date: Tue, 10 Sep 2019 07:59:10 -0300 Message-Id: <20190910105910.32098-1-unixmania@gmail.com> X-Mailer: git-send-email 2.18.1 Subject: [Buildroot] [PATCH v4] package/nfs-utils: enable IPv6 if libtirpc is selected X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Carlos Santos , Peter Seiderer , nathan.renniewaldock@gmail.com, Thomas Petazzoni MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Carlos Santos IPv6 support requires libtirpc, so enable it if libtirpc is selected. In practice this always enables IPv6, since nfs-utils needs rpcbind, which in its turn selects libtirpc. Fixes: https://bugs.busybox.net/show_bug.cgi?id=10806 Signed-off-by: Carlos Santos --- CC: nathan.renniewaldock@gmail.com CC: Peter Seiderer CC: Arnout Vandecappelle CC: Thomas Petazzoni -- Changes v1->v2 - Select LIBTIRPC unconditionally. Changes v2->v3 - Do not select libtirpc inconditionally Changes v3->v4 - Restore v1 commit message - Add comment about selecting libtirpc to Config.in So we're back to v1 with a lot of discussion in between. I want the bike shed purple. --- package/nfs-utils/Config.in | 3 +++ package/nfs-utils/nfs-utils.mk | 6 +++--- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/package/nfs-utils/Config.in b/package/nfs-utils/Config.in index 04ea4db3ed..966fe1406a 100644 --- a/package/nfs-utils/Config.in +++ b/package/nfs-utils/Config.in @@ -6,11 +6,14 @@ config BR2_PACKAGE_NFS_UTILS bool "nfs-utils" depends on BR2_TOOLCHAIN_HAS_THREADS # libtirpc, rpcbind depends on BR2_USE_MMU # fork() + # Just in case, since rpcbind already selects libtirpc select BR2_PACKAGE_LIBTIRPC if !BR2_TOOLCHAIN_HAS_NATIVE_RPC select BR2_PACKAGE_RPCBIND # runtime help The NFS Linux kernel server. + For IPv6 support, ensure that libtirpc is selected too. + http://linux-nfs.org/ if BR2_PACKAGE_NFS_UTILS diff --git a/package/nfs-utils/nfs-utils.mk b/package/nfs-utils/nfs-utils.mk index dc20942f71..3d5f5412cf 100644 --- a/package/nfs-utils/nfs-utils.mk +++ b/package/nfs-utils/nfs-utils.mk @@ -19,7 +19,6 @@ NFS_UTILS_CONF_OPTS = \ --disable-nfsv41 \ --disable-gss \ --disable-uuid \ - --disable-ipv6 \ --without-tcp-wrappers \ --with-statedir=/run/nfs \ --with-rpcgen=internal @@ -51,11 +50,12 @@ else NFS_UTILS_CONF_OPTS += --disable-caps endif +# IPv6 requires libtirpc ifeq ($(BR2_PACKAGE_LIBTIRPC),y) -NFS_UTILS_CONF_OPTS += --enable-tirpc +NFS_UTILS_CONF_OPTS += --enable-tirpc --enable-ipv6 NFS_UTILS_DEPENDENCIES += libtirpc else -NFS_UTILS_CONF_OPTS += --disable-tirpc +NFS_UTILS_CONF_OPTS += --disable-tirpc --disable-ipv6 endif define NFS_UTILS_INSTALL_FIXUP