From patchwork Fri Feb 22 01:07:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?J=C3=B6rg_Krause?= X-Patchwork-Id: 1046511 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.138; helo=whitealder.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=embedded.rocks Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 445Cqv5l2Vz9s9L for ; Fri, 22 Feb 2019 12:07:39 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id C237E87068; Fri, 22 Feb 2019 01:07:33 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IAH6Kj9bICeN; Fri, 22 Feb 2019 01:07:30 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 8A448870D5; Fri, 22 Feb 2019 01:07:30 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 551A61BF997 for ; Fri, 22 Feb 2019 01:07:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 5249A23453 for ; Fri, 22 Feb 2019 01:07:28 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FueRN44zj-Ms for ; Fri, 22 Feb 2019 01:07:25 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.142]) by silver.osuosl.org (Postfix) with ESMTPS id 81E38226FF for ; Fri, 22 Feb 2019 01:07:25 +0000 (UTC) Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id AE22A2400FD for ; Fri, 22 Feb 2019 02:07:22 +0100 (CET) Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 445CqY5DQpz9rxS; Fri, 22 Feb 2019 02:07:21 +0100 (CET) Received: from mail.embedded.rocks ([127.0.0.1]) by localhost (mail.embedded.rocks [127.0.0.1]) (amavisd-new, port 10025) with ESMTP id 5QbhX57pYc4J; Fri, 22 Feb 2019 02:07:20 +0100 (CET) Received: from nzxt.fritz.box (port-92-193-198-223.dynamic.qsc.de [92.193.198.223]) (Authenticated sender: joerg.krause@embedded.rocks) by mail.embedded.rocks (Postfix) with ESMTPSA; Fri, 22 Feb 2019 02:07:19 +0100 (CET) From: =?utf-8?q?J=C3=B6rg_Krause?= To: buildroot@buildroot.org Date: Fri, 22 Feb 2019 02:07:13 +0100 Message-Id: <20190222010714.22028-1-joerg.krause@embedded.rocks> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [Buildroot] [PATCH 1/2] Revert "package/libsoxr: add avutil to soxr.pc" X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fabrice Fontaine , Thomas Petazzoni Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" This reverts commit d81870ae8129389a62df80c9c8c9165d334b6921. The patch attempts to fix static linking with libsoxr when it build with avutils. The `Libs.private` field should not contain the full absolute path to the static library, but only the link flags for private libraries, e.g `-lm`. Buildroots pkg-config prepends the sysroot to the value found in `Libs.private` resulting in a malformed linker flag if libavutil is found: ``` -L/home/test/autobuild/run/instance-3/output/host/bin/../arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -lsoxr /home/test/autobuild/run/instance-3/output/host/bin/../arm-buildroot-linux-uclibcgnueabi/sysroot/home/test/autobuild/run/instance-3/output/host/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib/libavutil.a ``` .. or if libavutils is not found: ``` -L/home/test/autobuild/run/instance-1/output/host/bin/../arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -lsoxr AVUTIL_LIBRARIES-NOTFOUND ``` Revert this commit and replace the patch by a follow-up patch which only adds `-lavutil` to `Libs.private` in case it is found and used by libsoxr. Fixes: http://autobuild.buildroot.net/results/6eb4e2c9bd3884ab0152ddf873c20e62f0941181/ http://autobuild.buildroot.net/results/07207b0a58a08bf7c2cb78345a58244b5e6aab0e/ Signed-off-by: Jörg Krause --- ...0001-soxr.pc.in-add-avutil-libraries.patch | 33 ------------------- 1 file changed, 33 deletions(-) delete mode 100644 package/libsoxr/0001-soxr.pc.in-add-avutil-libraries.patch diff --git a/package/libsoxr/0001-soxr.pc.in-add-avutil-libraries.patch b/package/libsoxr/0001-soxr.pc.in-add-avutil-libraries.patch deleted file mode 100644 index c36988a77e..0000000000 --- a/package/libsoxr/0001-soxr.pc.in-add-avutil-libraries.patch +++ /dev/null @@ -1,33 +0,0 @@ -From 8c1edfc22f8b714062b149e3d80ab4357a1a4e49 Mon Sep 17 00:00:00 2001 -From: Fabrice Fontaine -Date: Thu, 22 Nov 2018 19:10:03 +0100 -Subject: [PATCH] soxr.pc.in: add avutil libraries - -Add ${AVUTIL_LIBRARIES} to soxr.pc.in so applications such as -shairport-sync will know that they must link with -lavutil when -building statically - -Fixes: - - http://autobuild.buildroot.org/results/839c0ce6475accc1de7e8a180d4358edb6750c64 - -Signed-off-by: Fabrice Fontaine -[Upstream status: https://sourceforge.net/p/soxr/code/merge-requests/2] -[Thomas: move to Libs.private.] -Signed-off-by: Thomas Petazzoni ---- - src/soxr.pc.in | 1 + - 1 file changed, 1 insertion(+) - -diff --git a/src/soxr.pc.in b/src/soxr.pc.in -index 69d225b..ed212a8 100644 ---- a/src/soxr.pc.in -+++ b/src/soxr.pc.in -@@ -2,4 +2,5 @@ Name: ${PROJECT_NAME} - Description: ${DESCRIPTION_SUMMARY} - Version: ${PROJECT_VERSION} - Libs: -L${LIB_INSTALL_DIR} -l${PROJECT_NAME} -+Libs.private: ${AVUTIL_LIBRARIES} - Cflags: -I${INCLUDE_INSTALL_DIR} --- -2.19.1 -