diff mbox series

package/wolfssl: bump to version 3.15.5

Message ID 20181120173801.15024-1-sergio.prado@e-labworks.com
State Changes Requested
Headers show
Series package/wolfssl: bump to version 3.15.5 | expand

Commit Message

Sergio Prado Nov. 20, 2018, 5:38 p.m. UTC
Also enable ARMv8 hardware acceleration (tested with
qemu_aarch64_virt_defconfig).

Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>
---
 package/wolfssl/wolfssl.hash | 2 +-
 package/wolfssl/wolfssl.mk   | 8 ++++++--
 2 files changed, 7 insertions(+), 3 deletions(-)

Comments

Thomas Petazzoni Nov. 21, 2018, 8:40 a.m. UTC | #1
Hello Sergio,

On Tue, 20 Nov 2018 15:38:01 -0200, Sergio Prado wrote:
> Also enable ARMv8 hardware acceleration (tested with
> qemu_aarch64_virt_defconfig).

Could be done in two separate patches (bump and ARMv8 HW acceleration
enabling).

> -# build fails when ARMv8 hardware acceleration is enabled
> +# enable ARMv8 hardware acceleration
> +ifeq ($(BR2_ARM_CPU_ARMV8A),y)
> +WOLFSSL_CONF_OPTS += --enable-armasm CPPFLAGS=-mstrict-align

Why is -mstrict-align needed ? A comment above, or at least in the
commit log would be useful. Also, don't override CPPFLAGS like this,
something like that would be preferred:

WOLFSSL_CONF_ENV += CPPFLAGS="$(TARGET_CPPFLAGS) -mstrict-align"

Thanks!

Thomas
diff mbox series

Patch

diff --git a/package/wolfssl/wolfssl.hash b/package/wolfssl/wolfssl.hash
index 76c7db25a844..2fdaa5762b6a 100644
--- a/package/wolfssl/wolfssl.hash
+++ b/package/wolfssl/wolfssl.hash
@@ -1,5 +1,5 @@ 
 # Locally computed:
-sha256 4ab543c869a65a77dc5d0bc934b9d4852aa3d5834bd2f707a74a936602bd3687  v3.14.0-stable.tar.gz
+sha256 4e15f494604e41725499f8b708798f8ddc2fcaa8f39b4369bcd000b3cab482d8  v3.15.5-stable.tar.gz
 
 # Hash for license files:
 sha256 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
diff --git a/package/wolfssl/wolfssl.mk b/package/wolfssl/wolfssl.mk
index c246b085131d..aec613321619 100644
--- a/package/wolfssl/wolfssl.mk
+++ b/package/wolfssl/wolfssl.mk
@@ -4,7 +4,7 @@ 
 #
 ################################################################################
 
-WOLFSSL_VERSION = 3.14.0
+WOLFSSL_VERSION = 3.15.5
 WOLFSSL_SITE = https://github.com/wolfSSL/wolfssl/archive
 WOLFSSL_SOURCE = v$(WOLFSSL_VERSION)-stable.tar.gz
 WOLFSSL_INSTALL_STAGING = YES
@@ -30,7 +30,11 @@  else
 WOLFSSL_CONF_OPTS += --disable-sslv3
 endif
 
-# build fails when ARMv8 hardware acceleration is enabled
+# enable ARMv8 hardware acceleration
+ifeq ($(BR2_ARM_CPU_ARMV8A),y)
+WOLFSSL_CONF_OPTS += --enable-armasm CPPFLAGS=-mstrict-align
+else
 WOLFSSL_CONF_OPTS += --disable-armasm
+endif
 
 $(eval $(autotools-package))