From patchwork Thu Oct 25 00:27:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adrian Perez de Castro X-Patchwork-Id: 988847 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.138; helo=whitealder.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=igalia.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=igalia.com header.i=@igalia.com header.b="NK5w3Ct1"; dkim-atps=neutral Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42gShz4lFmz9sBh for ; Thu, 25 Oct 2018 11:30:59 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id A083B88021; Thu, 25 Oct 2018 00:30:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XbqCeV5YS1p8; Thu, 25 Oct 2018 00:30:54 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 92DF38800D; Thu, 25 Oct 2018 00:30:54 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 3A7D01BF338 for ; Thu, 25 Oct 2018 00:30:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 3582F86F13 for ; Thu, 25 Oct 2018 00:30:53 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PcA6ieWObjBN for ; Thu, 25 Oct 2018 00:30:52 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from fanzine.igalia.com (fanzine.igalia.com [91.117.99.155]) by fraxinus.osuosl.org (Postfix) with ESMTPS id C56DC86EB5 for ; Thu, 25 Oct 2018 00:30:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From; bh=21HLhjCnNuQVShMU0ANF1nyzG8BiFmAHMakfjYC3SCM=; b=NK5w3Ct1AUYbMJT6ofz6Bc7AiJFLtqSGWTJcxJrjeW+/74ttlwq6a7emEtuWnj3oSyQIYmPBoruvl6MXy1G4Cg9iI8HIE9r9RueW/9FAhLDttIzBAJDFhoki+rqOqmGuYWdW02t7EVxr1rL/MMbSkd9+qBPPks8WYhZDCK+ppMVi2AAE6gnW1173xrLdLT93i3JF7FYp6HTXcp0vtJcOq75mRwZAHZ/DTIHhbS+7lTctEXDhHbcW4fmiljVgKl/LjXParWUgAkD/gE0Cxz2ZNotuZF/a6QlPcE3ONEJXtyyNeyTt/p3uPICb00sOn63FnWFknvAQaP/Z5fh7eBjBJg==; Received: from [194.100.51.2] (helo=kodama) by fanzine.igalia.com with esmtpsa (Cipher TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim) id 1gFTY1-00049E-9y; Thu, 25 Oct 2018 02:30:49 +0200 Received: from localhost (kodama [local]) by kodama (OpenSMTPD) with ESMTPA id 797138d5; Thu, 25 Oct 2018 00:27:38 +0000 (UTC) From: Adrian Perez de Castro To: buildroot@buildroot.org Date: Thu, 25 Oct 2018 03:27:38 +0300 Message-Id: <20181025002738.27486-1-aperez@igalia.com> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Subject: [Buildroot] [PATCH 1/1] webkitgtk: add an option to control USE_GSTREAMER_GL X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Adrian Perez de Castro Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" This covers the case where GL/GLES is available (so -DENABLE_OPENGL=ON gets passed), which makes the webkitgtk build system assume GStreamer-GL is available, while actually it is not. Also, providing an option to manually disable usage of GStremer-GL can help with certain target configurations in which using OpenGL for video handling might result in incorrect rendering. This fixes some autobuilder failures like the following: http://autobuild.buildroot.net/results/187796535af53ece426641ff7d88aabada281674 http://autobuild.buildroot.net/results/00c1a8ea23a99728a4f3f4478705f2383414ae41 Signed-off-by: Adrian Perez de Castro --- package/webkitgtk/Config.in | 15 +++++++++++++++ package/webkitgtk/webkitgtk.mk | 7 +++++++ 2 files changed, 22 insertions(+) diff --git a/package/webkitgtk/Config.in b/package/webkitgtk/Config.in index bf0a150251..f1228892af 100644 --- a/package/webkitgtk/Config.in +++ b/package/webkitgtk/Config.in @@ -105,6 +105,21 @@ config BR2_PACKAGE_WEBKITGTK_MULTIMEDIA This option pulls in all of the required dependencies to enable multimedia (video/audio) support. +if BR2_PACKAGE_WEBKITGTK_MULTIMEDIA + +config BR2_PACKAGE_WEBKITGTK_USE_GSTREAMER_GL + bool "use gstreamer-gl" + default y + depends on BR2_PACKAGE_GST1_PLUGINS_BASE_HAS_LIB_OPENGL + select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_GL + help + Use the GStreamer GL elements for handling video content. + This is recommended as it improves performance of video + playback. In some target configurations incorrect rendering + might be produced, and disabling this option may help. + +endif + config BR2_PACKAGE_WEBKITGTK_WEBDRIVER bool "WebDriver support" help diff --git a/package/webkitgtk/webkitgtk.mk b/package/webkitgtk/webkitgtk.mk index 39d681b1d4..1ba1cb5329 100644 --- a/package/webkitgtk/webkitgtk.mk +++ b/package/webkitgtk/webkitgtk.mk @@ -95,4 +95,11 @@ WEBKITGTK_CONF_OPTS += -DENABLE_WAYLAND_TARGET=ON endif endif +ifeq ($(BR2_PACKAGE_WEBKITGTK_USE_GSTREAMER_GL),y) +WEBKITGTK_CONF_OPTS += -DUSE_GSTREAMER_GL=ON +WEBKITGTK_DEPENDENCIES += gst1-plugins-bad +else +WEBKITGTK_CONF_OPTS += -DUSE_GSTREAMER_GL=OFF +endif + $(eval $(cmake-package))