diff mbox series

[3/3] oracle-mysql: check for my.cnf before starting

Message ID 20180820111304.22933-4-chrismcc@gmail.com
State Rejected
Headers show
Series oracle-mysql bugfix, security fix, and enhancement | expand

Commit Message

Christopher McCrory Aug. 20, 2018, 11:13 a.m. UTC 
Signed-off-by: Christopher McCrory <chrismcc@gmail.com>
---
 package/oracle-mysql/S97mysqld | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Petazzoni Aug. 20, 2018, 6:23 p.m. UTC | #1 
Hello,

On Mon, 20 Aug 2018 04:13:04 -0700, Christopher McCrory wrote:
> Signed-off-by: Christopher McCrory <chrismcc@gmail.com>
> ---
>  package/oracle-mysql/S97mysqld | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/oracle-mysql/S97mysqld b/package/oracle-mysql/S97mysqld
> index 110ca2cd12..9777ff7775 100644
> --- a/package/oracle-mysql/S97mysqld
> +++ b/package/oracle-mysql/S97mysqld
> @@ -3,6 +3,7 @@
>  MYSQL_DIR="/var/mysql"
>  MYSQL_USER="mysql"
>  
> +[ -r /etc/my.cnf ] || exit 0

Actually my preference is to fail hard if the configuration file
doesn't exist. I don't like those errors that are silently ignored, and
I've been lobbying to drop those test from our init scripts, and I
think most of the core contributors agreed with that.

If an /etc/my.cnf is mandatory for mysqld to start, then I would
suggest that we install an example/minimal /etc/my.cnf so that the
mysqld server starts properly in an out of the box Buildroot
installation.

Thanks!

Thomas
diff mbox series

Patch

diff --git a/package/oracle-mysql/S97mysqld b/package/oracle-mysql/S97mysqld
index 110ca2cd12..9777ff7775 100644
--- a/package/oracle-mysql/S97mysqld
+++ b/package/oracle-mysql/S97mysqld
@@ -3,6 +3,7 @@ 
 MYSQL_DIR="/var/mysql"
 MYSQL_USER="mysql"
 
+[ -r /etc/my.cnf ] || exit 0
 [ -r /etc/default/mysql ] && . /etc/default/mysql
 
 case "$1" in