diff mbox series

[RFC,2/2] perl-xml-parser: new package

Message ID 20180813175645.11088-3-chrismcc@gmail.com
State Changes Requested
Headers show
Series Hack for perl module subdirectories | expand

Commit Message

Christopher McCrory Aug. 13, 2018, 5:56 p.m. UTC 
Signed-off-by: Christopher McCrory <chrismcc@gmail.com>
---
 DEVELOPERS        | 1 +
 package/Config.in | 1 +
 2 files changed, 2 insertions(+)

Comments

Thomas Petazzoni Aug. 13, 2018, 9:05 p.m. UTC | #1 
Hello,

On Mon, 13 Aug 2018 10:56:45 -0700, Christopher McCrory wrote:
> Signed-off-by: Christopher McCrory <chrismcc@gmail.com>

This seems to be a partial patch.

Your patch series seems a bit messed up. You have sent:

  RFC PATCH 0/2
  RFC PATCH 1/2
  RFC PATCH 2/2 (this patch, which is partial)
  RFC PATCH 4/4

Could you fix this up and send a proper patch series ? If you're not
familiar yet with git send-email, I would suggest that you send your
patch series to yourself first, to make sure everything is correct,
before sending them to the Buildroot mailing list.

Thanks!

Thomas
Christopher McCrory Aug. 13, 2018, 9:54 p.m. UTC | #2 
Hello

On Mon, Aug 13, 2018, 2:05 PM Thomas Petazzoni <thomas.petazzoni@bootlin.com>
wrote:

> Hello,
>
> On Mon, 13 Aug 2018 10:56:45 -0700, Christopher McCrory wrote:
> > Signed-off-by: Christopher McCrory <chrismcc@gmail.com>
>
> This seems to be a partial patch.
>
> Your patch series seems a bit messed up. You have sent:
>
>   RFC PATCH 0/2
>   RFC PATCH 1/2
>   RFC PATCH 2/2 (this patch, which is partial)
>   RFC PATCH 4/4
>
> Could you fix this up and send a proper patch series ? If you're not
> familiar yet with git send-email, I would suggest that you send your
> patch series to yourself first, to make sure everything is correct,
> before sending them to the Buildroot mailing list.
>
> On phone so formatting might be off. And I'm a little buzzed.
>

I had a mistake in that package and git reverted to re gen the commit, and
forgot the git add afterwards. I can regen, but is the whole sed thing the
way to deal with this quirk?  Is there a better way that I am missing?
Hense the -- rfc.

And thank you for dealing with the whole Buildroot project.




>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> https://bootlin.com
>
<div dir="auto"><div>Hello<br><br><div class="gmail_quote"><div dir="ltr">On Mon, Aug 13, 2018, 2:05 PM Thomas Petazzoni &lt;<a href="mailto:thomas.petazzoni@bootlin.com">thomas.petazzoni@bootlin.com</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello,<br>
<br>
On Mon, 13 Aug 2018 10:56:45 -0700, Christopher McCrory wrote:<br>
&gt; Signed-off-by: Christopher McCrory &lt;<a href="mailto:chrismcc@gmail.com" target="_blank" rel="noreferrer">chrismcc@gmail.com</a>&gt;<br>
<br>
This seems to be a partial patch.<br>
<br>
Your patch series seems a bit messed up. You have sent:<br>
<br>
  RFC PATCH 0/2<br>
  RFC PATCH 1/2<br>
  RFC PATCH 2/2 (this patch, which is partial)<br>
  RFC PATCH 4/4<br>
<br>
Could you fix this up and send a proper patch series ? If you&#39;re not<br>
familiar yet with git send-email, I would suggest that you send your<br>
patch series to yourself first, to make sure everything is correct,<br>
before sending them to the Buildroot mailing list.<br>
<br>On phone so formatting might be off. And I&#39;m a little buzzed.<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">I had a mistake in that package and git reverted to re gen the commit, and forgot the git add afterwards. I can regen, but is the whole sed thing the way to deal with this quirk?  Is there a better way that I am missing?  Hense the -- rfc.</div><div dir="auto"><br></div><div dir="auto">And thank you for dealing with the whole Buildroot project. </div><div dir="auto"><br></div><div dir="auto"><br></div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br><br>
Thanks!<br>
<br>
Thomas<br>
-- <br>
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)<br>
Embedded Linux and Kernel engineering<br>
<a href="https://bootlin.com" rel="noreferrer noreferrer" target="_blank">https://bootlin.com</a><br>
</blockquote></div></div></div>
diff mbox series

Patch

diff --git a/DEVELOPERS b/DEVELOPERS
index d35cf3fb72..8cd71c0cfd 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -502,6 +502,7 @@  F:	package/perl-sub-install/
 F:	package/perl-sys-meminfo/
 F:	package/perl-sys-mmap/
 F:	package/perl-template-toolkit/
+F:	package/perl-xml-parser/
 
 N:	Clayton Shotwell <clayton.shotwell@rockwellcollins.com>
 F:	package/audit/
diff --git a/package/Config.in b/package/Config.in
index 6437cc0451..a83015a819 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -736,6 +736,7 @@  menu "Perl libraries/modules"
 	source "package/perl-www-robotrules/Config.in"
 	source "package/perl-xml-libxml/Config.in"
 	source "package/perl-xml-namespacesupport/Config.in"
+	source "package/perl-xml-parser/Config.in"
 	source "package/perl-xml-sax/Config.in"
 	source "package/perl-xml-sax-base/Config.in"
 endmenu