Message ID | 20180416022944.13644-9-casantos@datacom.ind.br |
---|---|
State | Accepted |
Headers | show |
Series | init scripts: don't test if binaries exist | expand |
> The test doesn't make sense. It just exits without any error if the > binary doesn't exist, which is silly. > Drop the MODEMMANAGER_BIN variable, which was never initialized. > Signed-off-by: Carlos Santos <casantos@datacom.ind.br> > --- Acked-by: Petr Vorel <petr.vorel@gmail.com> ... > +++ b/package/modem-manager/S44modem-manager > @@ -5,8 +5,6 @@ > PIDFILE=/var/run/ModemManager.pid > -[ -x $MODEMMANAGER_BIN ] || exit 0 > - > start() { > printf "Starting ModemManager: " > umask 077 Kind regards, Petr
diff --git a/package/modem-manager/S44modem-manager b/package/modem-manager/S44modem-manager index cf6d89601d..a3f5003aa1 100755 --- a/package/modem-manager/S44modem-manager +++ b/package/modem-manager/S44modem-manager @@ -5,8 +5,6 @@ PIDFILE=/var/run/ModemManager.pid -[ -x $MODEMMANAGER_BIN ] || exit 0 - start() { printf "Starting ModemManager: " umask 077
The test doesn't make sense. It just exits without any error if the binary doesn't exist, which is silly. Drop the MODEMMANAGER_BIN variable, which was never initialized. Signed-off-by: Carlos Santos <casantos@datacom.ind.br> --- package/modem-manager/S44modem-manager | 2 -- 1 file changed, 2 deletions(-)