| Message ID | 20180402081434.4411-6-maxime.hadjinlian@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v4,01/13] core/pkg-download: change all helpers to use common options | expand |
Maxime, All, On 2018-04-02 10:14 +0200, Maxime Hadjinlian spake thusly: > At the moment, it means that we make sure that BR2_DL_DIR is created, in > the future, it will make sure that BR2_DL_DIR/PKG_NAME/ is created. > > Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com> > --- > package/pkg-download.mk | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/package/pkg-download.mk b/package/pkg-download.mk > index 151b2e5423..e88d3f9fda 100644 > --- a/package/pkg-download.mk > +++ b/package/pkg-download.mk > @@ -88,7 +88,8 @@ endif > endif > > define DOWNLOAD > - $(Q)$(if $(filter bzr cvs hg svn,$($(PKG)_SITE_METHOD)),BR_NO_CHECK_HASH_FOR=$(notdir $(1));) \ > + $(Q)mkdir -p $($(PKG)_DL_DIR)/ > + $(Q)$(if $(filter bzr cvs hg svn,$($(PKG)_SITE_METHOD)),BR_NO_CHECK_HASH_FOR=$(notdir $(1))) \ This extra semi-colon should not be added in the first place, in patch 2/13. Regards, Yann E. MORIN. > $(EXTRA_ENV) $(DL_WRAPPER) \ > -c $($(PKG)_DL_VERSION) \ > -f $(notdir $(1)) \ > -- > 2.16.2 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Hello, On Mon, 2 Apr 2018 10:14:27 +0200, Maxime Hadjinlian wrote: > At the moment, it means that we make sure that BR2_DL_DIR is created, in > the future, it will make sure that BR2_DL_DIR/PKG_NAME/ is created. > > Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com> > --- > package/pkg-download.mk | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/package/pkg-download.mk b/package/pkg-download.mk > index 151b2e5423..e88d3f9fda 100644 > --- a/package/pkg-download.mk > +++ b/package/pkg-download.mk > @@ -88,7 +88,8 @@ endif > endif > > define DOWNLOAD > - $(Q)$(if $(filter bzr cvs hg svn,$($(PKG)_SITE_METHOD)),BR_NO_CHECK_HASH_FOR=$(notdir $(1));) \ > + $(Q)mkdir -p $($(PKG)_DL_DIR)/ Why is the trailing slash needed ? > + $(Q)$(if $(filter bzr cvs hg svn,$($(PKG)_SITE_METHOD)),BR_NO_CHECK_HASH_FOR=$(notdir $(1))) \ Why is this semi-colon removed ? Is this related to creating the download folder ? Thomas
diff --git a/package/pkg-download.mk b/package/pkg-download.mk index 151b2e5423..e88d3f9fda 100644 --- a/package/pkg-download.mk +++ b/package/pkg-download.mk @@ -88,7 +88,8 @@ endif endif define DOWNLOAD - $(Q)$(if $(filter bzr cvs hg svn,$($(PKG)_SITE_METHOD)),BR_NO_CHECK_HASH_FOR=$(notdir $(1));) \ + $(Q)mkdir -p $($(PKG)_DL_DIR)/ + $(Q)$(if $(filter bzr cvs hg svn,$($(PKG)_SITE_METHOD)),BR_NO_CHECK_HASH_FOR=$(notdir $(1))) \ $(EXTRA_ENV) $(DL_WRAPPER) \ -c $($(PKG)_DL_VERSION) \ -f $(notdir $(1)) \
At the moment, it means that we make sure that BR2_DL_DIR is created, in the future, it will make sure that BR2_DL_DIR/PKG_NAME/ is created. Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com> --- package/pkg-download.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)