diff mbox series

[1/6] tpm2-tss: declare dependency on a toolchain with C++

Message ID 20180322202752.2562-2-casantos@datacom.ind.br
State Accepted
Commit 319078d5dec8388f13a863546cf7ee2d79880d98
Headers show
Series tpm2-{tss, abrmd, tools} fix compilation errors | expand

Commit Message

Carlos Santos March 22, 2018, 8:27 p.m. UTC
Version 1.4.0 still contains some C++ code. This has already changed on
upstream, so future versions will drop the dependency on a C++ compiler.

Signed-off-by: Carlos Santos <casantos@datacom.ind.br>
---
 package/tpm2-tss/Config.in | 3 +++
 1 file changed, 3 insertions(+)

Comments

Peter Korsgaard March 22, 2018, 10:51 p.m. UTC | #1
>>>>> "Carlos" == Carlos Santos <casantos@datacom.ind.br> writes:

 > Version 1.4.0 still contains some C++ code. This has already changed on
 > upstream, so future versions will drop the dependency on a C++ compiler.

 > Signed-off-by: Carlos Santos <casantos@datacom.ind.br>
 > ---
 >  package/tpm2-tss/Config.in | 3 +++
 >  1 file changed, 3 insertions(+)

 > diff --git a/package/tpm2-tss/Config.in b/package/tpm2-tss/Config.in
 > index ebf0fd262d..f1a9920700 100644
 > --- a/package/tpm2-tss/Config.in
 > +++ b/package/tpm2-tss/Config.in
 > @@ -29,3 +29,6 @@ config BR2_PACKAGE_TPM2_TSS
 >  	    Microsoft software TPM2 simulator.
 
 >  	  https://github.com/tpm2-software/tpm2-tss
 > +
 > +comment "tpm2-tss needs a toolchain w/ C++"
 > +        depends on !BR2_INSTALL_LIBSTDCPP

This should have been indented with a <tab> and the BR2_PACKAGE_TPM2_TSS
option should also have the C++ dependency.

Consider running utils/check-package on your patches.

Committed with that fixed, thanks.
diff mbox series

Patch

diff --git a/package/tpm2-tss/Config.in b/package/tpm2-tss/Config.in
index ebf0fd262d..f1a9920700 100644
--- a/package/tpm2-tss/Config.in
+++ b/package/tpm2-tss/Config.in
@@ -29,3 +29,6 @@  config BR2_PACKAGE_TPM2_TSS
 	    Microsoft software TPM2 simulator.
 
 	  https://github.com/tpm2-software/tpm2-tss
+
+comment "tpm2-tss needs a toolchain w/ C++"
+        depends on !BR2_INSTALL_LIBSTDCPP