| Message ID | 20180114175306.18388-1-joerg.krause@embedded.rocks |
|---|---|
| State | Accepted |
| Commit | 65793bab3d21b1a8d6091174eb2f57b6a8d61b51 |
| Headers | show |
| Series | swupdate: remove empty line | expand |
J"org, All, On 2018-01-14 18:53 +0100, Jörg Krause spake thusly: > Reported by Yann E. Morin running: > > ``` > $ ./utils/check-package package/swupdate/swupdate.mk > package/swupdate/swupdate.mk:42: consecutive empty lines > 140 lines processed > 1 warnings generated > ``` Note: I could have very well done it myself, but by having other do it, that spreads the knowledge, and people get used to running it before submitting. Or so I hope! ;-) Thanks! :-) > Reported-by: Yann E. MORIN <yann.morin.1998@free.fr> > Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks> Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Regards, Yann E. MORIN. > --- > package/swupdate/swupdate.mk | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/package/swupdate/swupdate.mk b/package/swupdate/swupdate.mk > index d1afbc4882..aa232e5837 100644 > --- a/package/swupdate/swupdate.mk > +++ b/package/swupdate/swupdate.mk > @@ -39,7 +39,6 @@ else > SWUPDATE_MAKE_ENV += HAVE_LIBCURL=n > endif > > - > ifeq ($(BR2_PACKAGE_HAS_LUAINTERPRETER),y) > SWUPDATE_DEPENDENCIES += luainterpreter host-pkgconf > # defines the base name for the pkg-config file ("lua" or "luajit") > -- > 2.15.1 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Yann, On Sun, 2018-01-14 at 19:03 +0100, Yann E. MORIN wrote: > J"org, All, > > On 2018-01-14 18:53 +0100, Jörg Krause spake thusly: > > Reported by Yann E. Morin running: > > > > ``` > > $ ./utils/check-package package/swupdate/swupdate.mk > > package/swupdate/swupdate.mk:42: consecutive empty lines > > 140 lines processed > > 1 warnings generated > > ``` > > Note: I could have very well done it myself, but by having other do it, > that spreads the knowledge, and people get used to running it before > submitting. Or so I hope! ;-) No problem! Mostly I am running check-package only when submitting a new package. But, I will try next time to remember of running it every time :-) Jörg
>>>>> "Jörg" == Jörg Krause <joerg.krause@embedded.rocks> writes: > Reported by Yann E. Morin running: > ``` > $ ./utils/check-package package/swupdate/swupdate.mk > package/swupdate/swupdate.mk:42: consecutive empty lines > 140 lines processed > 1 warnings generated > ``` > Reported-by: Yann E. MORIN <yann.morin.1998@free.fr> > Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks> Committed, thanks.
diff --git a/package/swupdate/swupdate.mk b/package/swupdate/swupdate.mk index d1afbc4882..aa232e5837 100644 --- a/package/swupdate/swupdate.mk +++ b/package/swupdate/swupdate.mk @@ -39,7 +39,6 @@ else SWUPDATE_MAKE_ENV += HAVE_LIBCURL=n endif - ifeq ($(BR2_PACKAGE_HAS_LUAINTERPRETER),y) SWUPDATE_DEPENDENCIES += luainterpreter host-pkgconf # defines the base name for the pkg-config file ("lua" or "luajit")
Reported by Yann E. Morin running: ``` $ ./utils/check-package package/swupdate/swupdate.mk package/swupdate/swupdate.mk:42: consecutive empty lines 140 lines processed 1 warnings generated ``` Reported-by: Yann E. MORIN <yann.morin.1998@free.fr> Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks> --- package/swupdate/swupdate.mk | 1 - 1 file changed, 1 deletion(-)