From patchwork Tue Nov 28 16:06:51 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carlos Santos X-Patchwork-Id: 842223 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.138; helo=whitealder.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3ymT7v3PMYz9t2Z for ; Wed, 29 Nov 2017 03:07:07 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 7C18886DC3; Tue, 28 Nov 2017 16:07:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hIwOXOzr0ker; Tue, 28 Nov 2017 16:07:03 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 71FC986DC9; Tue, 28 Nov 2017 16:07:03 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 597B11C0240 for ; Tue, 28 Nov 2017 16:07:02 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 543222F5F1 for ; Tue, 28 Nov 2017 16:07:02 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 50czS-lh8DFo for ; Tue, 28 Nov 2017 16:07:00 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.datacom.ind.br (mx.datacom.ind.br [177.66.5.10]) by silver.osuosl.org (Postfix) with ESMTPS id 84E0E2F5CD for ; Tue, 28 Nov 2017 16:07:00 +0000 (UTC) Received: from mail.datacom.ind.br (localhost [127.0.0.1]) by mail.datacom.ind.br (Postfix) with ESMTPS id D02F0167D089; Tue, 28 Nov 2017 14:03:39 -0200 (BRST) Received: from localhost (localhost [127.0.0.1]) by mail.datacom.ind.br (Postfix) with ESMTP id C0DB2167D088; Tue, 28 Nov 2017 14:03:39 -0200 (BRST) Received: from mail.datacom.ind.br ([127.0.0.1]) by localhost (mail.datacom.ind.br [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id EzG5nvfO-QYe; Tue, 28 Nov 2017 14:03:39 -0200 (BRST) Received: from pedeld202344.datacom.net (pedeld202344.datacom.net [10.0.120.87]) by mail.datacom.ind.br (Postfix) with ESMTPSA id 9AC16167CFA8; Tue, 28 Nov 2017 14:03:39 -0200 (BRST) From: Carlos Santos To: buildroot@buildroot.org Date: Tue, 28 Nov 2017 14:06:51 -0200 Message-Id: <20171128160651.20880-1-casantos@datacom.ind.br> X-Mailer: git-send-email 2.14.3 In-Reply-To: <0171128125226.32n343bxgzhcrfvp@tarshish> References: <0171128125226.32n343bxgzhcrfvp@tarshish> Subject: [Buildroot] [PATCH v2] mtools: do not link to libbsd X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.24 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" If libbsd is found by the configuration process, mtools unnecessarily adds a NEEDED field with libbsd to its dynamic section, but it does not actually use anything from libbsd under Linux. The same may happen to host-mtools if some libbsd package is installed on the host machine. Prevent this by forcing configure to bypass the checking for the existence of a gethostbyname function in libbsd. I stumbled on this problem when I built host-mtools and later removed libbsd to upgrade to Fedora 27, due to Bug 1504831[1]. The previously built host/bin/mtools started to fail due to the missing libbsd.so.0. 1. https://bugzilla.redhat.com/show_bug.cgi?id=1504831 Signed-off-by: Carlos Santos --- Changes v1->v2 - Improved the commit message, as requested by Baruch Siach. --- package/mtools/mtools.mk | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/package/mtools/mtools.mk b/package/mtools/mtools.mk index 5db548fad9..1a6218831e 100644 --- a/package/mtools/mtools.mk +++ b/package/mtools/mtools.mk @@ -13,9 +13,13 @@ MTOOLS_CONF_OPTS = --without-x # info documentation not needed MTOOLS_CONF_ENV = \ ac_cv_func_setpgrp_void=yes \ + ac_cv_lib_bsd_gethostbyname=no \ + ac_cv_lib_bsd_main=no \ ac_cv_path_INSTALL_INFO= HOST_MTOOLS_CONF_ENV = \ + ac_cv_lib_bsd_gethostbyname=no \ + ac_cv_lib_bsd_main=no \ ac_cv_path_INSTALL_INFO= # link with iconv if enabled