diff mbox

[1/1] webkitgtk: Add patch for properly picking GL flags when building

Message ID 20170803112253.26619-1-aperez@igalia.com
State Superseded
Headers show

Commit Message

Adrian Perez de Castro Aug. 3, 2017, 11:22 a.m. UTC
This solves build failures caused by WebKit trying to include X11 headers
when support for X11 is disabled in Mesa3D. A common situation is when
configuring both GTK+ and WebKitGTK+ only with Wayland support.

Once the fix for https://bugs.webkit.org/show_bug.cgi?id=175125 makes it
into a release, the patch can be dropped.

Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
---
 ...AGS-from-pkg-config-for-E-GL-are-not-pass.patch | 82 ++++++++++++++++++++++
 1 file changed, 82 insertions(+)
 create mode 100644 package/webkitgtk/0004-GTK-WPE-CFLAGS-from-pkg-config-for-E-GL-are-not-pass.patch

Comments

Adrian Perez de Castro Aug. 3, 2017, 11:28 a.m. UTC | #1
On Thu,  3 Aug 2017 14:22:53 +0300, Adrian Perez de Castro <aperez@igalia.com> wrote:
> This solves build failures caused by WebKit trying to include X11 headers
> when support for X11 is disabled in Mesa3D. A common situation is when
> configuring both GTK+ and WebKitGTK+ only with Wayland support.
> 
> Once the fix for https://bugs.webkit.org/show_bug.cgi?id=175125 makes it
> into a release, the patch can be dropped.
> 
> Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>

Don't commit this. I forgot again to remove the hunk for the ChangeLog edits.
I'll submit a v2 in a minute :-\


--
 Adrián 🎩
diff mbox

Patch

diff --git a/package/webkitgtk/0004-GTK-WPE-CFLAGS-from-pkg-config-for-E-GL-are-not-pass.patch b/package/webkitgtk/0004-GTK-WPE-CFLAGS-from-pkg-config-for-E-GL-are-not-pass.patch
new file mode 100644
index 0000000000..229242f122
--- /dev/null
+++ b/package/webkitgtk/0004-GTK-WPE-CFLAGS-from-pkg-config-for-E-GL-are-not-pass.patch
@@ -0,0 +1,82 @@ 
+From 6579c307d85a9b447d3b7f13b25fb0a52177ed09 Mon Sep 17 00:00:00 2001
+From: Carlos Alberto Lopez Perez <clopez@igalia.com>
+Date: Thu, 3 Aug 2017 13:57:14 +0300
+Subject: [PATCH] [GTK][WPE] CFLAGS from pkg-config for (E)GL are not passed to
+ WebKit https://bugs.webkit.org/show_bug.cgi?id=175125
+
+Patch by Carlos Alberto Lopez Perez <clopez@igalia.com> on 2017-08-03
+Reviewed by NOBODY (OOPS!).
+
+* CMakeLists.txt: Pass GL-related flags to the WebKit component when
+  appropriate.
+
+Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
+
+---
+ Source/WebKit2/CMakeLists.txt | 31 +++++++++++++++++++++++++++++++
+ Source/WebKit2/ChangeLog      | 10 ++++++++++
+ 2 files changed, 41 insertions(+)
+
+diff --git a/Source/WebKit2/CMakeLists.txt b/Source/WebKit2/CMakeLists.txt
+index 2d8215f6a35..b25e9872de2 100644
+--- a/Source/WebKit2/CMakeLists.txt
++++ b/Source/WebKit2/CMakeLists.txt
+@@ -88,6 +88,37 @@ set(WebKit2_SYSTEM_INCLUDE_DIRECTORIES
+ )
+ 
+ if (ENABLE_GRAPHICS_CONTEXT_3D)
++    # For platforms that want to use system-provided OpenGL (ES) / EGL headers,
++    # these include directories, libraries or definitions need to be
++    # added before the ANGLE directories.
++    if (USE_OPENGL)
++        list(APPEND WebKit2_SYSTEM_INCLUDE_DIRECTORIES
++            ${OPENGL_INCLUDE_DIRS}
++        )
++        list(APPEND WebKit2_LIBRARIES
++            ${OPENGL_LIBRARIES}
++        )
++        add_definitions(${OPENGL_DEFINITIONS})
++    elseif (USE_OPENGL_ES_2)
++        list(APPEND WebKit2_SYSTEM_INCLUDE_DIRECTORIES
++            ${OPENGLES2_INCLUDE_DIRS}
++        )
++        list(APPEND WebKit2_LIBRARIES
++            ${OPENGLES2_LIBRARIES}
++        )
++        add_definitions(${OPENGLES2_DEFINITIONS})
++    endif ()
++
++    if (USE_EGL)
++        list(APPEND WebKit2_SYSTEM_INCLUDE_DIRECTORIES
++            ${EGL_INCLUDE_DIRS}
++        )
++        list(APPEND WebKit2_LIBRARIES
++            ${EGL_LIBRARIES}
++        )
++        add_definitions(${EGL_DEFINITIONS})
++    endif ()
++
+     list(APPEND WebKit2_INCLUDE_DIRECTORIES
+         "${THIRDPARTY_DIR}/ANGLE"
+         "${THIRDPARTY_DIR}/ANGLE/include/KHR"
+diff --git a/Source/WebKit2/ChangeLog b/Source/WebKit2/ChangeLog
+index 63315cd55ed..046a85e9199 100644
+--- a/Source/WebKit2/ChangeLog
++++ b/Source/WebKit2/ChangeLog
+@@ -1,3 +1,13 @@
++2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
++
++        [GTK][WPE] CFLAGS from pkg-config for (E)GL are not passed to WebKit
++        https://bugs.webkit.org/show_bug.cgi?id=175125
++
++        Reviewed by NOBODY (OOPS!).
++
++        * CMakeLists.txt: Pass GL-related flags to the WebKit component when
++          appropriate.
++
+ 2017-07-24  Carlos Garcia Campos  <cgarcia@igalia.com>
+ 
+         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.16.6 release.
+-- 
+2.13.4
+