| Message ID | 20170209174759.15819-2-joerg.krause@embedded.rocks |
|---|---|
| State | Accepted |
| Headers | show |
Hello, On Thu, 9 Feb 2017 18:47:54 +0100, Jörg Krause wrote: > +# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64735 I've taken a part of your commit log, and added it as a comment here. > +config BR2_TOOLCHAIN_HAS_GCC_BUG_64735 > + bool Instead of having this option selected by the architecture code, I've added the relevant "default y" and "depends on" here. I believe it's not worth spreading these selects all over the place. Now that I write this, I realize I've written the logic in the wrong way, I'll fix that up now. Thanks! Thomas
Hi Thomas, On Thu, 2017-02-09 at 21:30 +0100, Thomas Petazzoni wrote: > Hello, > > On Thu, 9 Feb 2017 18:47:54 +0100, Jörg Krause wrote: > > > +# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64735 > > I've taken a part of your commit log, and added it as a comment here. > > > +config BR2_TOOLCHAIN_HAS_GCC_BUG_64735 > > + bool > > Instead of having this option selected by the architecture code, I've > added the relevant "default y" and "depends on" here. I believe it's > not worth spreading these selects all over the place. You're right! It's much cleaner this way. Thanks! > Now that I write this, I realize I've written the logic in the wrong > way, I'll fix that up now. Jörg
diff --git a/toolchain/toolchain-common.in b/toolchain/toolchain-common.in index 7a217b65c..0bd80c9fd 100644 --- a/toolchain/toolchain-common.in +++ b/toolchain/toolchain-common.in @@ -7,6 +7,10 @@ source "package/gdb/Config.in.host" comment "Toolchain Generic Options" +# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64735 +config BR2_TOOLCHAIN_HAS_GCC_BUG_64735 + bool + # https://sourceware.org/bugzilla/show_bug.cgi?id=19405 config BR2_TOOLCHAIN_HAS_BINUTILS_BUG_19405 bool
exception_ptr, nested_exception, and future from libstdc++ are not available for architectures not supporting always lock-free atomic ints before GCC 7. Bug report: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64735 Fix available starting from GCC 7 (not yet released): https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=244051 Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks> --- toolchain/toolchain-common.in | 4 ++++ 1 file changed, 4 insertions(+)