From patchwork Tue Jan 10 22:39:25 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?J=C3=B6rg_Krause?= X-Patchwork-Id: 713464 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3tyn5Z4v9Xz9ryn for ; Wed, 11 Jan 2017 09:39:46 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="key not found in DNS" (0-bit key; unprotected) header.d=embedded.rocks header.i=@embedded.rocks header.b="Aoh5MSYn"; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id C03DE88B98; Tue, 10 Jan 2017 22:39:43 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jfdZrRRSQJrZ; Tue, 10 Jan 2017 22:39:42 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 106CC88AB5; Tue, 10 Jan 2017 22:39:42 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id A3DBE1C003A for ; Tue, 10 Jan 2017 22:39:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 9CBF12FD7B for ; Tue, 10 Jan 2017 22:39:40 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fZm32BNWpGCJ for ; Tue, 10 Jan 2017 22:39:39 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.142]) by silver.osuosl.org (Postfix) with ESMTPS id 44D5B2FD79 for ; Tue, 10 Jan 2017 22:39:39 +0000 (UTC) Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 3tyn5F5lK4z104d for ; Tue, 10 Jan 2017 23:39:29 +0100 (CET) Authentication-Results: mail.embedded.rocks (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=embedded.rocks DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embedded.rocks; h=content-transfer-encoding:content-type:content-type :mime-version:x-mailer:message-id:date:date:subject:subject:from :from:received:received; s=default; t=1484087968; x=1484692769; bh=1BDujj5H2Tlerk5zgebsD68hInqFco4kuqmho9lySl8=; b=Aoh5MSYn/zZ9 jCss3jC5fv5KRXNCWjHKwpMm2/TEcjfWwM6y6MFyaktYczjmS79RwoExQFnFgnqA vkdgLIo9kk+634XAp78EgZmxjTfFtQmMpqvRCCWVpewgg11LnWIIMqlOWm2/pput K95Git0x4ByBzW6ylJubNzywMvIlaF/tff5YrloqFQpykINc/qun/+sHfz5pJmEU SFAqWhcroeBCeZEMbDxc2icMq807W6nSRrS2+kWHkOMJDXyeHVD4cJ2wIz2fIDjd ZQ7zAtkMM81iZnsJ78fp6KM1cKoTiaIHNyJTxc8fzY2lxPvtVLnJo5Dq93+xqbf9 SgDTGyv0PQ== Received: from mail.embedded.rocks ([127.0.0.1]) by localhost (mail.embedded.rocks [127.0.0.1]) (amavisd-new, port 10025) with ESMTP id nFrH8G3miWhH; Tue, 10 Jan 2017 23:39:28 +0100 (CET) Received: from nzxt.fritz.box (xd933e80a.dyn.telefonica.de [217.51.232.10]) (Authenticated sender: joerg.krause@embedded.rocks) by mail.embedded.rocks (Postfix) with ESMTPSA; Tue, 10 Jan 2017 23:39:28 +0100 (CET) From: =?UTF-8?q?J=C3=B6rg=20Krause?= To: buildroot@buildroot.org Date: Tue, 10 Jan 2017 23:39:25 +0100 Message-Id: <20170110223925.2896-1-joerg.krause@embedded.rocks> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Subject: [Buildroot] [PATCH v2] package/mpd: fix static linking with tremor X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Although tremor (the library is named vorbisidec) provides a pkg-config file, mpd does not use it to find tremor. Since version 0.20 does throw an error instead of a warning, that's why the issue was left unnoticed by the autobuilders. Help mpd to find tremor by providing the path to the library and passing LIBS through the environment. We use the host pkg-config tool to get the correct values from the vorbisidec.pc file. Fixes: http://autobuild.buildroot.net/results/6b9/6b97403e70caa12c32494b1c82ce61d3e4e456f6/ Signed-off-by: Jörg Krause --- Changes v2: - Add autobuild link --- package/mpd/mpd.mk | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/package/mpd/mpd.mk b/package/mpd/mpd.mk index 10e6b90dd..bee68436d 100644 --- a/package/mpd/mpd.mk +++ b/package/mpd/mpd.mk @@ -222,7 +222,10 @@ endif ifeq ($(BR2_PACKAGE_MPD_TREMOR),y) MPD_DEPENDENCIES += tremor -MPD_CONF_OPTS += --with-tremor +# Help mpd to find tremor in static linking scenarios +MPD_CONF_ENV += \ + TREMOR_LIBS="`$(PKG_CONFIG_HOST_BINARY) --libs vorbisidec`" +MPD_CONF_OPTS += --with-tremor=$(STAGING_DIR)/usr endif ifeq ($(BR2_PACKAGE_MPD_TWOLAME),y)