From patchwork Tue Jan 10 22:23:42 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?J=C3=B6rg_Krause?= X-Patchwork-Id: 713460 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3tymlV4MmZz9t6g for ; Wed, 11 Jan 2017 09:24:05 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="key not found in DNS" (0-bit key; unprotected) header.d=embedded.rocks header.i=@embedded.rocks header.b="aJ/VUwmy"; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 0BDCF2FDD4; Tue, 10 Jan 2017 22:24:02 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Xz7brilnOY1p; Tue, 10 Jan 2017 22:24:00 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 1ED122FC7F; Tue, 10 Jan 2017 22:24:00 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 712E31C003A for ; Tue, 10 Jan 2017 22:23:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 6D62288B4B for ; Tue, 10 Jan 2017 22:23:58 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lc6fvlsMriN0 for ; Tue, 10 Jan 2017 22:23:56 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.142]) by hemlock.osuosl.org (Postfix) with ESMTPS id C2C808831B for ; Tue, 10 Jan 2017 22:23:56 +0000 (UTC) Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 3tyml83RDnz108s for ; Tue, 10 Jan 2017 23:23:48 +0100 (CET) Authentication-Results: mail.embedded.rocks (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=embedded.rocks DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embedded.rocks; h=content-transfer-encoding:content-type:content-type :mime-version:x-mailer:message-id:date:date:subject:subject:from :from:received:received; s=default; t=1484087026; x=1484691827; bh=Yg+LW/UA5kayvnukZXfupcQWGn5huUx44x8BgR/0fZI=; b=aJ/VUwmyuQwx 3WYmDsXhtybGPa5n8c6cP8mL2SLzCBY8H4syQrHSF8xrUF8HBy1zu+Zu0viGrVWC xPOyzE+2HttgdFwKRwHJ1znpgJFnPHopdsQGW2uZBgvshWOpNPGjoF3DclZqEC8l 9+D8cPxgXTvarOr7s7gYUFbB9Zl4tq5fNgSbGrSuaSIlHGeak9NZL/LuqPUmn/57 YQc8TiXU3lil0BL+yfMi6AgtYf6jF8PYd0uNjlJ5ZPh+0wNfIfOmWuEavPuQ9/2y VR5/DJI6m06HNsrgWJRsNgT+athHX4LHDFFJAhEtRmIcb7Txk/C0+YkDiB23Pmb9 hli+k0/ixA== Received: from mail.embedded.rocks ([127.0.0.1]) by localhost (mail.embedded.rocks [127.0.0.1]) (amavisd-new, port 10025) with ESMTP id GPnRzLqyHcf5; Tue, 10 Jan 2017 23:23:46 +0100 (CET) Received: from nzxt.fritz.box (xd933e80a.dyn.telefonica.de [217.51.232.10]) (Authenticated sender: joerg.krause@embedded.rocks) by mail.embedded.rocks (Postfix) with ESMTPSA; Tue, 10 Jan 2017 23:23:46 +0100 (CET) From: =?UTF-8?q?J=C3=B6rg=20Krause?= To: buildroot@buildroot.org Date: Tue, 10 Jan 2017 23:23:42 +0100 Message-Id: <20170110222342.21045-1-joerg.krause@embedded.rocks> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Subject: [Buildroot] [PATCH] package/mpd: fix static linking with tremor X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Although tremor (the library is named vorbisidec) provides a pkg-config file, mpd does not use it to find tremor. Since version 0.20 does throw an error instead of a warning, that's why the issue was left unnoticed by the autobuilders. Help mpd to find tremor by providing the path to the library and passing LIBS through the environment. We use the host pkg-config tool to get the correct values from the vorbisidec.pc file. Signed-off-by: Jörg Krause --- package/mpd/mpd.mk | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/package/mpd/mpd.mk b/package/mpd/mpd.mk index 10e6b90dd..bee68436d 100644 --- a/package/mpd/mpd.mk +++ b/package/mpd/mpd.mk @@ -222,7 +222,10 @@ endif ifeq ($(BR2_PACKAGE_MPD_TREMOR),y) MPD_DEPENDENCIES += tremor -MPD_CONF_OPTS += --with-tremor +# Help mpd to find tremor in static linking scenarios +MPD_CONF_ENV += \ + TREMOR_LIBS="`$(PKG_CONFIG_HOST_BINARY) --libs vorbisidec`" +MPD_CONF_OPTS += --with-tremor=$(STAGING_DIR)/usr endif ifeq ($(BR2_PACKAGE_MPD_TWOLAME),y)